{"thread":{"id":"40823","subject":"[PATCH] blame: add test case for using tag object as a final ref","startedAt":"2015-11-18T05:36:32Z","lastAt":"2015-11-18T06:00:18Z","messageCount":2,"participants":["Max Kirillov","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273465","messageId":"1447824992-28520-1-git-send-email-max@max630.net","threadId":"40823","inReplyTo":null,"subject":"[PATCH] blame: add test case for using tag object as a final ref","fromName":"Max Kirillov","fromEmail":"max@max630.net","sentAt":"2015-11-18T05:36:32Z","receivedAt":"2015-11-18T05:36:32Z","isPatch":true,"sender":{"key":"max@max630.net","avatar":"https://avatars.githubusercontent.com/u/381560?v=4"},"body":"It was discovered [1] that 1b0d40000a broke blaming starting from tag object.\nAdd test which verifies such blaming works.\n\n[1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net\n\nSigned-off-by: Max Kirillov <max@max630.net>\n---\nThank you. Sorry, I should have noticed that obj ended up unused.\n\nAdding test case for it. Looks ok after the fix.\n t/annotate-tests.sh | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/t/annotate-tests.sh b/t/annotate-tests.sh\nindex b1673b3..093832f 100644\n--- a/t/annotate-tests.sh\n+++ b/t/annotate-tests.sh\n@@ -68,6 +68,13 @@ test_expect_success 'blame 1 author' '\n \tcheck_count A 2\n '\n \n+test_expect_success 'blame by tag objects' '\n+\tgit tag -m \"test tag\" testTag &&\n+\tgit tag -m \"test tag #2\" testTag2 testTag &&\n+\tcheck_count -h testTag A 2 &&\n+\tcheck_count -h testTag2 A 2\n+'\n+\n test_expect_success 'setup B lines' '\n \techo \"2A quick brown fox jumps over the\" >>file &&\n \techo \"lazy dog\" >>file &&\n-- \n2.3.4.2801.g3d0809b\n"},{"id":"273466","messageId":"20151118060018.GA22541@sigill.intra.peff.net","threadId":"40823","inReplyTo":"1447824992-28520-1-git-send-email-max@max630.net","subject":"Re: [PATCH] blame: add test case for using tag object as a final ref","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-11-18T06:00:18Z","receivedAt":"2015-11-18T06:00:18Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Nov 18, 2015 at 07:36:32AM +0200, Max Kirillov wrote:\n\n> It was discovered [1] that 1b0d40000a broke blaming starting from tag object.\n> Add test which verifies such blaming works.\n> \n> [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net\n> \n> Signed-off-by: Max Kirillov <max@max630.net>\n> ---\n> Thank you. Sorry, I should have noticed that obj ended up unused.\n\nThanks. Do you mind if I just squash this into the patch with the fix?\n\n-Peff\n"}]}