{"thread":{"id":"40752","subject":"[PATCH] check-ignore: correct documentation about output","startedAt":"2015-11-08T20:10:39Z","lastAt":"2015-11-24T22:13:17Z","messageCount":8,"participants":["Dennis Kaarsemaker","Stefan Beller","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273070","messageId":"20151108201036.GA28434@spirit","threadId":"40752","inReplyTo":null,"subject":"[PATCH] check-ignore: correct documentation about output","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2015-11-08T20:10:39Z","receivedAt":"2015-11-08T20:10:39Z","isPatch":true,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"By default git check-ignore shows only the filenames that will be\nignored, not the pattern that causes their exclusion.\n\nSigned-off-by: Dennis Kaarsemaker \n---\n Documentation/git-check-ignore.txt | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-check-ignore.txt b/Documentation/git-check-ignore.txt\nindex 59531ab..0a628ac 100644\n--- a/Documentation/git-check-ignore.txt\n+++ b/Documentation/git-check-ignore.txt\n@@ -16,10 +16,9 @@ DESCRIPTION\n -----------\n \n For each pathname given via the command-line or from a file via\n-`--stdin`, show the pattern from .gitignore (or other input files to\n-the exclude mechanism) that decides if the pathname is excluded or\n-included. Later patterns within a file take precedence over earlier\n-ones.\n+`--stdin`, check whether the file is excluded by .gitignore (or other\n+input files to the exclude mechanism) and output the path if it is\n+excluded.\n \n By default, tracked files are not shown at all since they are not\n subject to exclude rules; but see `--no-index'.\n-- \n2.6.3-495-gf0a7f49\n\n\n-- \nDennis Kaarsemaker \nhttp://twitter.com/seveas\n"},{"id":"273367","messageId":"1447683184.2733.0.camel@kaarsemaker.net","threadId":"40752","inReplyTo":"20151108201036.GA28434@spirit","subject":"Re: [PATCH] check-ignore: correct documentation about output","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2015-11-16T14:13:04Z","receivedAt":"2015-11-16T14:13:04Z","isPatch":true,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"Ping.\n\nOn zo, 2015-11-08 at 21:10 +0100, Dennis Kaarsemaker wrote:\n> By default git check-ignore shows only the filenames that will be\n> ignored, not the pattern that causes their exclusion.\n> \n> Signed-off-by: Dennis Kaarsemaker \n> ---\n> Documentation/git-check-ignore.txt | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/git-check-ignore.txt b/Documentation/git\n> -check-ignore.txt\n> index 59531ab..0a628ac 100644\n> --- a/Documentation/git-check-ignore.txt\n> +++ b/Documentation/git-check-ignore.txt\n> @@ -16,10 +16,9 @@ DESCRIPTION\n> -----------\n> \n> For each pathname given via the command-line or from a file via\n> -`--stdin`, show the pattern from .gitignore (or other input files to\n> -the exclude mechanism) that decides if the pathname is excluded or\n> -included. Later patterns within a file take precedence over earlier\n> -ones.\n> +`--stdin`, check whether the file is excluded by .gitignore (or\n> other\n> +input files to the exclude mechanism) and output the path if it is\n> +excluded.\n> \n> By default, tracked files are not shown at all since they are not\n> subject to exclude rules; but see `--no-index'.\n> -- \n> 2.6.3-495-gf0a7f49\n> \n> \n-- \nDennis Kaarsemaker\nhttp://www.kaarsemaker.net\n"},{"id":"273397","messageId":"CAGZ79ka2t7qZGSa5vOUsgXz7atuWmz_soCj39T85T21SmAthNA@mail.gmail.com","threadId":"40752","inReplyTo":"1447683184.2733.0.camel@kaarsemaker.net","subject":"Re: [PATCH] check-ignore: correct documentation about output","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-11-17T00:22:16Z","receivedAt":"2015-11-17T00:22:16Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"+cc Jeff\n\nOn Mon, Nov 16, 2015 at 6:13 AM, Dennis Kaarsemaker\n wrote:\n> Ping.\n\nJunio is on vacation, so Jeff is our interim maintainer,\nand it seems he isn't up to full power as Junio. :)\n"},{"id":"273449","messageId":"20151117223755.GD27862@sigill.intra.peff.net","threadId":"40752","inReplyTo":"CAGZ79ka2t7qZGSa5vOUsgXz7atuWmz_soCj39T85T21SmAthNA@mail.gmail.com","subject":"Re: [PATCH] check-ignore: correct documentation about output","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-11-17T22:37:55Z","receivedAt":"2015-11-17T22:37:55Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Nov 16, 2015 at 04:22:16PM -0800, Stefan Beller wrote:\n\n> +cc Jeff\n> \n> On Mon, Nov 16, 2015 at 6:13 AM, Dennis Kaarsemaker\n> wrote:\n> > Ping.\n> \n> Junio is on vacation, so Jeff is our interim maintainer,\n> and it seems he isn't up to full power as Junio. :)\n\nYes, I'm sorry, I've been doing a terrible job so far, as I haven't\npushed out anything. I'm making it my priority over the next day or so.\n\n-Peff\n"},{"id":"273533","messageId":"20151120113129.GE11198@sigill.intra.peff.net","threadId":"40752","inReplyTo":"20151108201036.GA28434@spirit","subject":"Re: [PATCH] check-ignore: correct documentation about output","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-11-20T11:31:29Z","receivedAt":"2015-11-20T11:31:29Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Nov 08, 2015 at 09:10:39PM +0100, Dennis Kaarsemaker wrote:\n\n> By default git check-ignore shows only the filenames that will be\n> ignored, not the pattern that causes their exclusion.\n\nYeah, I think the described behavior is really about the \"-v\" output.\n\n> --- a/Documentation/git-check-ignore.txt\n> +++ b/Documentation/git-check-ignore.txt\n> @@ -16,10 +16,9 @@ DESCRIPTION\n> -----------\n> \n> For each pathname given via the command-line or from a file via\n> -`--stdin`, show the pattern from .gitignore (or other input files to\n> -the exclude mechanism) that decides if the pathname is excluded or\n> -included. Later patterns within a file take precedence over earlier\n> -ones.\n> +`--stdin`, check whether the file is excluded by .gitignore (or other\n> +input files to the exclude mechanism) and output the path if it is\n> +excluded.\n\nThis just drops the mention of patterns entirely. Is the description of\n\"-v\" sufficient to cover this (especially I am thinking of the\nlast-pattern-wins behavior)?\n\n-Peff\n"},{"id":"273554","messageId":"1448051381.6899.2.camel@kaarsemaker.net","threadId":"40752","inReplyTo":"20151120113129.GE11198@sigill.intra.peff.net","subject":"Re: [PATCH] check-ignore: correct documentation about output","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2015-11-20T20:29:41Z","receivedAt":"2015-11-20T20:29:41Z","isPatch":true,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"[Peff, sorry for the duplicate mail. It seems I can't brain today...] \n\nOn vr, 2015-11-20 at 06:31 -0500, Jeff King wrote:\n> On Sun, Nov 08, 2015 at 09:10:39PM +0100, Dennis Kaarsemaker wrote:\n> \n> > By default git check-ignore shows only the filenames that will be\n> > ignored, not the pattern that causes their exclusion.\n> \n> Yeah, I think the described behavior is really about the \"-v\" output.\n\nYup.\n\n> > --- a/Documentation/git-check-ignore.txt\n> > +++ b/Documentation/git-check-ignore.txt\n> > @@ -16,10 +16,9 @@ DESCRIPTION\n> > -----------\n> > \n> > For each pathname given via the command-line or from a file via\n> > -`--stdin`, show the pattern from .gitignore (or other input files\n> > to\n> > -the exclude mechanism) that decides if the pathname is excluded or\n> > -included. Later patterns within a file take precedence over\n> > earlier\n> > -ones.\n> > +`--stdin`, check whether the file is excluded by .gitignore (or\n> > other\n> > +input files to the exclude mechanism) and output the path if it is\n> > +excluded.\n> \n> This just drops the mention of patterns entirely. Is the description \n> of \"-v\" sufficient to cover this (especially I am thinking of the\n> last-pattern-wins behavior)?\n\nThe -v should then also describe precendence rules between files. Or\nmaybe just link to gitignore(5).\n\n-- \nDennis Kaarsemaker\nwww.kaarsemaker.net\n"},{"id":"273555","messageId":"20151120203045.GA16353@spirit","threadId":"40752","inReplyTo":"1448051381.6899.2.camel@kaarsemaker.net","subject":"[PATCH v2] check-ignore: correct documentation about output","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2015-11-20T20:30:48Z","receivedAt":"2015-11-20T20:30:48Z","isPatch":true,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"By default git check-ignore shows only the filenames that will be\nignored, not the pattern that causes their exclusion. Instead of moving\nthe partial exclude pattern precendence information to the -v option\nwhere it belongs, link to gitignore(5) which describes this more\nthoroughly.\n\nSigned-off-by: Dennis Kaarsemaker \n---\n Documentation/git-check-ignore.txt | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-check-ignore.txt b/Documentation/git-check-ignore.txt\nindex 59531ab..e94367a 100644\n--- a/Documentation/git-check-ignore.txt\n+++ b/Documentation/git-check-ignore.txt\n@@ -16,10 +16,9 @@ DESCRIPTION\n -----------\n \n For each pathname given via the command-line or from a file via\n-`--stdin`, show the pattern from .gitignore (or other input files to\n-the exclude mechanism) that decides if the pathname is excluded or\n-included. Later patterns within a file take precedence over earlier\n-ones.\n+`--stdin`, check whether the file is excluded by .gitignore (or other\n+input files to the exclude mechanism) and output the path if it is\n+excluded.\n \n By default, tracked files are not shown at all since they are not\n subject to exclude rules; but see `--no-index'.\n@@ -32,7 +31,8 @@ OPTIONS\n \n -v, --verbose::\n \tAlso output details about the matching pattern (if any)\n-\tfor each given pathname.\n+\tfor each given pathname. For precedence rules within and\n+\tbetween exclude sources, see linkgit:gitignore[5].\n \n --stdin::\n \tRead pathnames from the standard input, one per line,\n-- \n2.6.3-495-gf0a7f49\n\n\n-- \nDennis Kaarsemaker \nhttp://twitter.com/seveas\n"},{"id":"273662","messageId":"20151124221317.GE29185@sigill.intra.peff.net","threadId":"40752","inReplyTo":"20151120203045.GA16353@spirit","subject":"Re: [PATCH v2] check-ignore: correct documentation about output","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-11-24T22:13:17Z","receivedAt":"2015-11-24T22:13:17Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Nov 20, 2015 at 09:30:48PM +0100, Dennis Kaarsemaker wrote:\n\n> By default git check-ignore shows only the filenames that will be\n> ignored, not the pattern that causes their exclusion. Instead of moving\n> the partial exclude pattern precendence information to the -v option\n> where it belongs, link to gitignore(5) which describes this more\n> thoroughly.\n> \n> Signed-off-by: Dennis Kaarsemaker \n> ---\n> Documentation/git-check-ignore.txt | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n\nThanks, your update looks good to me.\n\n-Peff\n"}]}