{"thread":{"id":"40751","subject":"[PATCH] Escape Git's exec path in contrib/rerere-train.sh script","startedAt":"2015-11-08T11:27:55Z","lastAt":"2015-11-20T11:44:38Z","messageCount":2,"participants":["Daniel Knittl-Frank","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273065","messageId":"1446982075-26161-1-git-send-email-knittl89+git@googlemail.com","threadId":"40751","inReplyTo":null,"subject":"[PATCH] Escape Git's exec path in contrib/rerere-train.sh script","fromName":"Daniel Knittl-Frank","fromEmail":"knittl89@googlemail.com","sentAt":"2015-11-08T11:27:55Z","receivedAt":"2015-11-08T11:27:55Z","isPatch":true,"sender":{"key":"knittl89@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/2149217?v=4"},"body":"Whitespace can cause the source command to fail. This is usually not a\nproblem on Unix systems, but on Windows Git is likely to be installed\nunder \"C:/Program Files/\", thus rendering the script broken.\n\nSigned-off-by: Daniel Knittl-Frank <knittl89+git@googlemail.com>\n---\n contrib/rerere-train.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh\nindex 36b6fee..52ad9e4 100755\n--- a/contrib/rerere-train.sh\n+++ b/contrib/rerere-train.sh\n@@ -7,7 +7,7 @@ USAGE=\"$me rev-list-args\"\n \n SUBDIRECTORY_OK=Yes\n OPTIONS_SPEC=\n-. $(git --exec-path)/git-sh-setup\n+. \"$(git --exec-path)/git-sh-setup\"\n require_work_tree\n cd_to_toplevel\n \n-- \n2.6.0.rc0.134.g48a2a2a\n"},{"id":"273536","messageId":"20151120114438.GH11198@sigill.intra.peff.net","threadId":"40751","inReplyTo":"1446982075-26161-1-git-send-email-knittl89+git@googlemail.com","subject":"Re: [PATCH] Escape Git's exec path in contrib/rerere-train.sh script","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-11-20T11:44:38Z","receivedAt":"2015-11-20T11:44:38Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Nov 08, 2015 at 12:27:55PM +0100, Daniel Knittl-Frank wrote:\n\n> Whitespace can cause the source command to fail. This is usually not a\n> problem on Unix systems, but on Windows Git is likely to be installed\n> under \"C:/Program Files/\", thus rendering the script broken.\n> \n> Signed-off-by: Daniel Knittl-Frank <knittl89+git@googlemail.com>\n> ---\n>  contrib/rerere-train.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh\n> index 36b6fee..52ad9e4 100755\n> --- a/contrib/rerere-train.sh\n> +++ b/contrib/rerere-train.sh\n> @@ -7,7 +7,7 @@ USAGE=\"$me rev-list-args\"\n>  \n>  SUBDIRECTORY_OK=Yes\n>  OPTIONS_SPEC=\n> -. $(git --exec-path)/git-sh-setup\n> +. \"$(git --exec-path)/git-sh-setup\"\n\nThanks, this makes sense.\n\nThe \"normal\" scripts just use \". git-sh-setup\", but they have the\nbenefit of being run under the \"git\" wrapper, so the exec-path is\nalready in their PATH. This one is meant to be used directly, so it\nneeds this.\n\n-Peff\n"}]}