{"thread":{"id":"40741","subject":"[PATCH] git-stash: Don't GPG sign when stashing changes","startedAt":"2015-11-06T17:32:12Z","lastAt":"2016-05-06T06:06:11Z","messageCount":12,"participants":["Cameron Currie","Junio C Hamano","daurnimator","Johannes Schindelin","Daurnimator"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"273024","messageId":"00000150dddb0eeb-b77240fb-1b63-4676-ac4b-1220b8d011ca-000000@eu-west-1.amazonses.com","threadId":"40741","inReplyTo":null,"subject":"[PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"Cameron Currie","fromEmail":"me@cameroncurrie.net","sentAt":"2015-11-06T17:32:12Z","receivedAt":"2015-11-06T17:32:12Z","isPatch":true,"sender":{"key":"me@cameroncurrie.net","avatar":null},"body":"This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n---\n git-stash.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex c7c65e2..fcf01b9 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -85,7 +85,7 @@ create_stash () {\n \t# state of the index\n \ti_tree=$(git write-tree) &&\n \ti_commit=$(printf 'index on %s\\n' \"$msg\" |\n-\t\tgit commit-tree $i_tree -p $b_commit) ||\n+\t\tgit commit-tree --no-gpg-sign $i_tree -p $b_commit) ||\n \t\tdie \"$(gettext \"Cannot save the current index state\")\"\n \n \tif test -n \"$untracked\"\n@@ -99,7 +99,7 @@ create_stash () {\n \t\t\t\trm -f \"$TMPindex\" &&\n \t\t\t\tgit update-index -z --add --remove --stdin &&\n \t\t\t\tu_tree=$(git write-tree) &&\n-\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree $u_tree  &&\n+\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree --no-gpg-sign $u_tree  &&\n \t\t\t\trm -f \"$TMPindex\"\n \t\t) ) || die \"Cannot save the untracked files\"\n \n@@ -153,7 +153,7 @@ create_stash () {\n \t\tstash_msg=$(printf 'On %s: %s' \"$branch\" \"$stash_msg\")\n \tfi\n \tw_commit=$(printf '%s\\n' \"$stash_msg\" |\n-\tgit commit-tree $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n+\tgit commit-tree --no-gpg-sign $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n \tdie \"$(gettext \"Cannot record working tree state\")\"\n }\n \n\n--\nhttps://github.com/git/git/pull/186\n"},{"id":"273029","messageId":"xmqqio5f2bz6.fsf@gitster.mtv.corp.google.com","threadId":"40741","inReplyTo":"00000150dddb0eeb-b77240fb-1b63-4676-ac4b-1220b8d011ca-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-11-06T18:56:29Z","receivedAt":"2015-11-06T18:56:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Cameron Currie <me@cameroncurrie.net> writes:\n\n> This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n> ---\n>  git-stash.sh | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n\nI have to wonder if the right fix is to change \"git commit-tree\" to\nignore that configuration variable?  After all, the plumbing\ncommands are about stability of the interface, not convenience, and\nit feels wrong for them to be affected by end-user configurations.\n\nPatching git-stash.sh does not help other scripts (either in-tree or\nthird-party) that use commit-tree; they will also be broken by\nover-eager users who set commit.gpgsign configuration.\n\n>\n> diff --git a/git-stash.sh b/git-stash.sh\n> index c7c65e2..fcf01b9 100755\n> --- a/git-stash.sh\n> +++ b/git-stash.sh\n> @@ -85,7 +85,7 @@ create_stash () {\n>  \t# state of the index\n>  \ti_tree=$(git write-tree) &&\n>  \ti_commit=$(printf 'index on %s\\n' \"$msg\" |\n> -\t\tgit commit-tree $i_tree -p $b_commit) ||\n> +\t\tgit commit-tree --no-gpg-sign $i_tree -p $b_commit) ||\n>  \t\tdie \"$(gettext \"Cannot save the current index state\")\"\n>  \n>  \tif test -n \"$untracked\"\n> @@ -99,7 +99,7 @@ create_stash () {\n>  \t\t\t\trm -f \"$TMPindex\" &&\n>  \t\t\t\tgit update-index -z --add --remove --stdin &&\n>  \t\t\t\tu_tree=$(git write-tree) &&\n> -\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree $u_tree  &&\n> +\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree --no-gpg-sign $u_tree  &&\n>  \t\t\t\trm -f \"$TMPindex\"\n>  \t\t) ) || die \"Cannot save the untracked files\"\n>  \n> @@ -153,7 +153,7 @@ create_stash () {\n>  \t\tstash_msg=$(printf 'On %s: %s' \"$branch\" \"$stash_msg\")\n>  \tfi\n>  \tw_commit=$(printf '%s\\n' \"$stash_msg\" |\n> -\tgit commit-tree $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n> +\tgit commit-tree --no-gpg-sign $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n>  \tdie \"$(gettext \"Cannot record working tree state\")\"\n>  }\n>  \n>\n> --\n> https://github.com/git/git/pull/186\n"},{"id":"282824","messageId":"loom.20160407T042319-468@post.gmane.org","threadId":"40741","inReplyTo":"00000150dddb0eeb-b77240fb-1b63-4676-ac4b-1220b8d011ca-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"daurnimator","fromEmail":"quae@daurnimator.com","sentAt":"2016-04-07T02:24:45Z","receivedAt":"2016-04-07T02:24:45Z","isPatch":true,"sender":{"key":"quae@daurnimator.com","avatar":null},"body":"Cameron Currie <me <at> cameroncurrie.net> writes:\n> This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n\n> https://github.com/git/git/pull/186\n\nI too would like this.\nBumping due to lack of attention.\n"},{"id":"282833","messageId":"alpine.DEB.2.20.1604071017510.2967@virtualbox","threadId":"40741","inReplyTo":"loom.20160407T042319-468@post.gmane.org","subject":"Re: [PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-04-07T08:19:26Z","receivedAt":"2016-04-07T08:19:26Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nyou dropped the Cc: list. So most likely Cameron won't get your mail nor\nany response to your mail.\n\nOn Thu, 7 Apr 2016, daurnimator wrote:\n\n> Cameron Currie <me <at> cameroncurrie.net> writes:\n> > This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n> \n> > https://github.com/git/git/pull/186\n> \n> I too would like this.\n> Bumping due to lack of attention.\n\nIt lacks a Sign-off, our convention is to continue in lower-case after the\ncolon in the commit's subject, and I think that it would be good to write\nso much as one paragraph in the commit message.\n\nCiao,\nJohannes\n"},{"id":"283164","messageId":"CAEnbY+eaReDYOH8azpSG7n7MOrvqORkC0ar80pd1m8wR4vv20A@mail.gmail.com","threadId":"40741","inReplyTo":"alpine.DEB.2.20.1604071017510.2967@virtualbox","subject":"Re: [PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"Daurnimator","fromEmail":"quae@daurnimator.com","sentAt":"2016-04-12T02:46:40Z","receivedAt":"2016-04-12T02:46:40Z","isPatch":true,"sender":{"key":"quae@daurnimator.com","avatar":null},"body":"On 7 April 2016 at 18:19, Johannes Schindelin\n<Johannes.Schindelin@gmx.de> wrote:\n> Hi,\n>\n> you dropped the Cc: list. So most likely Cameron won't get your mail nor\n> any response to your mail.\n\nI originally replied via the gmane web interface, apparently it\ndoesn't CC the original sender.\nCCd now.\n\n> On Thu, 7 Apr 2016, daurnimator wrote:\n>\n>> Cameron Currie <me <at> cameroncurrie.net> writes:\n>> > This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n>>\n>> > https://github.com/git/git/pull/186\n>>\n>> I too would like this.\n>> Bumping due to lack of attention.\n>\n> It lacks a Sign-off, our convention is to continue in lower-case after the\n> colon in the commit's subject, and I think that it would be good to write\n> so much as one paragraph in the commit message.\n>\n> Ciao,\n> Johannes\n\nCameron, able you able to complete this?\n"},{"id":"283450","messageId":"alpine.DEB.2.20.1604141748370.2967@virtualbox","threadId":"40741","inReplyTo":"CAOAY-+1TztY95z3Yi34HB3aYUG5aOHKK9G3OmpYM41ugDMtJUA@mail.gmail.com","subject":"Re: [PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-04-14T15:50:57Z","receivedAt":"2016-04-14T15:50:57Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Cameron,\n\nOn Wed, 13 Apr 2016, Cameron Currie wrote:\n\n> > > On Thu, 7 Apr 2016, daurnimator wrote:\n> > >\n> > >> Cameron Currie <me <at> cameroncurrie.net> writes:\n> > >> > This is helpful for folks with commit.gpgsign = true in their\n> > >> > .gitconfig.\n> > >>\n> > >> > https://github.com/git/git/pull/186\n> > >>\n> > >> I too would like this.\n> > >> Bumping due to lack of attention.\n> > >\n> > > It lacks a Sign-off, our convention is to continue in lower-case\n> > > after the colon in the commit's subject, and I think that it would\n> > > be good to write so much as one paragraph in the commit message.\n>\n> I don't think I can find the time right now. Feel free to rewrite the\n> commit message to match convention.\n\nI am afraid that it would be improper for anybody to add your Sign-off, as\nit is *your* statement that you are indeed contributing this as Open\nSource, and that you indeed are free to do so.\n\nIf you do not find the time to take care of these small changes, I fear\nthe Git maintainer will *have* to drop your patch to avoid hassle for\nhimself.\n\nCiao,\nJohannes\n"},{"id":"285141","messageId":"CAEnbY+fG60mZSKs_d8Lpyb2Czf=UfA9cKOBTtEjEXeUfGE9zLg@mail.gmail.com","threadId":"40741","inReplyTo":"alpine.DEB.2.20.1604141748370.2967@virtualbox","subject":"Re: [PATCH] git-stash: Don't GPG sign when stashing changes","fromName":"Daurnimator","fromEmail":"quae@daurnimator.com","sentAt":"2016-05-02T06:06:13Z","receivedAt":"2016-05-02T06:06:13Z","isPatch":true,"sender":{"key":"quae@daurnimator.com","avatar":null},"body":"On 15 April 2016 at 01:50, Johannes Schindelin\n<Johannes.Schindelin@gmx.de> wrote:\n> Hi Cameron,\n>\n> On Wed, 13 Apr 2016, Cameron Currie wrote:\n>\n>> > > On Thu, 7 Apr 2016, daurnimator wrote:\n>> > >\n>> > >> Cameron Currie <me <at> cameroncurrie.net> writes:\n>> > >> > This is helpful for folks with commit.gpgsign = true in their\n>> > >> > .gitconfig.\n>> > >>\n>> > >> > https://github.com/git/git/pull/186\n>> > >>\n>> > >> I too would like this.\n>> > >> Bumping due to lack of attention.\n>> > >\n>> > > It lacks a Sign-off, our convention is to continue in lower-case\n>> > > after the colon in the commit's subject, and I think that it would\n>> > > be good to write so much as one paragraph in the commit message.\n>>\n>> I don't think I can find the time right now. Feel free to rewrite the\n>> commit message to match convention.\n>\n> I am afraid that it would be improper for anybody to add your Sign-off, as\n> it is *your* statement that you are indeed contributing this as Open\n> Source, and that you indeed are free to do so.\n>\n> If you do not find the time to take care of these small changes, I fear\n> the Git maintainer will *have* to drop your patch to avoid hassle for\n> himself.\n>\n> Ciao,\n> Johannes\n\nCameron, could you please add a sign off to your commit?\nIt should be as simple as running `git commit --amend -s`\n"},{"id":"285212","messageId":"01020154733c27e9-deaa7a20-1de6-416a-a7d4-3229854117eb-000000@eu-west-1.amazonses.com","threadId":"40741","inReplyTo":"00000150dddb0eeb-b77240fb-1b63-4676-ac4b-1220b8d011ca-000000@eu-west-1.amazonses.com","subject":"[PATCH v2] git-stash: Don't GPG sign when stashing changes","fromName":"Cameron Currie","fromEmail":"me@cameroncurrie.net","sentAt":"2016-05-02T20:50:02Z","receivedAt":"2016-05-02T20:50:02Z","isPatch":true,"sender":{"key":"me@cameroncurrie.net","avatar":null},"body":"This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n\nSigned-off-by: Cameron Currie <me@cameroncurrie.net>\n---\n git-stash.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex c7c65e2..fcf01b9 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -85,7 +85,7 @@ create_stash () {\n \t# state of the index\n \ti_tree=$(git write-tree) &&\n \ti_commit=$(printf 'index on %s\\n' \"$msg\" |\n-\t\tgit commit-tree $i_tree -p $b_commit) ||\n+\t\tgit commit-tree --no-gpg-sign $i_tree -p $b_commit) ||\n \t\tdie \"$(gettext \"Cannot save the current index state\")\"\n \n \tif test -n \"$untracked\"\n@@ -99,7 +99,7 @@ create_stash () {\n \t\t\t\trm -f \"$TMPindex\" &&\n \t\t\t\tgit update-index -z --add --remove --stdin &&\n \t\t\t\tu_tree=$(git write-tree) &&\n-\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree $u_tree  &&\n+\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree --no-gpg-sign $u_tree  &&\n \t\t\t\trm -f \"$TMPindex\"\n \t\t) ) || die \"Cannot save the untracked files\"\n \n@@ -153,7 +153,7 @@ create_stash () {\n \t\tstash_msg=$(printf 'On %s: %s' \"$branch\" \"$stash_msg\")\n \tfi\n \tw_commit=$(printf '%s\\n' \"$stash_msg\" |\n-\tgit commit-tree $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n+\tgit commit-tree --no-gpg-sign $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n \tdie \"$(gettext \"Cannot record working tree state\")\"\n }\n \n\n--\nhttps://github.com/git/git/pull/186\n"},{"id":"285213","messageId":"xmqqoa8oqg19.fsf@gitster.mtv.corp.google.com","threadId":"40741","inReplyTo":"01020154733c27e9-deaa7a20-1de6-416a-a7d4-3229854117eb-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-02T21:57:38Z","receivedAt":"2016-05-02T21:57:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Cameron Currie <me@cameroncurrie.net> writes:\n\n> This is helpful for folks with commit.gpgsign = true in their .gitconfig.\n>\n> Signed-off-by: Cameron Currie <me@cameroncurrie.net>\n> ---\n\nI do not think this is particularly a good change.\n\nThere are a few other in-tree users of \"git commit-tree\",\ne.g. quiltimport and filter-branch, and their users would be hurt\nthe same way if they set commit.gpgsign in the configuration.\n\nI think it was a mistake that \"commit-tree\" was made to pay\nattention to the configuration variable in the first place.\nAllowing scripts that use commit-tree to explicitly pass -S to it is\nperfectly fine (and these calling scripts are welcome to honor\ncommit.gpgsign by reading the configration themselves if their users\nwant it that way).\n\nI'll send a pair of proposed alternative solutions shortly.\n\n>  git-stash.sh | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/git-stash.sh b/git-stash.sh\n> index c7c65e2..fcf01b9 100755\n> --- a/git-stash.sh\n> +++ b/git-stash.sh\n> @@ -85,7 +85,7 @@ create_stash () {\n>  \t# state of the index\n>  \ti_tree=$(git write-tree) &&\n>  \ti_commit=$(printf 'index on %s\\n' \"$msg\" |\n> -\t\tgit commit-tree $i_tree -p $b_commit) ||\n> +\t\tgit commit-tree --no-gpg-sign $i_tree -p $b_commit) ||\n>  \t\tdie \"$(gettext \"Cannot save the current index state\")\"\n>  \n>  \tif test -n \"$untracked\"\n> @@ -99,7 +99,7 @@ create_stash () {\n>  \t\t\t\trm -f \"$TMPindex\" &&\n>  \t\t\t\tgit update-index -z --add --remove --stdin &&\n>  \t\t\t\tu_tree=$(git write-tree) &&\n> -\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree $u_tree  &&\n> +\t\t\t\tprintf 'untracked files on %s\\n' \"$msg\" | git commit-tree --no-gpg-sign $u_tree  &&\n>  \t\t\t\trm -f \"$TMPindex\"\n>  \t\t) ) || die \"Cannot save the untracked files\"\n>  \n> @@ -153,7 +153,7 @@ create_stash () {\n>  \t\tstash_msg=$(printf 'On %s: %s' \"$branch\" \"$stash_msg\")\n>  \tfi\n>  \tw_commit=$(printf '%s\\n' \"$stash_msg\" |\n> -\tgit commit-tree $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n> +\tgit commit-tree --no-gpg-sign $w_tree -p $b_commit -p $i_commit $untracked_commit_option) ||\n>  \tdie \"$(gettext \"Cannot record working tree state\")\"\n>  }\n>  \n>\n> --\n> https://github.com/git/git/pull/186\n"},{"id":"285230","messageId":"CAEnbY+cu9E8DYGcg8FoK37NGZXbhSKvzVwMpLUEspXRYpPUdaA@mail.gmail.com","threadId":"40741","inReplyTo":"xmqqoa8oqg19.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes","fromName":"Daurnimator","fromEmail":"quae@daurnimator.com","sentAt":"2016-05-02T23:56:44Z","receivedAt":"2016-05-02T23:56:44Z","isPatch":true,"sender":{"key":"quae@daurnimator.com","avatar":null},"body":"On 3 May 2016 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:\n> I do not think this is particularly a good change.\n>\n> There are a few other in-tree users of \"git commit-tree\",\n> e.g. quiltimport and filter-branch, and their users would be hurt\n> the same way if they set commit.gpgsign in the configuration.\n\nI agree quiltimport should not, but I think filter-branch possibly\nshould... at least for your *own* commits.\nI often think of filter-branch as an \"advanced\" `git commit --amend`\n"},{"id":"285238","messageId":"CAPc5daXVBJ=2KJfqcdwyH1Eq54vw-QeOEBF1aGj2dn+Yihcy9A@mail.gmail.com","threadId":"40741","inReplyTo":"CAEnbY+cu9E8DYGcg8FoK37NGZXbhSKvzVwMpLUEspXRYpPUdaA@mail.gmail.com","subject":"Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-03T01:21:19Z","receivedAt":"2016-05-03T01:21:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"On Mon, May 2, 2016 at 4:56 PM, Daurnimator <quae@daurnimator.com> wrote:\n> On 3 May 2016 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:\n>\n> I agree quiltimport should not, but I think filter-branch possibly\n> should... at least for your *own* commits.\n> I often think of filter-branch as an \"advanced\" `git commit --amend`\n\nBut it does not do the gpgsign thing only for your own commits right now, and\neven if it did, you would not necessarily want it to always use the configured\nsetting. That means that the command, if it wants to work well with the signed\ncommits, must learn to honor command line option to enable or disable passing\n--gpgsign option to underlying commit-tree *anyway*.\n\nSo I think it is a right thing to fix commit-tree to ignore\ncommit.gpgsign at least\nby default.\n"},{"id":"285664","messageId":"CAEnbY+cAzLKw9GJTWy5ZP4rGsve161qSX5DgqWimcC5kYRqkyA@mail.gmail.com","threadId":"40741","inReplyTo":"CAPc5daXVBJ=2KJfqcdwyH1Eq54vw-QeOEBF1aGj2dn+Yihcy9A@mail.gmail.com","subject":"Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes","fromName":"Daurnimator","fromEmail":"quae@daurnimator.com","sentAt":"2016-05-06T06:06:11Z","receivedAt":"2016-05-06T06:06:11Z","isPatch":true,"sender":{"key":"quae@daurnimator.com","avatar":null},"body":"On 3 May 2016 at 11:21, Junio C Hamano <gitster@pobox.com> wrote:\n> On Mon, May 2, 2016 at 4:56 PM, Daurnimator <quae@daurnimator.com> wrote:\n>> On 3 May 2016 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:\n>>\n>> I agree quiltimport should not, but I think filter-branch possibly\n>> should... at least for your *own* commits.\n>> I often think of filter-branch as an \"advanced\" `git commit --amend`\n>\n> But it does not do the gpgsign thing only for your own commits right now, and\n> even if it did, you would not necessarily want it to always use the configured\n> setting. That means that the command, if it wants to work well with the signed\n> commits, must learn to honor command line option to enable or disable passing\n> --gpgsign option to underlying commit-tree *anyway*.\n>\n> So I think it is a right thing to fix commit-tree to ignore\n> commit.gpgsign at least\n> by default.\n\nOkay, that makes sense.\nWill you work on a patch?\n"}]}