{"thread":{"id":"40693","subject":"[PATCH] mailinfo: fix passing wrong address to git_mailinfo_config","startedAt":"2015-11-01T14:30:30Z","lastAt":"2015-11-01T18:29:43Z","messageCount":2,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"272672","messageId":"1446388230-27966-1-git-send-email-pclouds@gmail.com","threadId":"40693","inReplyTo":null,"subject":"[PATCH] mailinfo: fix passing wrong address to git_mailinfo_config","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2015-11-01T14:30:30Z","receivedAt":"2015-11-01T14:30:30Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"git_mailinfo_config() expects \"struct mailinfo *\". But in\nsetup_mailinfo(), \"mi\" is already \"struct mailinfo *\". &mi would make\nit \"struct mailinfo **\" and git_mailinfo_config() would damage some\nother memory when it assigns some value to mi->use_scissors.\n\nThis is caught by t4150.20. git_mailinfo_config() breaks\nmi->name.alloc and makes strbuf_release() in clear_mailinfo() attempt\nto free strbuf_slopbuf.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n mailinfo.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/mailinfo.c b/mailinfo.c\nindex e157ca6..f289941 100644\n--- a/mailinfo.c\n+++ b/mailinfo.c\n@@ -1009,7 +1009,7 @@ void setup_mailinfo(struct mailinfo *mi)\n \tmi->header_stage = 1;\n \tmi->use_inbody_headers = 1;\n \tmi->content_top = mi->content;\n-\tgit_config(git_mailinfo_config, &mi);\n+\tgit_config(git_mailinfo_config, mi);\n }\n \n void clear_mailinfo(struct mailinfo *mi)\n-- \n2.2.0.513.g477eb31\n"},{"id":"272686","messageId":"xmqqpozth8tk.fsf@gitster.mtv.corp.google.com","threadId":"40693","inReplyTo":"1446388230-27966-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] mailinfo: fix passing wrong address to git_mailinfo_config","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-11-01T18:29:43Z","receivedAt":"2015-11-01T18:29:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}