{"thread":{"id":"40618","subject":"[PATCH] Documentation: fix header markup","startedAt":"2015-10-22T12:59:00Z","lastAt":"2015-10-22T16:57:16Z","messageCount":3,"participants":["Xue Fuqiao","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"272097","messageId":"1445518740-18221-1-git-send-email-xfq.free@gmail.com","threadId":"40618","inReplyTo":null,"subject":"[PATCH] Documentation: fix header markup","fromName":"Xue Fuqiao","fromEmail":"xfq.free@gmail.com","sentAt":"2015-10-22T12:59:00Z","receivedAt":"2015-10-22T12:59:00Z","isPatch":true,"sender":{"key":"xfq.free@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2863444?v=4"},"body":"Asciidoctor is stricter than AsciiDoc when deciding if underlining\nis a section title or the start of preformatted text.  Make the\nlength of the underlining match the text to ensure that it renders\ncorrectly in all implementations.\n\nSigned-off-by: Xue Fuqiao <xfq.free@gmail.com>\n---\nCurrently, \"Fixing a mistake by rewriting history\" is surrounded by a\npair of <p> tags instead of a pair of <h3> tags in\nhttps://git-scm.com/docs/user-manual.html.  This patch will (hopefully)\nfix that.\n\n Documentation/user-manual.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\nindex 1b7987e..764a270 100644\n--- a/Documentation/user-manual.txt\n+++ b/Documentation/user-manual.txt\n@@ -1491,7 +1491,7 @@ resolving a merge>>.\n \n [[fixing-a-mistake-by-rewriting-history]]\n Fixing a mistake by rewriting history\n-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \n If the problematic commit is the most recent commit, and you have not\n yet made that commit public, then you may just\n-- \n2.6.2\n"},{"id":"272108","messageId":"xmqq37x2uah6.fsf@gitster.mtv.corp.google.com","threadId":"40618","inReplyTo":"1445518740-18221-1-git-send-email-xfq.free@gmail.com","subject":"Re: [PATCH] Documentation: fix header markup","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-10-22T16:36:05Z","receivedAt":"2015-10-22T16:36:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Xue Fuqiao <xfq.free@gmail.com> writes:\n\n> Asciidoctor is stricter than AsciiDoc when deciding if underlining\n> is a section title or the start of preformatted text.  Make the\n> length of the underlining match the text to ensure that it renders\n> correctly in all implementations.\n>\n> Signed-off-by: Xue Fuqiao <xfq.free@gmail.com>\n> ---\n\nLooks obviously correct.  Will queue.\n\nThanks.\n\n> Currently, \"Fixing a mistake by rewriting history\" is surrounded by a\n> pair of <p> tags instead of a pair of <h3> tags in\n> https://git-scm.com/docs/user-manual.html.  This patch will (hopefully)\n> fix that.\n>\n>  Documentation/user-manual.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\n> index 1b7987e..764a270 100644\n> --- a/Documentation/user-manual.txt\n> +++ b/Documentation/user-manual.txt\n> @@ -1491,7 +1491,7 @@ resolving a merge>>.\n>  \n>  [[fixing-a-mistake-by-rewriting-history]]\n>  Fixing a mistake by rewriting history\n> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n>  \n>  If the problematic commit is the most recent commit, and you have not\n>  yet made that commit public, then you may just\n"},{"id":"272110","messageId":"xmqqvb9ysuxf.fsf_-_@gitster.mtv.corp.google.com","threadId":"40618","inReplyTo":"xmqq37x2uah6.fsf@gitster.mtv.corp.google.com","subject":"[PATCH] Match underline with the text","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-10-22T16:57:16Z","receivedAt":"2015-10-22T16:57:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Even though AsciiDoc is more lenient when deciding if an underline\nis for the contents on the previous line to find section headers, we\nshould match the length of them for other formatters to help them.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * A few more instances I found.\n\n Documentation/git-bisect.txt         | 2 +-\n Documentation/git-remote.txt         | 2 +-\n Documentation/git-upload-archive.txt | 2 +-\n Documentation/giteveryday.txt        | 2 +-\n Documentation/gitrevisions.txt       | 2 +-\n Documentation/urls-remotes.txt       | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt\nindex 2044fe6..51cacd7 100644\n--- a/Documentation/git-bisect.txt\n+++ b/Documentation/git-bisect.txt\n@@ -256,7 +256,7 @@ Then compile and test the chosen revision, and afterwards mark\n the revision as good or bad in the usual manner.\n \n Bisect skip\n-~~~~~~~~~~~~\n+~~~~~~~~~~~\n \n Instead of choosing a nearby commit by yourself, you can ask Git to do\n it for you by issuing the command:\ndiff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt\nindex 3c9bf45..1d7ecea 100644\n--- a/Documentation/git-remote.txt\n+++ b/Documentation/git-remote.txt\n@@ -1,5 +1,5 @@\n git-remote(1)\n-============\n+=============\n \n NAME\n ----\ndiff --git a/Documentation/git-upload-archive.txt b/Documentation/git-upload-archive.txt\nindex cbef61b..fba0f1c 100644\n--- a/Documentation/git-upload-archive.txt\n+++ b/Documentation/git-upload-archive.txt\n@@ -1,5 +1,5 @@\n git-upload-archive(1)\n-====================\n+=====================\n \n NAME\n ----\ndiff --git a/Documentation/giteveryday.txt b/Documentation/giteveryday.txt\nindex 7be6e64..35473ad 100644\n--- a/Documentation/giteveryday.txt\n+++ b/Documentation/giteveryday.txt\n@@ -1,5 +1,5 @@\n giteveryday(7)\n-===============\n+==============\n \n NAME\n ----\ndiff --git a/Documentation/gitrevisions.txt b/Documentation/gitrevisions.txt\nindex c0ed6d1..e903eb7 100644\n--- a/Documentation/gitrevisions.txt\n+++ b/Documentation/gitrevisions.txt\n@@ -1,5 +1,5 @@\n gitrevisions(7)\n-================\n+===============\n \n NAME\n ----\ndiff --git a/Documentation/urls-remotes.txt b/Documentation/urls-remotes.txt\nindex 282758e..bd184cd 100644\n--- a/Documentation/urls-remotes.txt\n+++ b/Documentation/urls-remotes.txt\n@@ -36,7 +36,7 @@ The `<pushurl>` is used for pushes only. It is optional and defaults\n to `<url>`.\n \n Named file in `$GIT_DIR/remotes`\n-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \n You can choose to provide the name of a\n file in `$GIT_DIR/remotes`.  The URL\n"}]}