{"thread":{"id":"40617","subject":"[PATCH 4/5] read-cache: remove unused #include \"sigchain.h\"","startedAt":"2015-10-22T12:43:25Z","lastAt":"2015-10-26T20:59:14Z","messageCount":11,"participants":["Tobias Klauser","Junio C Hamano","Michael Haggerty"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"272091","messageId":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","threadId":"40617","inReplyTo":null,"subject":"[PATCH 0/5] Remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-22T12:43:25Z","receivedAt":"2015-10-22T12:43:25Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"This series removes the #include of sigchain.h from several modules\nafter they were changed to use the tempfile module and they thus no\nlonger use any declarations from sigchain.h\n\nTobias Klauser (5):\n gc: remove unused #include \"sigchain.h\"\n credential-cache--daemon: remove unused #include \"sigchain.h\"\n diff: remove unused #include \"sigchain.h\"\n read-cache: remove unused #include \"sigchain.h\"\n shallow: remove unused #include \"sigchain.h\"\n\n builtin/gc.c | 1 -\n credential-cache--daemon.c | 1 -\n diff.c | 1 -\n read-cache.c | 1 -\n shallow.c | 1 -\n 5 files changed, 5 deletions(-)\n\n-- \n2.6.1.148.g7927db1\n"},{"id":"272095","messageId":"1445517810-13998-2-git-send-email-tklauser@distanz.ch","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"[PATCH 1/5] gc: remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-22T12:43:26Z","receivedAt":"2015-10-22T12:43:26Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"After switching to use the tempfile module in commit ebebeaea (gc: use\ntempfile module to handle gc.pid file), no declarations from sigchain.h\nare used in builtin/gc.c anymore. Thus, remove the #include.\n\nSigned-off-by: Tobias Klauser \n---\n builtin/gc.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/gc.c b/builtin/gc.c\nindex 9ff0204..dc8a242 100644\n--- a/builtin/gc.c\n+++ b/builtin/gc.c\n@@ -15,7 +15,6 @@\n #include \"lockfile.h\"\n #include \"parse-options.h\"\n #include \"run-command.h\"\n-#include \"sigchain.h\"\n #include \"argv-array.h\"\n #include \"commit.h\"\n \n-- \n2.6.1.148.g7927db1\n"},{"id":"272092","messageId":"1445517810-13998-3-git-send-email-tklauser@distanz.ch","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"[PATCH 2/5] credential-cache--daemon: remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-22T12:43:27Z","receivedAt":"2015-10-22T12:43:27Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"After switching to use the tempfile module in commit 9e903316\n(credential-cache--daemon: use tempfile module), no declarations from\nsigchain.h are used in credential-cache--daemon.c anymore. Thus, remove\nthe #include.\n\nSigned-off-by: Tobias Klauser \n---\n credential-cache--daemon.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/credential-cache--daemon.c b/credential-cache--daemon.c\nindex eef6fce..82715aa 100644\n--- a/credential-cache--daemon.c\n+++ b/credential-cache--daemon.c\n@@ -2,7 +2,6 @@\n #include \"tempfile.h\"\n #include \"credential.h\"\n #include \"unix-socket.h\"\n-#include \"sigchain.h\"\n #include \"parse-options.h\"\n \n static struct tempfile socket_file;\n-- \n2.6.1.148.g7927db1\n"},{"id":"272094","messageId":"1445517810-13998-4-git-send-email-tklauser@distanz.ch","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"[PATCH 3/5] diff: remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-22T12:43:28Z","receivedAt":"2015-10-22T12:43:28Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"After switching to use the tempfile module in commit 284098f1\n(diff: use tempfile module), no declarations from sigchain.h are used in\ndiff.c anymore. Thus, remove the #include.\n\nSigned-off-by: Tobias Klauser \n---\n diff.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/diff.c b/diff.c\nindex 46260ed..df47592 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -13,7 +13,6 @@\n #include \"run-command.h\"\n #include \"utf8.h\"\n #include \"userdiff.h\"\n-#include \"sigchain.h\"\n #include \"submodule-config.h\"\n #include \"submodule.h\"\n #include \"ll-merge.h\"\n-- \n2.6.1.148.g7927db1\n"},{"id":"272090","messageId":"1445517810-13998-5-git-send-email-tklauser@distanz.ch","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"[PATCH 4/5] read-cache: remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-22T12:43:29Z","receivedAt":"2015-10-22T12:43:29Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"After switching to use the tempfile module in commit f6ecc62d\n(write_shared_index(): use tempfile module), no declarations from\nsigchain.h are used in read-cache.c anymore. Thus, remove the #include.\n\nSigned-off-by: Tobias Klauser \n---\n read-cache.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/read-cache.c b/read-cache.c\nindex 87204a5..3ecb99d 100644\n--- a/read-cache.c\n+++ b/read-cache.c\n@@ -17,7 +17,6 @@\n #include \"strbuf.h\"\n #include \"varint.h\"\n #include \"split-index.h\"\n-#include \"sigchain.h\"\n #include \"utf8.h\"\n \n static struct cache_entry *refresh_cache_entry(struct cache_entry *ce,\n-- \n2.6.1.148.g7927db1\n"},{"id":"272093","messageId":"1445517810-13998-6-git-send-email-tklauser@distanz.ch","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"[PATCH 5/5] shallow: remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-22T12:43:30Z","receivedAt":"2015-10-22T12:43:30Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"After switching to use the tempfile module in commit 6e122b44\n(setup_temporary_shallow(): use tempfile module), no declarations from\nsigchain.h are used in read-cache.c anymore. Thus, remove the #include.\n\nSigned-off-by: Tobias Klauser \n---\n shallow.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/shallow.c b/shallow.c\nindex d49a3d6..4f9d667 100644\n--- a/shallow.c\n+++ b/shallow.c\n@@ -10,7 +10,6 @@\n #include \"diff.h\"\n #include \"revision.h\"\n #include \"commit-slab.h\"\n-#include \"sigchain.h\"\n \n static int is_shallow = -1;\n static struct stat_validity shallow_stat;\n-- \n2.6.1.148.g7927db1\n"},{"id":"272111","messageId":"xmqqr3kmstek.fsf@gitster.mtv.corp.google.com","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"Re: [PATCH 0/5] Remove unused #include \"sigchain.h\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-10-22T17:30:11Z","receivedAt":"2015-10-22T17:30:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Makes sense; will queue directly on top of the original tempfile\nseries and merge.\n"},{"id":"272119","messageId":"xmqqk2qer78a.fsf@gitster.mtv.corp.google.com","threadId":"40617","inReplyTo":"1445517810-13998-2-git-send-email-tklauser@distanz.ch","subject":"Re: [PATCH 1/5] gc: remove unused #include \"sigchain.h\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-10-22T20:14:29Z","receivedAt":"2015-10-22T20:14:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tobias Klauser writes:\n\n> After switching to use the tempfile module in commit ebebeaea (gc: use\n> tempfile module to handle gc.pid file), no declarations from sigchain.h\n> are used in builtin/gc.c anymore. Thus, remove the #include.\n>\n> Signed-off-by: Tobias Klauser \n> ---\n\nI'll drop this one as we seem to have gained another user of the API\nin this file in the nd/gc-auto-background-fix topic.\n\n> builtin/gc.c | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/builtin/gc.c b/builtin/gc.c\n> index 9ff0204..dc8a242 100644\n> --- a/builtin/gc.c\n> +++ b/builtin/gc.c\n> @@ -15,7 +15,6 @@\n> #include \"lockfile.h\"\n> #include \"parse-options.h\"\n> #include \"run-command.h\"\n> -#include \"sigchain.h\"\n> #include \"argv-array.h\"\n> #include \"commit.h\"\n"},{"id":"272133","messageId":"20151023072527.GR2468@distanz.ch","threadId":"40617","inReplyTo":"xmqqk2qer78a.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 1/5] gc: remove unused #include \"sigchain.h\"","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2015-10-23T07:25:28Z","receivedAt":"2015-10-23T07:25:28Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"On 2015-10-22 at 22:14:29 +0200, Junio C Hamano wrote:\n> Tobias Klauser writes:\n> \n> > After switching to use the tempfile module in commit ebebeaea (gc: use\n> > tempfile module to handle gc.pid file), no declarations from sigchain.h\n> > are used in builtin/gc.c anymore. Thus, remove the #include.\n> >\n> > Signed-off-by: Tobias Klauser \n> > ---\n> \n> I'll drop this one as we seem to have gained another user of the API\n> in this file in the nd/gc-auto-background-fix topic.\n\nOpps, sorry I didn't check against 'pu' carefully enough. Thanks for\ncatching it.\n"},{"id":"272145","messageId":"xmqqoafpplk9.fsf@gitster.mtv.corp.google.com","threadId":"40617","inReplyTo":"20151023072527.GR2468@distanz.ch","subject":"Re: [PATCH 1/5] gc: remove unused #include \"sigchain.h\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-10-23T17:00:06Z","receivedAt":"2015-10-23T17:00:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tobias Klauser writes:\n\n> On 2015-10-22 at 22:14:29 +0200, Junio C Hamano wrote:\n>> Tobias Klauser writes:\n>> \n>> > After switching to use the tempfile module in commit ebebeaea (gc: use\n>> > tempfile module to handle gc.pid file), no declarations from sigchain.h\n>> > are used in builtin/gc.c anymore. Thus, remove the #include.\n>> >\n>> > Signed-off-by: Tobias Klauser \n>> > ---\n>> \n>> I'll drop this one as we seem to have gained another user of the API\n>> in this file in the nd/gc-auto-background-fix topic.\n>\n> Opps, sorry I didn't check against 'pu' carefully enough. Thanks for\n> catching it.\n\nHeh, that topic has been in master since Oct 15, I think.\n"},{"id":"272269","messageId":"562E9422.5080708@alum.mit.edu","threadId":"40617","inReplyTo":"1445517810-13998-1-git-send-email-tklauser@distanz.ch","subject":"Re: [PATCH 0/5] Remove unused #include \"sigchain.h\"","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2015-10-26T20:59:14Z","receivedAt":"2015-10-26T20:59:14Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"On 10/22/2015 02:43 PM, Tobias Klauser wrote:\n> This series removes the #include of sigchain.h from several modules\n> after they were changed to use the tempfile module and they thus no\n> longer use any declarations from sigchain.h\n> \n> Tobias Klauser (5):\n> gc: remove unused #include \"sigchain.h\"\n> credential-cache--daemon: remove unused #include \"sigchain.h\"\n> diff: remove unused #include \"sigchain.h\"\n> read-cache: remove unused #include \"sigchain.h\"\n> shallow: remove unused #include \"sigchain.h\"\n\nThanks for cleaning these up, Tobias. I totally forgot to look for\nincludes that were no longer needed.\n\nMichael\n\n-- \nMichael Haggerty\nmhagger@alum.mit.edu\n"}]}