{"thread":{"id":"4059","subject":"[PATCH] Fix linking with OpenSSL","startedAt":"2006-05-04T22:25:50Z","lastAt":"2006-05-05T08:02:46Z","messageCount":5,"participants":["Alexey Dobriyan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"19526","messageId":"20060504222550.GA7236@mipter.zuzino.mipt.ru","threadId":"4059","inReplyTo":null,"subject":"[PATCH] Fix linking with OpenSSL","fromName":"Alexey Dobriyan","fromEmail":"adobriyan@gmail.com","sentAt":"2006-05-04T22:25:50Z","receivedAt":"2006-05-04T22:25:50Z","isPatch":true,"sender":{"key":"adobriyan@gmail.com","avatar":null},"body":"For those who put it into interesting (read: default) place.\n\nSigned-off-by: Alexey Dobriyan <adobriyan@gmail.com>\n\n--- a/Makefile\n+++ b/Makefile\n@@ -559,7 +559,7 @@ git-http-push$X: revision.o http.o http-\n \n git-rev-list$X: rev-list.o $(LIB_FILE)\n \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n-\t\t$(LIBS) $(OPENSSL_LIBSSL)\n+\t\t$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)\n \n init-db.o: init-db.c\n \t$(CC) -c $(ALL_CFLAGS) \\\n"},{"id":"19527","messageId":"7vwtd12z6h.fsf@assigned-by-dhcp.cox.net","threadId":"4059","inReplyTo":"20060504222550.GA7236@mipter.zuzino.mipt.ru","subject":"Re: [PATCH] Fix linking with OpenSSL","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-04T22:38:30Z","receivedAt":"2006-05-04T22:38:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexey Dobriyan <adobriyan@gmail.com> writes:\n\n> For those who put it into interesting (read: default) place.\n>\n> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>\n>\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -559,7 +559,7 @@ git-http-push$X: revision.o http.o http-\n>  \n>  git-rev-list$X: rev-list.o $(LIB_FILE)\n>  \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n> -\t\t$(LIBS) $(OPENSSL_LIBSSL)\n> +\t\t$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)\n>  \n>  init-db.o: init-db.c\n>  \t$(CC) -c $(ALL_CFLAGS) \\\n\nWe used to depend on bignum from openssl for rev-list\n(merge-order), and if I remember correctly that was the only\nreason built recipe for rev-list is different from other\nprograms.  I wonder if we can just get rid of this thing, and\nhave it built with git-%$X rule like everybody else.\n\nCan somebody try that out and report what happens?\n"},{"id":"19528","messageId":"7vslnp2y5x.fsf@assigned-by-dhcp.cox.net","threadId":"4059","inReplyTo":"7vwtd12z6h.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix linking with OpenSSL","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-04T23:00:26Z","receivedAt":"2006-05-04T23:00:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <junkio@cox.net> writes:\n\n> Alexey Dobriyan <adobriyan@gmail.com> writes:\n>\n>> For those who put it into interesting (read: default) place.\n>>\n>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>\n>>\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -559,7 +559,7 @@ git-http-push$X: revision.o http.o http-\n>>  \n>>  git-rev-list$X: rev-list.o $(LIB_FILE)\n>>  \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n>> -\t\t$(LIBS) $(OPENSSL_LIBSSL)\n>> +\t\t$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)\n>>  \n>>  init-db.o: init-db.c\n>>  \t$(CC) -c $(ALL_CFLAGS) \\\n>\n> We used to depend on bignum from openssl for rev-list\n> (merge-order), and if I remember correctly that was the only\n> reason built recipe for rev-list is different from other\n> programs.  I wonder if we can just get rid of this thing, and\n> have it built with git-%$X rule like everybody else.\n>\n> Can somebody try that out and report what happens?\n\nWell, I did.  Alexey, does this work for you?\n\n-- >8 --\n\ndiff --git a/Makefile b/Makefile\nindex a3f7e92..814010d 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -564,10 +564,6 @@ git-http-push$X: revision.o http.o http-\n \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)\n \n-git-rev-list$X: rev-list.o $(LIB_FILE)\n-\t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n-\t\t$(LIBS) $(OPENSSL_LIBSSL)\n-\n init-db.o: init-db.c\n \t$(CC) -c $(ALL_CFLAGS) \\\n \t\t-DDEFAULT_GIT_TEMPLATE_DIR='\"$(template_dir_SQ)\"' $*.c\n"},{"id":"19550","messageId":"20060505075754.GA7237@mipter.zuzino.mipt.ru","threadId":"4059","inReplyTo":"7vslnp2y5x.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix linking with OpenSSL","fromName":"Alexey Dobriyan","fromEmail":"adobriyan@gmail.com","sentAt":"2006-05-05T07:57:54Z","receivedAt":"2006-05-05T07:57:54Z","isPatch":true,"sender":{"key":"adobriyan@gmail.com","avatar":null},"body":"On Thu, May 04, 2006 at 04:00:26PM -0700, Junio C Hamano wrote:\n> Junio C Hamano <junkio@cox.net> writes:\n> > Alexey Dobriyan <adobriyan@gmail.com> writes:\n> >> For those who put it into interesting (read: default) place.\n> >>\n> >> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>\n> >>\n> >> --- a/Makefile\n> >> +++ b/Makefile\n> >> @@ -559,7 +559,7 @@ git-http-push$X: revision.o http.o http-\n> >>  \n> >>  git-rev-list$X: rev-list.o $(LIB_FILE)\n> >>  \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n> >> -\t\t$(LIBS) $(OPENSSL_LIBSSL)\n> >> +\t\t$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)\n> >>  \n> >>  init-db.o: init-db.c\n> >>  \t$(CC) -c $(ALL_CFLAGS) \\\n> >\n> > We used to depend on bignum from openssl for rev-list\n> > (merge-order), and if I remember correctly that was the only\n> > reason built recipe for rev-list is different from other\n> > programs.  I wonder if we can just get rid of this thing, and\n> > have it built with git-%$X rule like everybody else.\n> >\n> > Can somebody try that out and report what happens?\n> \n> Well, I did.  Alexey, does this work for you?\n\nIt does. It also crashes busybox patch applet. Oh, well...\n\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -564,10 +564,6 @@ git-http-push$X: revision.o http.o http-\n>  \t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n>  \t\t$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)\n>  \n> -git-rev-list$X: rev-list.o $(LIB_FILE)\n> -\t$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n> -\t\t$(LIBS) $(OPENSSL_LIBSSL)\n> -\n>  init-db.o: init-db.c\n>  \t$(CC) -c $(ALL_CFLAGS) \\\n>  \t\t-DDEFAULT_GIT_TEMPLATE_DIR='\"$(template_dir_SQ)\"' $*.c\n"},{"id":"19551","messageId":"7vpsis2921.fsf@assigned-by-dhcp.cox.net","threadId":"4059","inReplyTo":"20060505075754.GA7237@mipter.zuzino.mipt.ru","subject":"Re: [PATCH] Fix linking with OpenSSL","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-05T08:02:46Z","receivedAt":"2006-05-05T08:02:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexey Dobriyan <adobriyan@gmail.com> writes:\n\n> It does. It also crashes busybox patch applet. Oh, well...\n\nCould you elaborate on \"busybox patch\" problem?\n"}]}