{"thread":{"id":"40538","subject":"[PATCH v1 0/2] git-p4: Fix tests on OS X","startedAt":"2015-10-12T17:03:02Z","lastAt":"2015-10-22T22:47:03Z","messageCount":4,"participants":["larsxschneider@gmail.com","Luke Diamand"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"271457","messageId":"1444669384-85419-1-git-send-email-larsxschneider@gmail.com","threadId":"40538","inReplyTo":null,"subject":"[PATCH v1 0/2] git-p4: Fix tests on OS X","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2015-10-12T17:03:02Z","receivedAt":"2015-10-12T17:03:02Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider <larsxschneider@gmail.com>\n\nI extracted this patch series from \"[PATCH v3 0/3] Add Travis CI support\" as\nsuggested by Junio.\n\nThanks,\nLars\n\nLars Schneider (2):\n  git-p4: Improve test case portability for t9815 git-p4-submit-fail\n  git-p4: Skip t9819 test case on case insensitive file systems\n\n t/t9815-git-p4-submit-fail.sh  | 7 ++-----\n t/t9819-git-p4-case-folding.sh | 6 ++++++\n 2 files changed, 8 insertions(+), 5 deletions(-)\n\n--\n2.5.1\n"},{"id":"271458","messageId":"1444669384-85419-2-git-send-email-larsxschneider@gmail.com","threadId":"40538","inReplyTo":"1444669384-85419-1-git-send-email-larsxschneider@gmail.com","subject":"[PATCH v1 1/2] git-p4: Improve test case portability for t9815 git-p4-submit-fail","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2015-10-12T17:03:03Z","receivedAt":"2015-10-12T17:03:03Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider <larsxschneider@gmail.com>\n\nReplace the stats command with the ls command to check file mode bits.\nThe stats command is not available on Windows and has different\ncommand line options on OS X.\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\n---\n t/t9815-git-p4-submit-fail.sh | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t9815-git-p4-submit-fail.sh b/t/t9815-git-p4-submit-fail.sh\nindex 4cff6a7..37b42d0 100755\n--- a/t/t9815-git-p4-submit-fail.sh\n+++ b/t/t9815-git-p4-submit-fail.sh\n@@ -417,11 +417,8 @@ test_expect_success 'cleanup chmod after submit cancel' '\n \t\t! p4 fstat -T action text &&\n \t\ttest_path_is_file text+x &&\n \t\t! p4 fstat -T action text+x &&\n-\t\tif test_have_prereq !CYGWIN\n-\t\tthen\n-\t\t\tstat --format=%A text | egrep ^-r-- &&\n-\t\t\tstat --format=%A text+x | egrep ^-r-x\n-\t\tfi\n+\t\tls -l text | egrep ^-r-- &&\n+\t\tls -l text+x | egrep ^-r-x\n \t)\n '\n \n-- \n2.5.1\n"},{"id":"271459","messageId":"1444669384-85419-3-git-send-email-larsxschneider@gmail.com","threadId":"40538","inReplyTo":"1444669384-85419-1-git-send-email-larsxschneider@gmail.com","subject":"[PATCH v1 2/2] git-p4: Skip t9819 test case on case insensitive file systems","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2015-10-12T17:03:04Z","receivedAt":"2015-10-12T17:03:04Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider <larsxschneider@gmail.com>\n\nWindows and OS X file systems are case insensitive by default.\nConsequently the \"git-p4-case-folding\" test case does not apply to\nthem.\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\nAcked-by: Luke Diamand <luke@diamand.org>\n---\n t/t9819-git-p4-case-folding.sh | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh\nindex 78f1d0f..d808c00 100755\n--- a/t/t9819-git-p4-case-folding.sh\n+++ b/t/t9819-git-p4-case-folding.sh\n@@ -4,6 +4,12 @@ test_description='interaction with P4 case-folding'\n \n . ./lib-git-p4.sh\n \n+if test_have_prereq CASE_INSENSITIVE_FS\n+then\n+\tskip_all='skipping P4 case-folding tests; case insensitive file system detected'\n+\ttest_done\n+fi\n+\n test_expect_success 'start p4d with case folding enabled' '\n \tstart_p4d -C1\n '\n-- \n2.5.1\n"},{"id":"272124","messageId":"56296767.2080108@diamand.org","threadId":"40538","inReplyTo":"1444669384-85419-1-git-send-email-larsxschneider@gmail.com","subject":"Re: [PATCH v1 0/2] git-p4: Fix tests on OS X","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-10-22T22:47:03Z","receivedAt":"2015-10-22T22:47:03Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"On 12/10/15 18:03, larsxschneider@gmail.com wrote:\n> From: Lars Schneider <larsxschneider@gmail.com>\n>\n> I extracted this patch series from \"[PATCH v3 0/3] Add Travis CI support\" as\n> suggested by Junio.\n\nAll seems sensible to me.\n\nLuke\n\n\n>\n> Thanks,\n> Lars\n>\n> Lars Schneider (2):\n>    git-p4: Improve test case portability for t9815 git-p4-submit-fail\n>    git-p4: Skip t9819 test case on case insensitive file systems\n>\n>   t/t9815-git-p4-submit-fail.sh  | 7 ++-----\n>   t/t9819-git-p4-case-folding.sh | 6 ++++++\n>   2 files changed, 8 insertions(+), 5 deletions(-)\n>\n> --\n> 2.5.1\n>\n"}]}