{"thread":{"id":"40453","subject":"[PATCH] git-gui: remove the garbage collection hint","startedAt":"2015-09-29T17:33:59Z","lastAt":"2015-09-29T17:33:59Z","messageCount":1,"participants":["Beat Bolli"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"270917","messageId":"1443548039-16276-1-git-send-email-dev+git@drbeat.li","threadId":"40453","inReplyTo":null,"subject":"[PATCH] git-gui: remove the garbage collection hint","fromName":"Beat Bolli","fromEmail":"dev+git@drbeat.li","sentAt":"2015-09-29T17:33:59Z","receivedAt":"2015-09-29T17:33:59Z","isPatch":true,"sender":{"key":"dev+git@drbeat.li","avatar":"https://avatars.githubusercontent.com/u/21444?v=4"},"body":"Git core has had automatic garbage collection for a long time.\nGit-gui does not need a similar heuristic.\n\nSigned-off-by: Beat Bolli <dev+git@drbeat.li>\nCc: Pat Thoyts <patthoyts@users.sourceforge.net>\n---\n git-gui.sh       |  3 ---\n lib/database.tcl | 26 --------------------------\n 2 files changed, 29 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 11048c7..2866777 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -4004,9 +4004,6 @@ after 1 {\n \t\t$ui_comm configure -state disabled -background gray\n \t}\n }\n-if {[is_enabled multicommit] && ![is_config_false gui.gcwarning]} {\n-\tafter 1000 hint_gc\n-}\n if {[is_enabled retcode]} {\n \tbind . <Destroy> {+terminate_me %W}\n }\ndiff --git a/lib/database.tcl b/lib/database.tcl\nindex 1f187ed..808bdf6 100644\n--- a/lib/database.tcl\n+++ b/lib/database.tcl\n@@ -87,29 +87,3 @@ proc do_fsck_objects {} {\n \tlappend cmd --strict\n \tconsole::exec $w $cmd\n }\n-\n-proc hint_gc {} {\n-\tset ndirs 1\n-\tset limit 8\n-\tif {[is_Windows]} {\n-\t\tset ndirs 4\n-\t\tset limit 1\n-\t}\n-\n-\tset count [llength [glob \\\n-\t\t-nocomplain \\\n-\t\t-- \\\n-\t\t[gitdir objects 4\\[0-[expr {$ndirs-1}]\\]/*]]]\n-\n-\tif {$count >= $limit * $ndirs} {\n-\t\tset objects_current [expr {$count * 256/$ndirs}]\n-\t\tif {[ask_popup \\\n-\t\t\t[mc \"This repository currently has approximately %i loose objects.\n-\n-To maintain optimal performance it is strongly recommended that you compress the database.\n-\n-Compress the database now?\" $objects_current]] eq yes} {\n-\t\t\tdo_gc\n-\t\t}\n-\t}\n-}\n-- \n2.5.0.492.g918e48c\n"}]}