{"thread":{"id":"40439","subject":"[PATCH] ls-remote.txt: delete unsupported option","startedAt":"2015-09-28T12:30:17Z","lastAt":"2015-09-28T17:43:52Z","messageCount":2,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"270802","messageId":"1443443417-20235-1-git-send-email-pclouds@gmail.com","threadId":"40439","inReplyTo":null,"subject":"[PATCH] ls-remote.txt: delete unsupported option","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2015-09-28T12:30:17Z","receivedAt":"2015-09-28T12:30:17Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"-u <exec> has never been supported, but it was mentioned since\n0a2bb55 (git ls-remote: make usage string match manpage -\n2008-11-11). Nobody has complained about it for seven years, it's\nprobably safe to say nobody cares. So let's remove \"-u\" in documents\ninstead of adding code to support it.\n\nWhile at there, fix --upload-pack syntax too.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n Documentation/git-ls-remote.txt | 3 +--\n builtin/ls-remote.c             | 2 +-\n 2 files changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-ls-remote.txt b/Documentation/git-ls-remote.txt\nindex 2e22915..d510c05 100644\n--- a/Documentation/git-ls-remote.txt\n+++ b/Documentation/git-ls-remote.txt\n@@ -9,7 +9,7 @@ git-ls-remote - List references in a remote repository\n SYNOPSIS\n --------\n [verse]\n-'git ls-remote' [--heads] [--tags]  [-u <exec> | --upload-pack <exec>]\n+'git ls-remote' [--heads] [--tags]  [--upload-pack=<exec>]\n \t      [--exit-code] <repository> [<refs>...]\n \n DESCRIPTION\n@@ -29,7 +29,6 @@ OPTIONS\n \tboth, references stored in refs/heads and refs/tags are\n \tdisplayed.\n \n--u <exec>::\n --upload-pack=<exec>::\n \tSpecify the full path of 'git-upload-pack' on the remote\n \thost. This allows listing references from repositories accessed via\ndiff --git a/builtin/ls-remote.c b/builtin/ls-remote.c\nindex 4554dbc..5e9d545 100644\n--- a/builtin/ls-remote.c\n+++ b/builtin/ls-remote.c\n@@ -4,7 +4,7 @@\n #include \"remote.h\"\n \n static const char ls_remote_usage[] =\n-\"git ls-remote [--heads] [--tags]  [-u <exec> | --upload-pack <exec>]\\n\"\n+\"git ls-remote [--heads] [--tags]  [--upload-pack=<exec>]\\n\"\n \"                     [-q | --quiet] [--exit-code] [--get-url] [<repository> [<refs>...]]\";\n \n /*\n-- \n2.3.0.rc1.137.g477eb31\n"},{"id":"270823","messageId":"xmqq37xye8x3.fsf@gitster.mtv.corp.google.com","threadId":"40439","inReplyTo":"1443443417-20235-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] ls-remote.txt: delete unsupported option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-28T17:43:52Z","receivedAt":"2015-09-28T17:43:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n> -u <exec> has never been supported, but it was mentioned since\n> 0a2bb55 (git ls-remote: make usage string match manpage -\n> 2008-11-11). Nobody has complained about it for seven years, it's\n> probably safe to say nobody cares. So let's remove \"-u\" in documents\n> instead of adding code to support it.\n\nThis sounds OK.\n\nA potential argument for consistency with fetch does not even apply,\nas over there --upload-pack and -u are different options.\n\n\n\n>\n> While at there, fix --upload-pack syntax too.\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n> ---\n>  Documentation/git-ls-remote.txt | 3 +--\n>  builtin/ls-remote.c             | 2 +-\n>  2 files changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/Documentation/git-ls-remote.txt b/Documentation/git-ls-remote.txt\n> index 2e22915..d510c05 100644\n> --- a/Documentation/git-ls-remote.txt\n> +++ b/Documentation/git-ls-remote.txt\n> @@ -9,7 +9,7 @@ git-ls-remote - List references in a remote repository\n>  SYNOPSIS\n>  --------\n>  [verse]\n> -'git ls-remote' [--heads] [--tags]  [-u <exec> | --upload-pack <exec>]\n> +'git ls-remote' [--heads] [--tags]  [--upload-pack=<exec>]\n>  \t      [--exit-code] <repository> [<refs>...]\n>  \n>  DESCRIPTION\n> @@ -29,7 +29,6 @@ OPTIONS\n>  \tboth, references stored in refs/heads and refs/tags are\n>  \tdisplayed.\n>  \n> --u <exec>::\n>  --upload-pack=<exec>::\n>  \tSpecify the full path of 'git-upload-pack' on the remote\n>  \thost. This allows listing references from repositories accessed via\n> diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c\n> index 4554dbc..5e9d545 100644\n> --- a/builtin/ls-remote.c\n> +++ b/builtin/ls-remote.c\n> @@ -4,7 +4,7 @@\n>  #include \"remote.h\"\n>  \n>  static const char ls_remote_usage[] =\n> -\"git ls-remote [--heads] [--tags]  [-u <exec> | --upload-pack <exec>]\\n\"\n> +\"git ls-remote [--heads] [--tags]  [--upload-pack=<exec>]\\n\"\n>  \"                     [-q | --quiet] [--exit-code] [--get-url] [<repository> [<refs>...]]\";\n>  \n>  /*\n"}]}