{"thread":{"id":"40438","subject":"[PATCH] builtin/apply.c: make a file local symbol static","startedAt":"2015-09-27T18:33:46Z","lastAt":"2015-09-27T18:33:46Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"270798","messageId":"5608368A.4010607@ramsayjones.plus.com","threadId":"40438","inReplyTo":null,"subject":"[PATCH] builtin/apply.c: make a file local symbol static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2015-09-27T18:33:46Z","receivedAt":"2015-09-27T18:33:46Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit dddaaab62 (\"apply: convert root string to strbuf\", 24-09-2015)\nconverted a <char *str, int len> combination of variables into a\nsingle 'struct strbuf' variable. In doing so, it unintentionally\nincreased the visibility of the variable. In order to reduce the\nvisibility to file local, add the static keyword to the declaration\nof the 'root' symbol.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Jeff,\n\nIf you need to re-roll your 'jk/war-on-sprintf' series, could you\nplease squash this into the relevant patch.\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/apply.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/apply.c b/builtin/apply.c\nindex 5dc908a..ec49658 100644\n--- a/builtin/apply.c\n+++ b/builtin/apply.c\n@@ -77,7 +77,7 @@ static enum ws_ignore {\n \n \n static const char *patch_input_file;\n-struct strbuf root = STRBUF_INIT;\n+static struct strbuf root = STRBUF_INIT;\n static int read_stdin = 1;\n static int options;\n \n-- \n2.5.0\n"}]}