{"thread":{"id":"40430","subject":"Formatting error in page http://git-scm.com/docs/user-manual","startedAt":"2015-09-25T12:38:02Z","lastAt":"2015-09-25T14:29:18Z","messageCount":3,"participants":["Valentin VALCIU","John Keeping","Michael J Gruber"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"270748","messageId":"CAOq7JjbYP=fGB0aqbrMz_ibfWHor-v-Y-BsO316H4dHpfSYS-w@mail.gmail.com","threadId":"40430","inReplyTo":null,"subject":"Formatting error in page http://git-scm.com/docs/user-manual","fromName":"Valentin VALCIU","fromEmail":"axiac.ro@gmail.com","sentAt":"2015-09-25T12:38:02Z","receivedAt":"2015-09-25T12:38:02Z","isPatch":false,"sender":{"key":"axiac.ro@gmail.com","avatar":null},"body":"Hello!\n\nThere is a formatting error in the source code of page\nhttp://git-scm.com/docs/user-manual that makes almost half of it be\nrendered in a <pre> element displaying the page source in the original\nmarkup language instead of being converted to HTML.\n\nThe issue is in the paragraph that stars with \"The index is a binary\nfile (generally kept in `.git/index`)...\"\n\n\nRegards,\n--\nValentin VĂLCIU,\nBucharest, Romania\n"},{"id":"270749","messageId":"20150925125935.GN17201@serenity.lan","threadId":"40430","inReplyTo":"CAOq7JjbYP=fGB0aqbrMz_ibfWHor-v-Y-BsO316H4dHpfSYS-w@mail.gmail.com","subject":"Re: Formatting error in page http://git-scm.com/docs/user-manual","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2015-09-25T12:59:35Z","receivedAt":"2015-09-25T12:59:35Z","isPatch":false,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Fri, Sep 25, 2015 at 03:38:02PM +0300, Valentin VALCIU wrote:\n> There is a formatting error in the source code of page\n> http://git-scm.com/docs/user-manual that makes almost half of it be\n> rendered in a <pre> element displaying the page source in the original\n> markup language instead of being converted to HTML.\n> \n> The issue is in the paragraph that stars with \"The index is a binary\n> file (generally kept in `.git/index`)...\"\n\nIt looks like the header underline isn't quite accurate enough to keep\nAsciidoctor happy.  The patch below should fix it.\n\n-- >8 --\nSubject: [PATCH] Documentation/user-manual: fix header underline\n\nAsciidoctor is stricter than AsciiDoc when deciding if underlining is a\nsection title or the start of preformatted text.  Make the length of the\nunderlining match the text to ensure that it renders correctly in all\nimplementations.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n Documentation/user-manual.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\nindex 68978f5..1b7987e 100644\n--- a/Documentation/user-manual.txt\n+++ b/Documentation/user-manual.txt\n@@ -3424,7 +3424,7 @@ just missing one particular blob version.\n \n [[the-index]]\n The index\n------------\n+---------\n \n The index is a binary file (generally kept in `.git/index`) containing a\n sorted list of path names, each with permissions and the SHA-1 of a blob\n-- \n2.6.0.rc2.198.g81437b7\n"},{"id":"270750","messageId":"56055A3E.4020800@drmicha.warpmail.net","threadId":"40430","inReplyTo":"20150925125935.GN17201@serenity.lan","subject":"Re: Formatting error in page http://git-scm.com/docs/user-manual","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2015-09-25T14:29:18Z","receivedAt":"2015-09-25T14:29:18Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"John Keeping venit, vidit, dixit 25.09.2015 14:59:\n> On Fri, Sep 25, 2015 at 03:38:02PM +0300, Valentin VALCIU wrote:\n>> There is a formatting error in the source code of page\n>> http://git-scm.com/docs/user-manual that makes almost half of it be\n>> rendered in a <pre> element displaying the page source in the original\n>> markup language instead of being converted to HTML.\n>>\n>> The issue is in the paragraph that stars with \"The index is a binary\n>> file (generally kept in `.git/index`)...\"\n> \n> It looks like the header underline isn't quite accurate enough to keep\n> Asciidoctor happy.  The patch below should fix it.\n> \n> -- >8 --\n> Subject: [PATCH] Documentation/user-manual: fix header underline\n> \n> Asciidoctor is stricter than AsciiDoc when deciding if underlining is a\n> section title or the start of preformatted text.  Make the length of the\n> underlining match the text to ensure that it renders correctly in all\n> implementations.\n> \n> Signed-off-by: John Keeping <john@keeping.me.uk>\n> ---\n>  Documentation/user-manual.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\n> index 68978f5..1b7987e 100644\n> --- a/Documentation/user-manual.txt\n> +++ b/Documentation/user-manual.txt\n> @@ -3424,7 +3424,7 @@ just missing one particular blob version.\n>  \n>  [[the-index]]\n>  The index\n> ------------\n> +---------\n>  \n>  The index is a binary file (generally kept in `.git/index`) containing a\n>  sorted list of path names, each with permissions and the SHA-1 of a blob\n> \n\nThe only other instance seems to be:\n\nDocumentation/git-bisect-lk2009.txt-Acknowledgments\nDocumentation/git-bisect-lk2009.txt:----------------\n\nDunno if we want to fix that, too.\n\nMichael\n"}]}