{"thread":{"id":"40410","subject":"git-p4: t9819 failing","startedAt":"2015-09-23T09:27:36Z","lastAt":"2015-09-25T09:29:37Z","messageCount":7,"participants":["Luke Diamand","Lars Schneider"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"270569","messageId":"CAE5ih79t+62XUKsj9cnkJCCv4WPhUgQZQ6hF39Nx0ky+WFi-sw@mail.gmail.com","threadId":"40410","inReplyTo":null,"subject":"git-p4: t9819 failing","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-09-23T09:27:36Z","receivedAt":"2015-09-23T09:27:36Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"Lars,\n\nI just noticed that your change \"git-p4: honor core.ignorecase when\nusing P4 client specs\" seems to break t9819.\n\nI suspect that the problem is just that t9819 needs to be updated to\nreflect your change - do you have any thoughts on that?\n\nThanks!\nLuke\n"},{"id":"270570","messageId":"954B65C2-1CF8-4F63-B2DE-F15200553046@gmail.com","threadId":"40410","inReplyTo":"CAE5ih79t+62XUKsj9cnkJCCv4WPhUgQZQ6hF39Nx0ky+WFi-sw@mail.gmail.com","subject":"Re: git-p4: t9819 failing","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2015-09-23T10:27:45Z","receivedAt":"2015-09-23T10:27:45Z","isPatch":false,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\nOn 23 Sep 2015, at 11:27, Luke Diamand wrote:\n\n> Lars,\n> \n> I just noticed that your change \"git-p4: honor core.ignorecase when\n> using P4 client specs\" seems to break t9819.\n> \n> I suspect that the problem is just that t9819 needs to be updated to\n> reflect your change - do you have any thoughts on that?\n> \n> Thanks!\n> Luke\n\nWhat OS and what commit do you use for testing? Here is what I got on my machine:\n\nUbuntu, next (c07a1e8) -> OK\nUbuntu, maint (ee6ad5f) -> OK\n\nOS X, next (c07a1e8) -> broken\nOS X, maint (ee6ad5f) -> broken\n\nThanks,\nLars"},{"id":"270573","messageId":"CAE5ih78x+jnW3+4d5q5dJidt4LXWV=hMgJTEfsC2dUBLout1Aw@mail.gmail.com","threadId":"40410","inReplyTo":"954B65C2-1CF8-4F63-B2DE-F15200553046@gmail.com","subject":"Re: git-p4: t9819 failing","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-09-23T11:11:05Z","receivedAt":"2015-09-23T11:11:05Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"On 23 September 2015 at 11:27, Lars Schneider wrote:\n>\n> On 23 Sep 2015, at 11:27, Luke Diamand wrote:\n>\n>> Lars,\n>>\n>> I just noticed that your change \"git-p4: honor core.ignorecase when\n>> using P4 client specs\" seems to break t9819.\n>>\n>> I suspect that the problem is just that t9819 needs to be updated to\n>> reflect your change - do you have any thoughts on that?\n>>\n>> Thanks!\n>> Luke\n>\n> What OS and what commit do you use for testing? Here is what I got on my machine:\n>\n> Ubuntu, next (c07a1e8) -> OK\n> Ubuntu, maint (ee6ad5f) -> OK\n>\n> OS X, next (c07a1e8) -> broken\n> OS X, maint (ee6ad5f) -> broken\n\nThe next branch is good:\nc07a1e8 Merge branch 'bb/remote-get-url' into next\n\nThe pu branch isn't:\nf44e3df Merge branch 'jk/notes-dwim-doc' into pu\n\nThis is on Debian.\n\nActually I think the problem may be in calcDiskFree().\n\nHere's the last bit of the crash dump from git-p4 I get:\n\n File \"/home/ldiamand/git/git/git-p4\", line 2580, in streamP4FilesCbSelf\n self.streamP4FilesCb(entry)\n File \"/home/ldiamand/git/git/git-p4\", line 2497, in streamP4FilesCb\n required_bytes = int((4 * int(self.stream_file[\"fileSize\"])) -\ncalcDiskFree(self.cloneDestination))\n File \"/home/ldiamand/git/git/git-p4\", line 116, in calcDiskFree\n st = os.statvfs(dirname)\nOSError: [Errno 2] No such file or directory: 'lc'\n\nLuke\n"},{"id":"270576","messageId":"F37BA8D8-6845-4C47-BBE2-3313685FD16F@gmail.com","threadId":"40410","inReplyTo":"CAE5ih78x+jnW3+4d5q5dJidt4LXWV=hMgJTEfsC2dUBLout1Aw@mail.gmail.com","subject":"Re: git-p4: t9819 failing","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2015-09-23T12:28:40Z","receivedAt":"2015-09-23T12:28:40Z","isPatch":false,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\nOn 23 Sep 2015, at 13:11, Luke Diamand wrote:\n\n> On 23 September 2015 at 11:27, Lars Schneider wrote:\n>> \n>> On 23 Sep 2015, at 11:27, Luke Diamand wrote:\n>> \n>>> Lars,\n>>> \n>>> I just noticed that your change \"git-p4: honor core.ignorecase when\n>>> using P4 client specs\" seems to break t9819.\n>>> \n>>> I suspect that the problem is just that t9819 needs to be updated to\n>>> reflect your change - do you have any thoughts on that?\n>>> \n>>> Thanks!\n>>> Luke\n>> \n>> What OS and what commit do you use for testing? Here is what I got on my machine:\n>> \n>> Ubuntu, next (c07a1e8) -> OK\n>> Ubuntu, maint (ee6ad5f) -> OK\n>> \n>> OS X, next (c07a1e8) -> broken\n>> OS X, maint (ee6ad5f) -> broken\n> \n> The next branch is good:\n> c07a1e8 Merge branch 'bb/remote-get-url' into next\n> \n> The pu branch isn't:\n> f44e3df Merge branch 'jk/notes-dwim-doc' into pu\n> \n> This is on Debian.\n> \n> Actually I think the problem may be in calcDiskFree().\n> \n> Here's the last bit of the crash dump from git-p4 I get:\n> \n> File \"/home/ldiamand/git/git/git-p4\", line 2580, in streamP4FilesCbSelf\n> self.streamP4FilesCb(entry)\n> File \"/home/ldiamand/git/git/git-p4\", line 2497, in streamP4FilesCb\n> required_bytes = int((4 * int(self.stream_file[\"fileSize\"])) -\n> calcDiskFree(self.cloneDestination))\n> File \"/home/ldiamand/git/git/git-p4\", line 116, in calcDiskFree\n> st = os.statvfs(dirname)\n> OSError: [Errno 2] No such file or directory: 'lc'\n> \n> Luke\nConfirmed. What do you think about this fix?\n\nThank you,\nLars\n\n---\n git-p4.py | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex 1d1bb87..66c0a4e 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -3478,6 +3478,7 @@ class P4Clone(P4Sync):\n \n print \"Importing from %s into %s\" % (', '.join(depotPaths), self.cloneDestination)\n \n+ self.cloneDestination = os.path.abspath(self.cloneDestination)\n if not os.path.exists(self.cloneDestination):\n os.makedirs(self.cloneDestination)\n chdir(self.cloneDestination)\n-- "},{"id":"270628","messageId":"CAE5ih78m9RbD=s_12ckA+yzRP=fuiruF=kasUSFZEjUZZA21UQ@mail.gmail.com","threadId":"40410","inReplyTo":"F37BA8D8-6845-4C47-BBE2-3313685FD16F@gmail.com","subject":"Re: git-p4: t9819 failing","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-09-24T07:45:22Z","receivedAt":"2015-09-24T07:45:22Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"On 23 September 2015 at 13:28, Lars Schneider wrote:\n>\n>> Here's the last bit of the crash dump from git-p4 I get:\n>>\n>> File \"/home/ldiamand/git/git/git-p4\", line 2580, in streamP4FilesCbSelf\n>> self.streamP4FilesCb(entry)\n>> File \"/home/ldiamand/git/git/git-p4\", line 2497, in streamP4FilesCb\n>> required_bytes = int((4 * int(self.stream_file[\"fileSize\"])) -\n>> calcDiskFree(self.cloneDestination))\n>> File \"/home/ldiamand/git/git/git-p4\", line 116, in calcDiskFree\n>> st = os.statvfs(dirname)\n>> OSError: [Errno 2] No such file or directory: 'lc'\n>>\n>> Luke\n> Confirmed. What do you think about this fix?\n\nWorks for me!\n\n\n\n>\n> Thank you,\n> Lars\n>\n> ---\n> git-p4.py | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/git-p4.py b/git-p4.py\n> index 1d1bb87..66c0a4e 100755\n> --- a/git-p4.py\n> +++ b/git-p4.py\n> @@ -3478,6 +3478,7 @@ class P4Clone(P4Sync):\n>\n> print \"Importing from %s into %s\" % (', '.join(depotPaths), self.cloneDestination)\n>\n> + self.cloneDestination = os.path.abspath(self.cloneDestination)\n> if not os.path.exists(self.cloneDestination):\n> os.makedirs(self.cloneDestination)\n> chdir(self.cloneDestination)\n> --\n"},{"id":"270646","messageId":"CAE5ih7-f3V2YSWW7FO-MxB6BPu7WjB93jDDFs5mKkzz2wDX0yA@mail.gmail.com","threadId":"40410","inReplyTo":"CAE5ih78m9RbD=s_12ckA+yzRP=fuiruF=kasUSFZEjUZZA21UQ@mail.gmail.com","subject":"Re: git-p4: t9819 failing","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-09-24T20:29:01Z","receivedAt":"2015-09-24T20:29:01Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"OK, slight correction there - it now doesn't crash getting the disk\nusage, but I think it still needs to be updated following the other\nchanges to case-handling.\n\nLuke\n\nOn 24 September 2015 at 08:45, Luke Diamand wrote:\n> On 23 September 2015 at 13:28, Lars Schneider wrote:\n>>\n>>> Here's the last bit of the crash dump from git-p4 I get:\n>>>\n>>> File \"/home/ldiamand/git/git/git-p4\", line 2580, in streamP4FilesCbSelf\n>>> self.streamP4FilesCb(entry)\n>>> File \"/home/ldiamand/git/git/git-p4\", line 2497, in streamP4FilesCb\n>>> required_bytes = int((4 * int(self.stream_file[\"fileSize\"])) -\n>>> calcDiskFree(self.cloneDestination))\n>>> File \"/home/ldiamand/git/git/git-p4\", line 116, in calcDiskFree\n>>> st = os.statvfs(dirname)\n>>> OSError: [Errno 2] No such file or directory: 'lc'\n>>>\n>>> Luke\n>> Confirmed. What do you think about this fix?\n>\n> Works for me!\n>\n>\n>\n>>\n>> Thank you,\n>> Lars\n>>\n>> ---\n>> git-p4.py | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/git-p4.py b/git-p4.py\n>> index 1d1bb87..66c0a4e 100755\n>> --- a/git-p4.py\n>> +++ b/git-p4.py\n>> @@ -3478,6 +3478,7 @@ class P4Clone(P4Sync):\n>>\n>> print \"Importing from %s into %s\" % (', '.join(depotPaths), self.cloneDestination)\n>>\n>> + self.cloneDestination = os.path.abspath(self.cloneDestination)\n>> if not os.path.exists(self.cloneDestination):\n>> os.makedirs(self.cloneDestination)\n>> chdir(self.cloneDestination)\n>> --\n"},{"id":"270745","messageId":"AFE58E7F-88FA-4DF8-9372-B2B0D1E0E2AC@gmail.com","threadId":"40410","inReplyTo":"CAE5ih7-f3V2YSWW7FO-MxB6BPu7WjB93jDDFs5mKkzz2wDX0yA@mail.gmail.com","subject":"Re: git-p4: t9819 failing","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2015-09-25T09:29:37Z","receivedAt":"2015-09-25T09:29:37Z","isPatch":false,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"Good catch. The case-handling test is actually fine. There was a bug in my implementation!\n\nIf you do this:\ngit p4 clone //depot/something/...\n\nThen git p4 generates a directory “something” and clones into that (similar to Git). Since I set “cloneDirectory” to the current working directory that logic never kicked in. Therefore the depot was cloned into the current working directory instead of a new directory “something” and the test broke.\n\nThanks,\nLars\n\nOn 24 Sep 2015, at 22:29, Luke Diamand wrote:\n\n> OK, slight correction there - it now doesn't crash getting the disk\n> usage, but I think it still needs to be updated following the other\n> changes to case-handling.\n> \n> Luke\n> \n> On 24 September 2015 at 08:45, Luke Diamand wrote:\n>> On 23 September 2015 at 13:28, Lars Schneider wrote:\n>>> \n>>>> Here's the last bit of the crash dump from git-p4 I get:\n>>>> \n>>>> File \"/home/ldiamand/git/git/git-p4\", line 2580, in streamP4FilesCbSelf\n>>>> self.streamP4FilesCb(entry)\n>>>> File \"/home/ldiamand/git/git/git-p4\", line 2497, in streamP4FilesCb\n>>>> required_bytes = int((4 * int(self.stream_file[\"fileSize\"])) -\n>>>> calcDiskFree(self.cloneDestination))\n>>>> File \"/home/ldiamand/git/git/git-p4\", line 116, in calcDiskFree\n>>>> st = os.statvfs(dirname)\n>>>> OSError: [Errno 2] No such file or directory: 'lc'\n>>>> \n>>>> Luke\n>>> Confirmed. What do you think about this fix?\n>> \n>> Works for me!\n>> \n>> \n>> \n>>> \n>>> Thank you,\n>>> Lars\n>>> \n>>> ---\n>>> git-p4.py | 1 +\n>>> 1 file changed, 1 insertion(+)\n>>> \n>>> diff --git a/git-p4.py b/git-p4.py\n>>> index 1d1bb87..66c0a4e 100755\n>>> --- a/git-p4.py\n>>> +++ b/git-p4.py\n>>> @@ -3478,6 +3478,7 @@ class P4Clone(P4Sync):\n>>> \n>>> print \"Importing from %s into %s\" % (', '.join(depotPaths), self.cloneDestination)\n>>> \n>>> + self.cloneDestination = os.path.abspath(self.cloneDestination)\n>>> if not os.path.exists(self.cloneDestination):\n>>> os.makedirs(self.cloneDestination)\n>>> chdir(self.cloneDestination)\n>>> --\n"}]}