{"thread":{"id":"40311","subject":"[PATCH] gitk: accelerators for the main menu","startedAt":"2015-09-09T13:20:53Z","lastAt":"2015-09-14T18:51:45Z","messageCount":3,"participants":["Giuseppe Bilotta","Paul Mackerras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"269657","messageId":"1441804853-28346-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"40311","inReplyTo":null,"subject":"[PATCH] gitk: accelerators for the main menu","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2015-09-09T13:20:53Z","receivedAt":"2015-09-09T13:20:53Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N to open a\nnew view).\n\nSigned-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n---\n gitk | 46 +++++++++++++++++++++++-----------------------\n 1 file changed, 23 insertions(+), 23 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 51520ef..4fc6267 100755\n--- a/gitk\n+++ b/gitk\n@@ -2065,33 +2065,33 @@ proc makewindow {} {\n     # The \"mc\" arguments here are purely so that xgettext\n     # sees the following string as needing to be translated\n     set file {\n-\tmc \"File\" cascade {\n-\t    {mc \"Update\" command updatecommits -accelerator F5}\n-\t    {mc \"Reload\" command reloadcommits -accelerator Shift-F5}\n-\t    {mc \"Reread references\" command rereadrefs}\n-\t    {mc \"List references\" command showrefs -accelerator F2}\n+\tmc \"&File\" cascade {\n+\t    {mc \"&Update\" command updatecommits -accelerator F5}\n+\t    {mc \"&Reload\" command reloadcommits -accelerator Shift-F5}\n+\t    {mc \"Reread re&ferences\" command rereadrefs}\n+\t    {mc \"&List references\" command showrefs -accelerator F2}\n \t    {xx \"\" separator}\n-\t    {mc \"Start git gui\" command {exec git gui &}}\n+\t    {mc \"Start git &gui\" command {exec git gui &}}\n \t    {xx \"\" separator}\n-\t    {mc \"Quit\" command doquit -accelerator Meta1-Q}\n+\t    {mc \"&Quit\" command doquit -accelerator Meta1-Q}\n \t}}\n     set edit {\n-\tmc \"Edit\" cascade {\n-\t    {mc \"Preferences\" command doprefs}\n+\tmc \"&Edit\" cascade {\n+\t    {mc \"&Preferences\" command doprefs}\n \t}}\n     set view {\n-\tmc \"View\" cascade {\n-\t    {mc \"New view...\" command {newview 0} -accelerator Shift-F4}\n-\t    {mc \"Edit view...\" command editview -state disabled -accelerator F4}\n-\t    {mc \"Delete view\" command delview -state disabled}\n+\tmc \"&View\" cascade {\n+\t    {mc \"&New view...\" command {newview 0} -accelerator Shift-F4}\n+\t    {mc \"&Edit view...\" command editview -state disabled -accelerator F4}\n+\t    {mc \"&Delete view\" command delview -state disabled}\n \t    {xx \"\" separator}\n-\t    {mc \"All files\" radiobutton {selectedview 0} -command {showview 0}}\n+\t    {mc \"&All files\" radiobutton {selectedview 0} -command {showview 0}}\n \t}}\n     if {[tk windowingsystem] ne \"aqua\"} {\n \tset help {\n-\tmc \"Help\" cascade {\n-\t    {mc \"About gitk\" command about}\n-\t    {mc \"Key bindings\" command keys}\n+\tmc \"&Help\" cascade {\n+\t    {mc \"&About gitk\" command about}\n+\t    {mc \"&Key bindings\" command keys}\n \t}}\n \tset bar [list $file $edit $view $help]\n     } else {\n@@ -2099,13 +2099,13 @@ proc makewindow {} {\n \tproc ::tk::mac::Quit {} {doquit}\n \tlset file end [lreplace [lindex $file end] end-1 end]\n \tset apple {\n-\txx \"Apple\" cascade {\n-\t    {mc \"About gitk\" command about}\n+\txx \"&Apple\" cascade {\n+\t    {mc \"&About gitk\" command about}\n \t    {xx \"\" separator}\n \t}}\n \tset help {\n-\tmc \"Help\" cascade {\n-\t    {mc \"Key bindings\" command keys}\n+\tmc \"&Help\" cascade {\n+\t    {mc \"&Key bindings\" command keys}\n \t}}\n \tset bar [list $apple $file $view $help]\n     }\n@@ -4468,8 +4468,8 @@ proc showview {n} {\n \n     set curview $n\n     set selectedview $n\n-    .bar.view entryconf [mca \"Edit view...\"] -state [expr {$n == 0? \"disabled\": \"normal\"}]\n-    .bar.view entryconf [mca \"Delete view\"] -state [expr {$n == 0? \"disabled\": \"normal\"}]\n+    .bar.view entryconf [mca \"&Edit view...\"] -state [expr {$n == 0? \"disabled\": \"normal\"}]\n+    .bar.view entryconf [mca \"&Delete view\"] -state [expr {$n == 0? \"disabled\": \"normal\"}]\n \n     run refill_reflist\n     if {![info exists viewcomplete($n)]} {\n-- \n2.6.0.rc1.170.g51893f9.dirty\n"},{"id":"269876","messageId":"20150913122451.GB12913@fergus.ozlabs.ibm.com","threadId":"40311","inReplyTo":"1441804853-28346-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] gitk: accelerators for the main menu","fromName":"Paul Mackerras","fromEmail":"paulus@ozlabs.org","sentAt":"2015-09-13T12:24:51Z","receivedAt":"2015-09-13T12:24:51Z","isPatch":true,"sender":{"key":"paulus@ozlabs.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Wed, Sep 09, 2015 at 03:20:53PM +0200, Giuseppe Bilotta wrote:\n> This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N to open a\n> new view).\n> \n> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n\nThanks, applied.\n\nPaul.\n"},{"id":"269956","messageId":"xmqq7fnsx29q.fsf@gitster.mtv.corp.google.com","threadId":"40311","inReplyTo":"20150913122451.GB12913@fergus.ozlabs.ibm.com","subject":"Re: [PATCH] gitk: accelerators for the main menu","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-14T18:51:45Z","receivedAt":"2015-09-14T18:51:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Paul Mackerras <paulus@ozlabs.org> writes:\n\n> On Wed, Sep 09, 2015 at 03:20:53PM +0200, Giuseppe Bilotta wrote:\n>> This allows fast, keyboard-only usage of the menu (e.g. Alt+V, N to open a\n>> new view).\n>> \n>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n>\n> Thanks, applied.\n\nThanks; will pull from you before tagging 2.6-rc2.\n"}]}