{"thread":{"id":"40296","subject":"[PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry","startedAt":"2015-09-07T23:16:37Z","lastAt":"2015-09-13T12:24:34Z","messageCount":2,"participants":["Beat Bolli","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"269583","messageId":"1441667797-5407-1-git-send-email-dev+git@drbeat.li","threadId":"40296","inReplyTo":null,"subject":"[PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry","fromName":"Beat Bolli","fromEmail":"dev+git@drbeat.li","sentAt":"2015-09-07T23:16:37Z","receivedAt":"2015-09-07T23:16:37Z","isPatch":true,"sender":{"key":"dev+git@drbeat.li","avatar":"https://avatars.githubusercontent.com/u/21444?v=4"},"body":"Commit d835dbb9 (\"gitk: Add a \"Copy commit summary\" command\",\n2015-08-13) in the upstream gitk repo added a new context menu entry.\nTherefore, the line numbers of the entries below the new one need to be\nadjusted when their text or state is changed.\n\nSigned-off-by: Beat Bolli <dev+git@drbeat.li>\nCc: Paul Mackerras <paulus@samba.org>\n---\n gitk-git/gitk | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex d05169a..bc0e586 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -8877,13 +8877,13 @@ proc rowmenu {x y id} {\n     if {$id ne $nullid && $id ne $nullid2} {\n \tset menu $rowctxmenu\n \tif {$mainhead ne {}} {\n-\t    $menu entryconfigure 7 -label [mc \"Reset %s branch to here\" $mainhead] -state normal\n+\t    $menu entryconfigure 8 -label [mc \"Reset %s branch to here\" $mainhead] -state normal\n \t} else {\n-\t    $menu entryconfigure 7 -label [mc \"Detached head: can't reset\" $mainhead] -state disabled\n+\t    $menu entryconfigure 8 -label [mc \"Detached head: can't reset\" $mainhead] -state disabled\n \t}\n-\t$menu entryconfigure 9 -state $mstate\n \t$menu entryconfigure 10 -state $mstate\n \t$menu entryconfigure 11 -state $mstate\n+\t$menu entryconfigure 12 -state $mstate\n     } else {\n \tset menu $fakerowmenu\n     }\n-- \n2.5.0.492.g918e48c\n"},{"id":"269877","messageId":"20150913122434.GA12913@fergus.ozlabs.ibm.com","threadId":"40296","inReplyTo":"1441667797-5407-1-git-send-email-dev+git@drbeat.li","subject":"Re: [PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry","fromName":"Paul Mackerras","fromEmail":"paulus@ozlabs.org","sentAt":"2015-09-13T12:24:34Z","receivedAt":"2015-09-13T12:24:34Z","isPatch":true,"sender":{"key":"paulus@ozlabs.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Tue, Sep 08, 2015 at 01:16:37AM +0200, Beat Bolli wrote:\n> Commit d835dbb9 (\"gitk: Add a \"Copy commit summary\" command\",\n> 2015-08-13) in the upstream gitk repo added a new context menu entry.\n> Therefore, the line numbers of the entries below the new one need to be\n> adjusted when their text or state is changed.\n> \n> Signed-off-by: Beat Bolli <dev+git@drbeat.li>\n> Cc: Paul Mackerras <paulus@samba.org>\n\nThanks, applied.\n\nPaul.\n"}]}