{"thread":{"id":"40293","subject":"bash completion lacks options","startedAt":"2015-09-07T15:07:58Z","lastAt":"2015-09-08T18:38:38Z","messageCount":6,"participants":["Olaf Hering","Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"269570","messageId":"20150907150757.GA6720@aepfle.de","threadId":"40293","inReplyTo":null,"subject":"bash completion lacks options","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-09-07T15:07:58Z","receivedAt":"2015-09-07T15:07:58Z","isPatch":false,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"\"git send-email --f\" lacks --find-renames and others. Is the list\nof possible options maintained manually? Perhaps this should be\nautomated by placing the long strings in an ELF section, then filling\nvariables like $__git_format_patch_options from such ELF section.\nAn example how this was done in libguestfs is here (see daemon/daemon.h):\nhttps://github.com/libguestfs/libguestfs/commit/0306c98d319d189281af3c15101c8d343e400f13\n\nOlaf\n"},{"id":"269571","messageId":"CACBZZX4aZo_hn07Pho2GtBVNWm7WHLbV6xSi_r-BjW97QWNqEg@mail.gmail.com","threadId":"40293","inReplyTo":"20150907150757.GA6720@aepfle.de","subject":"Re: bash completion lacks options","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2015-09-07T15:34:09Z","receivedAt":"2015-09-07T15:34:09Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Mon, Sep 7, 2015 at 5:07 PM, Olaf Hering wrote:\n> \"git send-email --f\" lacks --find-renames and others. Is the list\n> of possible options maintained manually?\n\nYes, see contrib/completion/git-completion.bash.\n\nThere's no code for send-email there, you (or someone) could submit a patch! :)\n\n> Perhaps this should be\n> automated by placing the long strings in an ELF section, then filling\n> variables like $__git_format_patch_options from such ELF section.\n> An example how this was done in libguestfs is here (see daemon/daemon.h):\n> https://github.com/libguestfs/libguestfs/commit/0306c98d319d189281af3c15101c8d343e400f13\n\nThis is an interesting approach, but wouldn't help with git-send-email\nin particular, it's a Perl script, so there's no ELF section to parse.\n"},{"id":"269572","messageId":"55EDAEF3.7000503@aepfle.de","threadId":"40293","inReplyTo":"CACBZZX4aZo_hn07Pho2GtBVNWm7WHLbV6xSi_r-BjW97QWNqEg@mail.gmail.com","subject":"Re: bash completion lacks options","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-09-07T15:36:19Z","receivedAt":"2015-09-07T15:36:19Z","isPatch":false,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"Am 07.09.2015 um 17:34 schrieb Ævar Arnfjörð Bjarmason:\n> On Mon, Sep 7, 2015 at 5:07 PM, Olaf Hering wrote:\n\n>> https://github.com/libguestfs/libguestfs/commit/0306c98d319d189281af3c15101c8d343e400f13\n> \n> This is an interesting approach, but wouldn't help with git-send-email\n> in particular, it's a Perl script, so there's no ELF section to parse.\n\nformat-patch is a ELF binary, a link to git itself as I notice\njust now.\n\nOlaf\n"},{"id":"269605","messageId":"CACBZZX44qsZZovvJFwP9foqhWaD1ZmL3u+F3hYv2iVq0CKnO6g@mail.gmail.com","threadId":"40293","inReplyTo":"55EDAEF3.7000503@aepfle.de","subject":"Re: bash completion lacks options","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2015-09-08T11:28:53Z","receivedAt":"2015-09-08T11:28:53Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Mon, Sep 7, 2015 at 5:36 PM, Olaf Hering wrote:\n> Am 07.09.2015 um 17:34 schrieb Ævar Arnfjörð Bjarmason:\n>> On Mon, Sep 7, 2015 at 5:07 PM, Olaf Hering wrote:\n>\n>>> https://github.com/libguestfs/libguestfs/commit/0306c98d319d189281af3c15101c8d343e400f13\n>>\n>> This is an interesting approach, but wouldn't help with git-send-email\n>> in particular, it's a Perl script, so there's no ELF section to parse.\n>\n> format-patch is a ELF binary, a link to git itself as I notice\n> just now.\n\nYes, format-patch is written in C, but you mentioned send-email, which\nis a Perl script.\n"},{"id":"269608","messageId":"55EED94F.3070603@aepfle.de","threadId":"40293","inReplyTo":"CACBZZX44qsZZovvJFwP9foqhWaD1ZmL3u+F3hYv2iVq0CKnO6g@mail.gmail.com","subject":"Re: bash completion lacks options","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-09-08T12:49:19Z","receivedAt":"2015-09-08T12:49:19Z","isPatch":false,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"Am 08.09.2015 um 13:28 schrieb Ævar Arnfjörð Bjarmason:\n> Yes, format-patch is written in C, but you mentioned send-email, which\n> is a Perl script.\n\nsend-mail is handled in my copy of the bash_completion, at the end\nthe list the format-patch options gets appended. That list could be\nautogenerated at build time. Maybe I will find the time to do it myself\nat some point.\n\nOlaf\n"},{"id":"269621","messageId":"xmqqzj0w7o41.fsf@gitster.mtv.corp.google.com","threadId":"40293","inReplyTo":"CACBZZX44qsZZovvJFwP9foqhWaD1ZmL3u+F3hYv2iVq0CKnO6g@mail.gmail.com","subject":"Re: bash completion lacks options","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-08T18:38:38Z","receivedAt":"2015-09-08T18:38:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> On Mon, Sep 7, 2015 at 5:36 PM, Olaf Hering wrote:\n>> Am 07.09.2015 um 17:34 schrieb Ævar Arnfjörð Bjarmason:\n>>> On Mon, Sep 7, 2015 at 5:07 PM, Olaf Hering wrote:\n>>\n>>>> https://github.com/libguestfs/libguestfs/commit/0306c98d319d189281af3c15101c8d343e400f13\n>>>\n>>> This is an interesting approach, but wouldn't help with git-send-email\n>>> in particular, it's a Perl script, so there's no ELF section to parse.\n>>\n>> format-patch is a ELF binary, a link to git itself as I notice\n>> just now.\n>\n> Yes, format-patch is written in C, but you mentioned send-email, which\n> is a Perl script.\n\nI think Olaf means that send-email has a mode where it can drive format-patch\ndirectly from the command line.\n\nThis is a slightly related tangent, but I've been wondering if it\nmakes sense to discourage, deprecate and eventually remove that mode\nof operation. It appears it is the biggest single source of poorly\nproof-read series, when compared to \"format-patch to a directory\nwith --cover option and then give them a final scan before running\nsend-email on them\" workflow.\n"}]}