{"thread":{"id":"40281","subject":"[PATCH] Makefile: fix MAKEFLAGS tests with multiple flags","startedAt":"2015-09-05T12:22:10Z","lastAt":"2015-09-05T12:22:10Z","messageCount":1,"participants":["John Keeping"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"269477","messageId":"5c25f77717582a8f38a089da343b4cd2d6af345d.1441455709.git.john@keeping.me.uk","threadId":"40281","inReplyTo":null,"subject":"[PATCH] Makefile: fix MAKEFLAGS tests with multiple flags","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2015-09-05T12:22:10Z","receivedAt":"2015-09-05T12:22:10Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"findstring is defined as $(findstring FIND,IN) so if multiple flags are\nset these tests do the wrong thing unless $(MAKEFLAGS) is the second\nargument.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n Makefile | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 34101e2..a556be6 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1463,13 +1463,13 @@ endif\n QUIET_SUBDIR0  = +$(MAKE) -C # space to separate -C and subdir\n QUIET_SUBDIR1  =\n \n-ifneq ($(findstring $(MAKEFLAGS),w),w)\n+ifneq ($(findstring w,$(MAKEFLAGS)),w)\n PRINT_DIR = --no-print-directory\n else # \"make -w\"\n NO_SUBDIR = :\n endif\n \n-ifneq ($(findstring $(MAKEFLAGS),s),s)\n+ifneq ($(findstring s,$(MAKEFLAGS)),s)\n ifndef V\n \tQUIET_CC       = @echo '   ' CC $@;\n \tQUIET_AR       = @echo '   ' AR $@;\n-- \n2.5.0.466.g9af26fa\n"}]}