{"thread":{"id":"40268","subject":"[PATCH] Remove perl dependant commands if NO_PERL is set","startedAt":"2015-09-03T19:46:44Z","lastAt":"2015-09-03T20:04:34Z","messageCount":2,"participants":["garga@freebsd.org","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"269355","messageId":"1441309604-91875-1-git-send-email-garga@FreeBSD.org","threadId":"40268","inReplyTo":null,"subject":"[PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"","fromEmail":"garga@freebsd.org","sentAt":"2015-09-03T19:46:44Z","receivedAt":"2015-09-03T19:46:44Z","isPatch":true,"sender":{"key":"garga@freebsd.org","avatar":"https://gravatar.com/avatar/695c68fb2f0629998c430204a7212aec683a3f87ec5eeaae236fd2376e790bfc?d=mp&s=160"},"body":"From: Renato Botelho <garga@FreeBSD.org>\n\ngit-submodule and git-request-pull are written in sh but use perl\ninternally. Add them to be replaced by unimplemented.sh when NO_PERL\nflag is set\n\nSigned-off-by: Renato Botelho <garga@FreeBSD.org>\n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex e326fa0..4dae0ec 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1795,7 +1795,7 @@ git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES\n \tchmod +x $@+ && \\\n \tmv $@+ $@\n else # NO_PERL\n-$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh\n+$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-request-pull: % : unimplemented.sh\n \t$(QUIET_GEN)$(RM) $@ $@+ && \\\n \tsed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \\\n \t    -e 's|@@REASON@@|NO_PERL=$(NO_PERL)|g' \\\n-- \n2.5.1\n"},{"id":"269361","messageId":"xmqqy4gni819.fsf@gitster.mtv.corp.google.com","threadId":"40268","inReplyTo":"1441309604-91875-1-git-send-email-garga@FreeBSD.org","subject":"Re: [PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-03T20:04:34Z","receivedAt":"2015-09-03T20:04:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"garga@FreeBSD.org writes:\n\n> From: Renato Botelho <garga@FreeBSD.org>\n>\n> git-submodule and git-request-pull are written in sh but use perl\n> internally. Add them to be replaced by unimplemented.sh when NO_PERL\n> flag is set\n>\n> Signed-off-by: Renato Botelho <garga@FreeBSD.org>\n> ---\n>  Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index e326fa0..4dae0ec 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1795,7 +1795,7 @@ git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES\n>  \tchmod +x $@+ && \\\n>  \tmv $@+ $@\n>  else # NO_PERL\n> -$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh\n> +$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-request-pull: % : unimplemented.sh\n>  \t$(QUIET_GEN)$(RM) $@ $@+ && \\\n>  \tsed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \\\n>  \t    -e 's|@@REASON@@|NO_PERL=$(NO_PERL)|g' \\\n\nThanks, but this I suspect is insufficient.  In the pre-context of\nyour patch, you can see we have a rule to create git-instaweb when\nNO_PERL is not in effect, so either way, we only have one rule to\ncreate git-instaweb.\n\nYou are not disabling the rule to create the real git-submodule\nand git-request-pull when NO_PERL is in effect with this patch,\nwithout it, 'make' cannot tell which variant of git-submodule and\ngit-request-pull needs to be built.\n\nI agree replacing commands with unimplemented may be a good thing; I\ndo not object to the goal of the patch.  But hopefully you now see\nwhy it is too late to start discussing it with 2.6 as the goal.\n"}]}