{"thread":{"id":"40264","subject":"[PATCH] Remove perl dependant commands if NO_PERL is set","startedAt":"2015-09-03T16:35:47Z","lastAt":"2015-09-03T20:15:20Z","messageCount":6,"participants":["garga@freebsd.org","Junio C Hamano","Renato Botelho"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"269336","messageId":"1441298147-83601-1-git-send-email-garga@FreeBSD.org","threadId":"40264","inReplyTo":null,"subject":"[PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"","fromEmail":"garga@freebsd.org","sentAt":"2015-09-03T16:35:47Z","receivedAt":"2015-09-03T16:35:47Z","isPatch":true,"sender":{"key":"garga@freebsd.org","avatar":"https://gravatar.com/avatar/695c68fb2f0629998c430204a7212aec683a3f87ec5eeaae236fd2376e790bfc?d=mp&s=160"},"body":"From: Renato Botelho \n\ngit-submodule and git-request-pull are written in sh but use perl\ninternally. Add them to be replaced by unimplemented.sh when NO_PERL\nflag is set\n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex e326fa0..4dae0ec 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1795,7 +1795,7 @@ git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES\n \tchmod +x $@+ && \\\n \tmv $@+ $@\n else # NO_PERL\n-$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh\n+$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-request-pull: % : unimplemented.sh\n \t$(QUIET_GEN)$(RM) $@ $@+ && \\\n \tsed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \\\n \t -e 's|@@REASON@@|NO_PERL=$(NO_PERL)|g' \\\n-- \n2.5.1\n"},{"id":"269351","messageId":"xmqq7fo7jp1e.fsf@gitster.mtv.corp.google.com","threadId":"40264","inReplyTo":"1441298147-83601-1-git-send-email-garga@FreeBSD.org","subject":"Re: [PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-03T19:11:57Z","receivedAt":"2015-09-03T19:11:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"garga@FreeBSD.org writes:\n\n> From: Renato Botelho \n>\n> git-submodule and git-request-pull are written in sh but use perl\n> internally. Add them to be replaced by unimplemented.sh when NO_PERL\n> flag is set\n> ---\n\nMissing sign-off.\n\nYou also may want to hold off the \"git-submodule\" bit, as I expect\nhttp://thread.gmane.org/gmane.comp.version-control.git/277128/focus=277129\nwould be one of the first changes to be in 'master' after the\nupcoming release 2.6 (that is, it is likely that perl dependency\nwould be removed in 2.7).\n\n> Makefile | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index e326fa0..4dae0ec 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1795,7 +1795,7 @@ git-instaweb: git-instaweb.sh GIT-SCRIPT-DEFINES\n> \tchmod +x $@+ && \\\n> \tmv $@+ $@\n> else # NO_PERL\n> -$(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh\n> +$(SCRIPT_PERL_GEN) git-instaweb git-submodule git-request-pull: % : unimplemented.sh\n> \t$(QUIET_GEN)$(RM) $@ $@+ && \\\n> \tsed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \\\n> \t -e 's|@@REASON@@|NO_PERL=$(NO_PERL)|g' \\\n"},{"id":"269354","messageId":"2CFFD89E-7059-4C1C-B715-15C5F6C2D295@FreeBSD.org","threadId":"40264","inReplyTo":"xmqq7fo7jp1e.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"Renato Botelho","fromEmail":"garga@freebsd.org","sentAt":"2015-09-03T19:39:19Z","receivedAt":"2015-09-03T19:39:19Z","isPatch":true,"sender":{"key":"garga@freebsd.org","avatar":"https://gravatar.com/avatar/695c68fb2f0629998c430204a7212aec683a3f87ec5eeaae236fd2376e790bfc?d=mp&s=160"},"body":"> On Sep 3, 2015, at 16:11, Junio C Hamano wrote:\n> \n> garga@FreeBSD.org writes:\n> \n>> From: Renato Botelho \n>> \n>> git-submodule and git-request-pull are written in sh but use perl\n>> internally. Add them to be replaced by unimplemented.sh when NO_PERL\n>> flag is set\n>> ---\n> \n> Missing sign-off.\n> \n> You also may want to hold off the \"git-submodule\" bit, as I expect\n> http://thread.gmane.org/gmane.comp.version-control.git/277128/focus=277129\n> would be one of the first changes to be in 'master' after the\n> upcoming release 2.6 (that is, it is likely that perl dependency\n> would be removed in 2.7).\n\nCan’t we add git-submodule to the list now, for 2.6, and then remove it when this change is pushed? This would help to have a sane tarball for 2.6. I’m considering this from a package maintainer perspective.\n\nI’ll re-send it with sign-off.\n--\nRenato Botelho\n"},{"id":"269357","messageId":"xmqq37yvjmza.fsf@gitster.mtv.corp.google.com","threadId":"40264","inReplyTo":"2CFFD89E-7059-4C1C-B715-15C5F6C2D295@FreeBSD.org","subject":"Re: [PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-03T19:56:25Z","receivedAt":"2015-09-03T19:56:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Renato Botelho writes:\n\n>> You also may want to hold off the \"git-submodule\" bit, as I expect\n>> http://thread.gmane.org/gmane.comp.version-control.git/277128/focus=277129\n>> would be one of the first changes to be in 'master' after the\n>> upcoming release 2.6 (that is, it is likely that perl dependency\n>> would be removed in 2.7).\n>\n> Can’t we add git-submodule to the list now, for 2.6, and then remove\n> it when this change is pushed? This would help to have a sane tarball\n> for 2.6. I’m considering this from a package maintainer perspective.\n\nNot really. Anything brand-new that comes this late in the cycle\nwill not be in 2.6, so the earliest release this NO_PERL change can\nappear in is one after the upcoming release.\n"},{"id":"269359","messageId":"86C44806-98FB-4E67-83DF-197103B48BB2@FreeBSD.org","threadId":"40264","inReplyTo":"xmqq37yvjmza.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"Renato Botelho","fromEmail":"garga@freebsd.org","sentAt":"2015-09-03T20:02:38Z","receivedAt":"2015-09-03T20:02:38Z","isPatch":true,"sender":{"key":"garga@freebsd.org","avatar":"https://gravatar.com/avatar/695c68fb2f0629998c430204a7212aec683a3f87ec5eeaae236fd2376e790bfc?d=mp&s=160"},"body":"> On Sep 3, 2015, at 16:56, Junio C Hamano wrote:\n> \n> Renato Botelho writes:\n> \n>>> You also may want to hold off the \"git-submodule\" bit, as I expect\n>>> http://thread.gmane.org/gmane.comp.version-control.git/277128/focus=277129\n>>> would be one of the first changes to be in 'master' after the\n>>> upcoming release 2.6 (that is, it is likely that perl dependency\n>>> would be removed in 2.7).\n>> \n>> Can’t we add git-submodule to the list now, for 2.6, and then remove\n>> it when this change is pushed? This would help to have a sane tarball\n>> for 2.6. I’m considering this from a package maintainer perspective.\n> \n> Not really. Anything brand-new that comes this late in the cycle\n> will not be in 2.6, so the earliest release this NO_PERL change can\n> appear in is one after the upcoming release.\n\nEven if it’s a bug that produce a broken installation?\n\nNevermind, I’ll add the patch into FreeBSD ports so FreeBSD users can have a sane package installed.\n\n--\nRenato Botelho\n"},{"id":"269363","messageId":"xmqqr3mfi7jb.fsf@gitster.mtv.corp.google.com","threadId":"40264","inReplyTo":"86C44806-98FB-4E67-83DF-197103B48BB2@FreeBSD.org","subject":"Re: [PATCH] Remove perl dependant commands if NO_PERL is set","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-03T20:15:20Z","receivedAt":"2015-09-03T20:15:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Renato Botelho writes:\n\n>> Not really. Anything brand-new that comes this late in the cycle\n>> will not be in 2.6, so the earliest release this NO_PERL change can\n>> appear in is one after the upcoming release.\n>\n> Even if it’s a bug that produce a broken installation?\n\nAbsolutely.\n\nThe way we do things around here is to do new features early in the\ncycle before -rc0, fixes to pre-existing bugs before -rc1 and after\nthat we go to regression fixes only until the final. And use of\nPerl in submodule or request-pull is anything new in 2.6, I think.\n\nThis is a fix to pre-existing issue, and I haven't tagged -rc1 yet,\nbut speaking from experience, anything that I can poke a hole after\nstaring at it for only 20 seconds (see my other message about this\npatch defining two different ways to build the same thing) has a\nhigh chance of having other issues that will hurt other people in a\nway other than the trivial \"staring at it for 20-second\" issue,\nwhich would introduce a real regression.\n\nBetween an unknown regression and a known longstanding bug, we tend\nto take the latter.\n\n> Nevermind, I’ll add the patch into FreeBSD ports so FreeBSD users can\n> have a sane package installed.\n\nSure. That would help in the long term, as it will result in a\nwell-cooked fix in 2.7; by that time hopefully the 'submodule' bit\nwould not be necessary, but request-pull may still be using Perl.\n"}]}