{"thread":{"id":"4015","subject":"[PATCH] repack: honor -d even when no new pack was created","startedAt":"2006-05-01T10:57:48Z","lastAt":"2006-05-01T10:57:48Z","messageCount":1,"participants":["Martin Waitz"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"19324","messageId":"20060501105748.GE20847@admingilde.org","threadId":"4015","inReplyTo":null,"subject":"[PATCH] repack: honor -d even when no new pack was created","fromName":"Martin Waitz","fromEmail":"tali@admingilde.org","sentAt":"2006-05-01T10:57:48Z","receivedAt":"2006-05-01T10:57:48Z","isPatch":true,"sender":{"key":"tali@admingilde.org","avatar":"https://gravatar.com/avatar/3f89b03eee362187effabe257898735b475673a12265c398ea9161259ae91553?d=mp&s=160"},"body":"If all objects are reachable via an alternate object store then we\nstill have to remove all obsolete local packs.\n\nSigned-off-by: Martin Waitz <tali@admingilde.org>\n\n---\n\nWithout this patch I got the following behaviour:\n\n\".git/objects/info/alternates\" [Neu] 1L, 38C geschrieben\nadmingilde:~/src/linux-2.6 > git count-objects\n107852 objects, 665596 kilobytes\nadmingilde:~/src/linux-2.6 > git repack -a -l -d\nGenerating pack...\nDone counting 0 objects.\nNothing new to pack.\nadmingilde:~/src/linux-2.6 > git prune\nadmingilde:~/src/linux-2.6 > git count-objects\n0 objects, 0 kilobytes\nadmingilde:~/src/linux-2.6 > ls .git/objects/pack\npack-b3c6fbdfa36a326815de6358885c7a570a986b1b.idx\npack-b3c6fbdfa36a326815de6358885c7a570a986b1b.pack\npack-e0d76ffe354ef5665028a6cb4506ea902f72e1d0.idx\npack-e0d76ffe354ef5665028a6cb4506ea902f72e1d0.pack\n\nAfter changing git-repack, objects/pack was empty, as expected.\n\n git-repack.sh |   14 +++++++-------\n 1 files changed, 7 insertions(+), 7 deletions(-)\n\nc58513fa76e10007fdf15b49a593a2b9c6a080be\ndiff --git a/git-repack.sh b/git-repack.sh\nindex e0c9f32..4fb3f26 100755\n--- a/git-repack.sh\n+++ b/git-repack.sh\n@@ -48,15 +48,15 @@ name=$(git-rev-list --objects --all $rev\n \texit 1\n if [ -z \"$name\" ]; then\n \techo Nothing new to pack.\n-\texit 0\n-fi\n-echo \"Pack pack-$name created.\"\n+else\n+\techo \"Pack pack-$name created.\"\n \n-mkdir -p \"$PACKDIR\" || exit\n+\tmkdir -p \"$PACKDIR\" || exit\n \n-mv .tmp-pack-$name.pack \"$PACKDIR/pack-$name.pack\" &&\n-mv .tmp-pack-$name.idx  \"$PACKDIR/pack-$name.idx\" ||\n-exit\n+\tmv .tmp-pack-$name.pack \"$PACKDIR/pack-$name.pack\" &&\n+\tmv .tmp-pack-$name.idx  \"$PACKDIR/pack-$name.idx\" ||\n+\texit\n+fi\n \n if test \"$remove_redundant\" = t\n then\n-- \n1.3.1.g8971-dirty\n\n\n-- \nMartin Waitz\n"}]}