{"thread":{"id":"4007","subject":"Re: More qgit defects","startedAt":"2006-04-30T10:13:22Z","lastAt":"2006-05-01T02:20:35Z","messageCount":2,"participants":["Marco Costalba","Pavel Roskin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"19281","messageId":"e5bfff550604300313n5ebe84f7nf42c88789efe1@mail.gmail.com","threadId":"4007","inReplyTo":"1146390144.13634.9.camel@dv","subject":"Re: More qgit defects","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-04-30T10:13:22Z","receivedAt":"2006-04-30T10:13:22Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 4/30/06, Pavel Roskin <proski@gnu.org> wrote:\n> On Sun, 2006-04-30 at 05:26 -0400, Pavel Roskin wrote:\n> > No, something still feels wrong.  I think even the gurus of GUI cannot\n> > decide what to do if many frames need to be on screen.  Do you know that\n> > many graphic designers hate GIMP for the overuse of dockable toplevel\n> > windows?  Krita prefers dockable frames.  Photoshop uses non-dockable\n> > child windows, I believe.\n> >\n> > The difference for qgit is that is generally wants bigger windows.\n> > Whether the revision tree or the patch, having more space allows the\n> > frame to present a better picture to the users.\n>\n> Replying to myself, sorry.  How about tabs?\n>\n> One tab for the main view.  Basically what we have now.\n>\n> Then tabs for revisions.  We can have more than one revision open, with\n> the comment and with the patch, and and with affected files.  They will\n> have the GUI centered on the change made by the revision.  StGIT commits\n> would have an editable comment.\n>\n> Then tabs for files.  Again, possibly more than one.  Each tab about a\n> specific file.  The file history, annotations, maybe even an editor for\n> the file.\n>\n> The idea was inspired by Azureus.\n>\n\nThrowing in the tabs is a *very* big change, but, just to discuss....I\nagree on the note that in qgit we have three different approaches:\nfixed frames (revisions, file tree, affected files), detachable frames\n(patch) and separate windows (annotations).\n\nThis is a bit strange and could give an odd GUI feeling.\n\nI like the tab idea because it's clear and simple and fixes the 'many\napproaches' problem. What I would suggest is, at least at first step,\ndo not change the main view and have only three tabs:\n\nTab1: Main view with revisions, file tree (hide able), affected files.\nTab2: Patch view with patch stat and diffs\nTab3: File history + file content/annotation view\n\nIn other words just put the frames/windows as are now in browse able\ntabs. In this way main view still gives a good amount of information\nwithout requiring changing the tab and the tabs are reserved for 'big\nspace' needed infos only.\n\n\n   Marco\n"},{"id":"19316","messageId":"1146450035.7879.26.camel@dv","threadId":"4007","inReplyTo":"e5bfff550604300313n5ebe84f7nf42c88789efe1@mail.gmail.com","subject":"Re: More qgit defects","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-05-01T02:20:35Z","receivedAt":"2006-05-01T02:20:35Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello, Marco!\n\nOn Sun, 2006-04-30 at 12:13 +0200, Marco Costalba wrote:\n> Throwing in the tabs is a *very* big change, but, just to discuss....I\n> agree on the note that in qgit we have three different approaches:\n> fixed frames (revisions, file tree, affected files), detachable frames\n> (patch) and separate windows (annotations).\n> \n> This is a bit strange and could give an odd GUI feeling.\n\nAgreed.\n\n> I like the tab idea because it's clear and simple and fixes the 'many\n> approaches' problem.\n\nI'm glad you liked my idea!  And thank you for copying to the list.\nqgit is meant for most git users, and they should have their voices\nheard.\n\n> What I would suggest is, at least at first step,\n> do not change the main view and have only three tabs:\n> \n> Tab1: Main view with revisions, file tree (hide able), affected files.\n> Tab2: Patch view with patch stat and diffs\n> Tab3: File history + file content/annotation view\n\nAbsolutely.  It's easier to make changes incrementally than to rewrite\neverything and hunt bugs for months.  This change alone would make it\neasier to work with qgit.\n\nOnce qgit can deal with more than one patch view and more than one file\nview, this would provide the fix for qgit's \"jumpiness\".  Mere selection\nof objects in listboxes shouldn't affect other tabs.\n\n> In other words just put the frames/windows as are now in browse able\n> tabs. In this way main view still gives a good amount of information\n> without requiring changing the tab and the tabs are reserved for 'big\n> space' needed infos only.\n\nThat would be great.  I'm eagerly waiting for new commits to test :-)\n\n-- \nRegards,\nPavel Roskin\n"}]}