{"thread":{"id":"40060","subject":"[PATCH ee/clean-remove-dirs] t7300-clean: require POSIXPERM for chmod 0 test","startedAt":"2015-08-11T20:29:48Z","lastAt":"2015-08-11T22:17:17Z","messageCount":2,"participants":["Johannes Sixt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"267859","messageId":"55CA5B3C.3010903@kdbg.org","threadId":"40060","inReplyTo":null,"subject":"[PATCH ee/clean-remove-dirs] t7300-clean: require POSIXPERM for chmod 0 test","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2015-08-11T20:29:48Z","receivedAt":"2015-08-11T20:29:48Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"A test case introduced by 91479b9c (t7300: add tests to document\nbehavior of clean and nested git) uses 'chmod 0' to verify that a\nsubdirectory that has an unreadable .git file is not removed. This can\nwork only when the system pays attention to the permissions set with\n'chmod'. Therefore, set the POSIXPERM prerequisite on the test case.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n This fixes a new failure in the test suite (t3404.8[67]) on Windows, but\n I got around to debug it only now.\n\n t/t7300-clean.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7300-clean.sh b/t/t7300-clean.sh\nindex 32e96da..27557d6 100755\n--- a/t/t7300-clean.sh\n+++ b/t/t7300-clean.sh\n@@ -499,7 +499,7 @@ test_expect_success 'should not clean submodules' '\n \ttest_path_is_missing to_clean\n '\n \n-test_expect_success 'should avoid cleaning possible submodules' '\n+test_expect_success POSIXPERM 'should avoid cleaning possible submodules' '\n \trm -fr to_clean possible_sub1 &&\n \tmkdir to_clean possible_sub1 &&\n \ttest_when_finished \"rm -rf possible_sub*\" &&\n-- \n2.3.2.245.gb5bf9d3\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"Git for Windows\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"267874","messageId":"xmqqpp2to4gi.fsf@gitster.dls.corp.google.com","threadId":"40060","inReplyTo":"55CA5B3C.3010903@kdbg.org","subject":"Re: [PATCH ee/clean-remove-dirs] t7300-clean: require POSIXPERM for chmod 0 test","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-08-11T22:17:17Z","receivedAt":"2015-08-11T22:17:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"Git for Windows\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"}]}