{"thread":{"id":"40027","subject":"[PATCH] sha1_file.c: fix a declaration-after-statement","startedAt":"2015-08-06T09:53:41Z","lastAt":"2015-08-06T10:08:31Z","messageCount":2,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"267566","messageId":"55C32EA5.2010302@ramsay1.demon.co.uk","threadId":"40027","inReplyTo":null,"subject":"[PATCH] sha1_file.c: fix a declaration-after-statement","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2015-08-06T09:53:41Z","receivedAt":"2015-08-06T09:53:41Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Junio,\n\nSorry for this hit-n-run patch, but I'm in a hurry ... :-D\nCould you please squash this (or something like it) into\nthe relevant patch; Thanks!\n\n[I noticed this simply because I have '-Wdeclaration-after-statement'\nand '-Werror' (among others) set in CFLAGS (via config.mak).]\n\nHTH\n\nATB,\nRamsay Jones\n\n sha1_file.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/sha1_file.c b/sha1_file.c\nindex 43386a8..a0af574 100644\n--- a/sha1_file.c\n+++ b/sha1_file.c\n@@ -1462,8 +1462,9 @@ int git_open_noatime(const char *name)\n \tstatic int sha1_file_open_flag = O_NOATIME;\n \n \tfor (;;) {\n+\t\tint fd;\n \t\terrno = 0;\n-\t\tint fd = open(name, O_RDONLY | sha1_file_open_flag);\n+\t\tfd = open(name, O_RDONLY | sha1_file_open_flag);\n \t\tif (fd >= 0)\n \t\t\treturn fd;\n \n-- \n2.5.0\n"},{"id":"267567","messageId":"55C3321F.5080801@ramsay1.demon.co.uk","threadId":"40027","inReplyTo":"55C32EA5.2010302@ramsay1.demon.co.uk","subject":"Re: [PATCH] sha1_file.c: fix a declaration-after-statement","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2015-08-06T10:08:31Z","receivedAt":"2015-08-06T10:08:31Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"On 06/08/15 10:53, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n> \n> Hi Junio,\n> \n> Sorry for this hit-n-run patch, but I'm in a hurry ... :-D\n> Could you please squash this (or something like it) into\n> the relevant patch; Thanks!\n\nAh, I've just read your 'What's Cooking' email and I see that\nyou are already aware of this.\n\nSorry for the noise!\n\nATB,\nRamsay Jones\n\n> \n> [I noticed this simply because I have '-Wdeclaration-after-statement'\n> and '-Werror' (among others) set in CFLAGS (via config.mak).]\n> \n> HTH\n> \n> ATB,\n> Ramsay Jones\n> \n>  sha1_file.c | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/sha1_file.c b/sha1_file.c\n> index 43386a8..a0af574 100644\n> --- a/sha1_file.c\n> +++ b/sha1_file.c\n> @@ -1462,8 +1462,9 @@ int git_open_noatime(const char *name)\n>  \tstatic int sha1_file_open_flag = O_NOATIME;\n>  \n>  \tfor (;;) {\n> +\t\tint fd;\n>  \t\terrno = 0;\n> -\t\tint fd = open(name, O_RDONLY | sha1_file_open_flag);\n> +\t\tfd = open(name, O_RDONLY | sha1_file_open_flag);\n>  \t\tif (fd >= 0)\n>  \t\t\treturn fd;\n>  \n> \n"}]}