{"thread":{"id":"3998","subject":"Features ask for git-send-email","startedAt":"2006-04-29T13:30:20Z","lastAt":"2006-05-02T23:51:36Z","messageCount":8,"participants":["Bertrand Jacquin","David Woodhouse","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"19251","messageId":"4fb292fa0604290630r19edd7ejf88642e33b350d1d@mail.gmail.com","threadId":"3998","inReplyTo":null,"subject":"Features ask for git-send-email","fromName":"Bertrand Jacquin","fromEmail":"beber.mailing@gmail.com","sentAt":"2006-04-29T13:30:20Z","receivedAt":"2006-04-29T13:30:20Z","isPatch":false,"sender":{"key":"beber.mailing@gmail.com","avatar":null},"body":"Hi,\n\nCould it be possible to add a features in git-send-email.perl to\naccept a differrent charset as iso-8859-1 ? I would like to send\nfr_FR.utf8 mail as I use git to manager a latex files tree which are\nwritten in utf8.\n\nAny objection ?\n\n--\nBeber\n#e.fr@freenode\n"},{"id":"19364","messageId":"1146573417.14059.21.camel@pmac.infradead.org","threadId":"3998","inReplyTo":"4fb292fa0604290630r19edd7ejf88642e33b350d1d@mail.gmail.com","subject":"Re: Features ask for git-send-email","fromName":"David Woodhouse","fromEmail":"dwmw2@infradead.org","sentAt":"2006-05-02T12:36:57Z","receivedAt":"2006-05-02T12:36:57Z","isPatch":false,"sender":{"key":"dwmw2@infradead.org","avatar":"https://gravatar.com/avatar/7afd4f07e0cf7d7e046ae2d23678296b37777c96488e6f3451e78a5514154ebd?d=mp&s=160"},"body":"On Sat, 2006-04-29 at 15:30 +0200, Bertrand Jacquin wrote:\n> Could it be possible to add a features in git-send-email.perl to\n> accept a differrent charset as iso-8859-1 ? I would like to send\n> fr_FR.utf8 mail as I use git to manager a latex files tree which are\n> written in utf8.\n> \n> Any objection ?\n\nSeems reasonable. I think we just forgot to include the Content-Type:\nheader. This fixes it...\n\nSigned-off-by: David Woodhouse <dwmw2@infradead.org>\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex ecfa347..1df75f5 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -37,7 +37,7 @@ # Constants (essentially)\n my $compose_filename = \".msg.$$\";\n \n # Variables we fill in automatically, or via prompting:\n-my (@to,@cc,@initial_cc,$initial_reply_to,$initial_subject,@files,$from,$compose,$time);\n+my (@to,@cc,@initial_cc,$initial_reply_to,$initial_subject,@files,$from,$compose,$time,$charset);\n \n # Behavior modification variables\n my ($chain_reply_to, $smtp_server, $quiet, $suppress_from, $no_signed_off_cc) = (1, \"localhost\", 0, 0, 0);\n@@ -58,6 +58,7 @@ my $rc = GetOptions(\"from=s\" => \\$from,\n \t\t    \"chain-reply-to!\" => \\$chain_reply_to,\n \t\t    \"smtp-server=s\" => \\$smtp_server,\n \t\t    \"compose\" => \\$compose,\n+\t\t    \"charset=s\" => \\$charset,\n \t\t    \"quiet\" => \\$quiet,\n \t\t    \"suppress-from\" => \\$suppress_from,\n \t\t    \"no-signed-off-cc|no-signed-off-by-cc\" => \\$no_signed_off_cc,\n@@ -135,6 +136,10 @@ if (!defined $smtp_server) {\n \t$smtp_server = \"localhost\";\n }\n \n+if (!defined $charset) {\n+\t$charset = \"UTF-8\";\n+}\n+\n if ($compose) {\n \t# Note that this does not need to be secure, but we will make a small\n \t# effort to have it be unique\n@@ -214,6 +219,9 @@ Options:\n    --cc           Specify an initial \"Cc:\" list for the entire series\n                   of emails.\n \n+   --charset      Specify a character set, if legacy character sets are\n+                  used in change logs instead of UTF-8.\n+\n    --compose      Use \\$EDITOR to edit an introductory message for the\n                   patch series.\n \n@@ -299,6 +307,7 @@ Subject: $subject\n Reply-To: $from\n Date: $date\n Message-Id: $message_id\n+Content-Type: text/plain; charset=$charset\n X-Mailer: git-send-email @@GIT_VERSION@@\n \";\n \t$header .= \"In-Reply-To: $reply_to\\n\" if $reply_to;\n\n-- \ndwmw2\n"},{"id":"19366","messageId":"e37km0$vav$1@sea.gmane.org","threadId":"3998","inReplyTo":"1146573417.14059.21.camel@pmac.infradead.org","subject":"Re: Features ask for git-send-email","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-05-02T12:53:15Z","receivedAt":"2006-05-02T12:53:15Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"David Woodhouse wrote:\n\n> On Sat, 2006-04-29 at 15:30 +0200, Bertrand Jacquin wrote:\n>> Could it be possible to add a features in git-send-email.perl to\n>> accept a differrent charset as iso-8859-1 ? I would like to send\n>> fr_FR.utf8 mail as I use git to manager a latex files tree which are\n>> written in utf8.\n>> \n>> Any objection ?\n> \n> Seems reasonable. I think we just forgot to include the Content-Type:\n> header. This fixes it...\n\nDoesn't \n        Content-Type: text/plain; charset=$charset\nheader need also\n        MIME-Version: 1.0\n\n-- \nJakub Narebski\nWarsaw, Poland\n"},{"id":"19368","messageId":"1146579255.17934.8.camel@pmac.infradead.org","threadId":"3998","inReplyTo":"e37km0$vav$1@sea.gmane.org","subject":"Re: Features ask for git-send-email","fromName":"David Woodhouse","fromEmail":"dwmw2@infradead.org","sentAt":"2006-05-02T14:14:15Z","receivedAt":"2006-05-02T14:14:15Z","isPatch":false,"sender":{"key":"dwmw2@infradead.org","avatar":"https://gravatar.com/avatar/7afd4f07e0cf7d7e046ae2d23678296b37777c96488e6f3451e78a5514154ebd?d=mp&s=160"},"body":"On Tue, 2006-05-02 at 14:53 +0200, Jakub Narebski wrote:\n> Doesn't \n>         Content-Type: text/plain; charset=$charset\n> header need also\n>         MIME-Version: 1.0 \n\nMaybe. The use of Content-Type: actually predates RFC2045, and if we\ninclude a MIME-Version header then we should make 100% sure that we also\nconform to the rest of RFC2045, which I hadn't actually looked at. In\nparticular, we should take care of Content-Transfer-Encoding.\n\nI'd prefer to leave MIME-Version out for now, I think.\n\n-- \ndwmw2\n"},{"id":"19371","messageId":"e37u5r$4pi$1@sea.gmane.org","threadId":"3998","inReplyTo":"1146579255.17934.8.camel@pmac.infradead.org","subject":"Re: Features ask for git-send-email","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-05-02T15:35:18Z","receivedAt":"2006-05-02T15:35:18Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"David Woodhouse wrote:\n\n> On Tue, 2006-05-02 at 14:53 +0200, Jakub Narebski wrote:\n>> Doesn't\n>>         Content-Type: text/plain; charset=$charset\n>> header need also\n>>         MIME-Version: 1.0\n> \n> Maybe. The use of Content-Type: actually predates RFC2045, and if we\n> include a MIME-Version header then we should make 100% sure that we also\n> conform to the rest of RFC2045, which I hadn't actually looked at. In\n> particular, we should take care of Content-Transfer-Encoding.\n> \n> I'd prefer to leave MIME-Version out for now, I think.\n\nIf I remember correctly _some_ mail applications or news (Usenet) agents \ndid not respect Content-Type without MIME-Version, I think according to \nstandard. Perhaps that have changed.\n\nAs to the other MIME header:\n        Content-Transfer-Encoding: 8bit\n\n-- \nJakub Narebski\nWarsaw, Poland\n"},{"id":"19382","messageId":"4fb292fa0605021546i45c740c4i42c64125b8c560e@mail.gmail.com","threadId":"3998","inReplyTo":"1146573417.14059.21.camel@pmac.infradead.org","subject":"Re: Features ask for git-send-email","fromName":"Bertrand Jacquin","fromEmail":"beber.mailing@gmail.com","sentAt":"2006-05-02T22:46:24Z","receivedAt":"2006-05-02T22:46:24Z","isPatch":false,"sender":{"key":"beber.mailing@gmail.com","avatar":null},"body":"On 5/2/06, David Woodhouse <dwmw2@infradead.org> wrote:\n> On Sat, 2006-04-29 at 15:30 +0200, Bertrand Jacquin wrote:\n> > Could it be possible to add a features in git-send-email.perl to\n> > accept a differrent charset as iso-8859-1 ? I would like to send\n> > fr_FR.utf8 mail as I use git to manager a latex files tree which are\n> > written in utf8.\n> >\n> > Any objection ?\n>\n> Seems reasonable. I think we just forgot to include the Content-Type:\n> header. This fixes it...\n\nI tryed it. I used this patch again master git git release\n\nAnd I got the following with git-send-email :\n\nUse of uninitialized value in hash element at /usr/bin/git-send-email line 437.\nUse of uninitialized value in hash element at /usr/bin/git-send-email line 437.\n<>: missing or malformed local part\nUse of uninitialized value in hash element at /usr/bin/git-send-email line 437.\nUse of uninitialized value in hash element at /usr/bin/git-send-email line 437.\n<>: missing or malformed local part\n\nAnd with my smtp server :\n\n2006-05-03 00:44:01 unexpected disconnection while reading SMTP\ncommand from localhost (localhost.localdomain) [127.0.0.1]\n\nIs it a known bug ? I can't send mail with patch thow :/ I tried to\nadd Mime-Version: 1.0 too but I got the sam.\n\n--\nBeber\n#e.fr@freenode\n"},{"id":"19388","messageId":"1146612793.19101.50.camel@pmac.infradead.org","threadId":"3998","inReplyTo":"4fb292fa0605021546i45c740c4i42c64125b8c560e@mail.gmail.com","subject":"Re: Features ask for git-send-email","fromName":"David Woodhouse","fromEmail":"dwmw2@infradead.org","sentAt":"2006-05-02T23:33:13Z","receivedAt":"2006-05-02T23:33:13Z","isPatch":false,"sender":{"key":"dwmw2@infradead.org","avatar":"https://gravatar.com/avatar/7afd4f07e0cf7d7e046ae2d23678296b37777c96488e6f3451e78a5514154ebd?d=mp&s=160"},"body":"On Wed, 2006-05-03 at 00:46 +0200, Bertrand Jacquin wrote:\n> I tryed it. I used this patch again master git git release\n> \n> And I got the following with git-send-email :\n> \n> Use of uninitialized value in hash element at /usr/bin/git-send-email line 437.\n> Use of uninitialized value in hash element at /usr/bin/git-send-email line 437.\n> <>: missing or malformed local part \n\nInteresting; it worked for me. Does the same happen _without_ the patch\napplied?\n\n-- \ndwmw2\n"},{"id":"19392","messageId":"4fb292fa0605021651y1e0cbb69w7f34257bacca716f@mail.gmail.com","threadId":"3998","inReplyTo":"1146612793.19101.50.camel@pmac.infradead.org","subject":"Re: Features ask for git-send-email","fromName":"Bertrand Jacquin","fromEmail":"beber.mailing@gmail.com","sentAt":"2006-05-02T23:51:36Z","receivedAt":"2006-05-02T23:51:36Z","isPatch":false,"sender":{"key":"beber.mailing@gmail.com","avatar":null},"body":"On 5/3/06, David Woodhouse <dwmw2@infradead.org> wrote:\n> On Wed, 2006-05-03 at 00:46 +0200, Bertrand Jacquin wrote:\n> > I tryed it. I used this patch again master git git release\n> >\n> > And I got the following with git-send-email :\n> >\n> > Use of uninitialized value in hash element at /usr/bin/git-send-email line 437.\n> > Use of uninitialized value in hash element at /usr/bin/git-send-email line 437.\n> > <>: missing or malformed local part\n>\n> Interesting; it worked for me. Does the same happen _without_ the patch\n> applied?\n\nIt appear without in 1.3.1 and I can't seed mail with too.\nAlso, 1.2.4 work fine here (without patch).\n\nI don't make any test for other version (too tired for now).\n\nI use exim 4.60 as SMTP server (if it can help).\n\n--\nBeber\n#e.fr@freenode\n"}]}