{"thread":{"id":"39830","subject":"[PATCH] p5310: mend broken &&-chain","startedAt":"2015-07-10T20:40:57Z","lastAt":"2015-07-11T00:50:00Z","messageCount":3,"participants":["René Scharfe","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"266000","messageId":"55A02DD9.3020909@web.de","threadId":"39830","inReplyTo":null,"subject":"[PATCH] p5310: mend broken &&-chain","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2015-07-10T20:40:57Z","receivedAt":"2015-07-10T20:40:57Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Signed-off-by: Rene Scharfe <l.s.r@web.de>\n---\nGIT_TEST_CHAIN_LINT complains about the missing &&s and is enabled\nby default now.\n\n t/perf/p5310-pack-bitmaps.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/perf/p5310-pack-bitmaps.sh b/t/perf/p5310-pack-bitmaps.sh\nindex f8ed857..de2a224 100755\n--- a/t/perf/p5310-pack-bitmaps.sh\n+++ b/t/perf/p5310-pack-bitmaps.sh\n@@ -39,14 +39,14 @@ test_expect_success 'create partial bitmap state' '\n \n \t# now kill off all of the refs and pretend we had\n \t# just the one tip\n-\trm -rf .git/logs .git/refs/* .git/packed-refs\n-\tgit update-ref HEAD $cutoff\n+\trm -rf .git/logs .git/refs/* .git/packed-refs &&\n+\tgit update-ref HEAD $cutoff &&\n \n \t# and then repack, which will leave us with a nice\n \t# big bitmap pack of the \"old\" history, and all of\n \t# the new history will be loose, as if it had been pushed\n \t# up incrementally and exploded via unpack-objects\n-\tgit repack -Ad\n+\tgit repack -Ad &&\n \n \t# and now restore our original tip, as if the pushes\n \t# had happened\n-- \n2.4.4\n"},{"id":"266001","messageId":"20150710205029.GA1181@peff.net","threadId":"39830","inReplyTo":"55A02DD9.3020909@web.de","subject":"Re: [PATCH] p5310: mend broken &&-chain","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-07-10T20:50:29Z","receivedAt":"2015-07-10T20:50:29Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jul 10, 2015 at 10:40:57PM +0200, René Scharfe wrote:\n\n> diff --git a/t/perf/p5310-pack-bitmaps.sh b/t/perf/p5310-pack-bitmaps.sh\n> index f8ed857..de2a224 100755\n> --- a/t/perf/p5310-pack-bitmaps.sh\n> +++ b/t/perf/p5310-pack-bitmaps.sh\n> @@ -39,14 +39,14 @@ test_expect_success 'create partial bitmap state' '\n>  \n>  \t# now kill off all of the refs and pretend we had\n>  \t# just the one tip\n> -\trm -rf .git/logs .git/refs/* .git/packed-refs\n> -\tgit update-ref HEAD $cutoff\n> +\trm -rf .git/logs .git/refs/* .git/packed-refs &&\n> +\tgit update-ref HEAD $cutoff &&\n\nThanks, this definitely is a problem, but we already have a fix in the\nsb/p5310-and-chain topic. I thought that had been merged-up, but it\nlooks like it is only in \"next\" right now.\n\n-Peff\n"},{"id":"266026","messageId":"55A06838.4090808@web.de","threadId":"39830","inReplyTo":"20150710205029.GA1181@peff.net","subject":"Re: [PATCH] p5310: mend broken &&-chain","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2015-07-11T00:50:00Z","receivedAt":"2015-07-11T00:50:00Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 10.07.2015 um 22:50 schrieb Jeff King:\n> Thanks, this definitely is a problem, but we already have a fix in the\n> sb/p5310-and-chain topic. I thought that had been merged-up, but it\n> looks like it is only in \"next\" right now.\n\nAll the better.  And I see it's in master now.\n\nRené\n"}]}