{"thread":{"id":"39656","subject":"Fwd: New Defects reported by Coverity Scan for git","startedAt":"2015-06-17T13:54:56Z","lastAt":"2015-06-17T14:39:43Z","messageCount":2,"participants":["Duy Nguyen","Paul Tan"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"264012","messageId":"CACsJy8D5_n3+yQ=7fRFMv6XU=s3vf0hoi4-7yDyYZSByK0zKsA@mail.gmail.com","threadId":"39656","inReplyTo":"558151df465a5_4fafe3b3182568a@scan.mail","subject":"Fwd: New Defects reported by Coverity Scan for git","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2015-06-17T13:54:56Z","receivedAt":"2015-06-17T13:54:56Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"I think Coverity caught this correctly.\n\n** CID 1306846:  Memory - illegal accesses  (USE_AFTER_FREE)\n/builtin/pull.c: 287 in config_get_rebase()\n\n\n________________________________________________________________________________________________________\n*** CID 1306846:  Memory - illegal accesses  (USE_AFTER_FREE)\n/builtin/pull.c: 287 in config_get_rebase()\n281\n282             if (curr_branch) {\n283                     char *key = xstrfmt(\"branch.%s.rebase\",\ncurr_branch->name);\n284\n285                     if (!git_config_get_value(key, &value)) {\n286                             free(key);\n>>>     CID 1306846:  Memory - illegal accesses  (USE_AFTER_FREE)\n>>>     Passing freed pointer \"key\" as an argument to \"parse_config_rebase\".\n287                             return parse_config_rebase(key, value, 1);\n288                     }\n289\n290                     free(key);\n291             }\n292\n-- \nDuy\n"},{"id":"264025","messageId":"CACRoPnRz8T3yV3=g4128oa+GtuCzdxXCa1JN7stcbP_zVKFLqw@mail.gmail.com","threadId":"39656","inReplyTo":"CACsJy8D5_n3+yQ=7fRFMv6XU=s3vf0hoi4-7yDyYZSByK0zKsA@mail.gmail.com","subject":"Re: New Defects reported by Coverity Scan for git","fromName":"Paul Tan","fromEmail":"pyokagan@gmail.com","sentAt":"2015-06-17T14:39:43Z","receivedAt":"2015-06-17T14:39:43Z","isPatch":false,"sender":{"key":"pyokagan@gmail.com","avatar":"https://avatars.githubusercontent.com/u/109479?v=4"},"body":"On Wed, Jun 17, 2015 at 9:54 PM, Duy Nguyen <pclouds@gmail.com> wrote:\n> I think Coverity caught this correctly.\n>\n> ** CID 1306846:  Memory - illegal accesses  (USE_AFTER_FREE)\n> /builtin/pull.c: 287 in config_get_rebase()\n>\n>\n> ________________________________________________________________________________________________________\n> *** CID 1306846:  Memory - illegal accesses  (USE_AFTER_FREE)\n> /builtin/pull.c: 287 in config_get_rebase()\n> 281\n> 282             if (curr_branch) {\n> 283                     char *key = xstrfmt(\"branch.%s.rebase\",\n> curr_branch->name);\n> 284\n> 285                     if (!git_config_get_value(key, &value)) {\n> 286                             free(key);\n>>>>     CID 1306846:  Memory - illegal accesses  (USE_AFTER_FREE)\n>>>>     Passing freed pointer \"key\" as an argument to \"parse_config_rebase\".\n> 287                             return parse_config_rebase(key, value, 1);\n> 288                     }\n> 289\n> 290                     free(key);\n> 291             }\n> 292\n\nUgh, thanks. ><\n\nRegards,\nPaul\n"}]}