{"thread":{"id":"39568","subject":"[PATCH 1/1]: git-completion.tcsh fails w/ noclobber","startedAt":"2015-06-08T23:01:33Z","lastAt":"2015-06-09T09:25:43Z","messageCount":2,"participants":["Ariel Faigon","Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"263320","messageId":"20150608230133.GA14473@yendor.com","threadId":"39568","inReplyTo":null,"subject":"[PATCH 1/1]: git-completion.tcsh fails w/ noclobber","fromName":"Ariel Faigon","fromEmail":"github.2009@yendor.com","sentAt":"2015-06-08T23:01:33Z","receivedAt":"2015-06-08T23:01:33Z","isPatch":true,"sender":{"key":"github.2009@yendor.com","avatar":null},"body":"tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.  Adding a `!` in the redirect works correctly for both clobber (default) and 'set noclobber' users.\n\nHelped-by: Junio C Hamano <notifications@github.com>\nMentored-by: Christian Couder <christian.couder@gmail.com>\nSigned-off-by: Ariel Faigon <github.2009@yendor.com>\n---\n\n contrib/completion/git-completion.tcsh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh\nindex 6104a42..4a790d8 100644\n--- a/contrib/completion/git-completion.tcsh\n+++ b/contrib/completion/git-completion.tcsh\n@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then\n \texit\n endif\n \n-cat << EOF > ${__git_tcsh_completion_script}\n+cat << EOF >! ${__git_tcsh_completion_script}\n #!bash\n #\n # This script is GENERATED and will be overwritten automatically.\n"},{"id":"263334","messageId":"CAP8UFD0s4ea5CPYUV1FWbi_eeK=V9a+a6MW75o9RwtyQ7RzhNg@mail.gmail.com","threadId":"39568","inReplyTo":"20150608230133.GA14473@yendor.com","subject":"Re: [PATCH 1/1]: git-completion.tcsh fails w/ noclobber","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2015-06-09T09:25:43Z","receivedAt":"2015-06-09T09:25:43Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"The subject is better but still not quite there. I suggest:\n\n[PATCH] git-completion.tcsh: fix redirect with noclobber\n\nOn Tue, Jun 9, 2015 at 1:01 AM, Ariel Faigon <github.2009@yendor.com> wrote:\n> tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.  Adding a `!` in the redirect works correctly for both clobber (default) and 'set noclobber' users.\n>\n> Helped-by: Junio C Hamano <notifications@github.com>\n\nThe email address look wrong. If he really helped you, he probably\nemailed you using another address.\n\n> Mentored-by: Christian Couder <christian.couder@gmail.com>\n\n\"Mentored-by:\" is used by Google Summer of Code students. If someone\nhelps you and you want to acknowledge that, you can add an\n\"Helped-by:\" trailer (unless your helper tells you that you can add a\n\"Reviewed-by:\" or maybe a \"Signed-off-by:\").\n\n> Signed-off-by: Ariel Faigon <github.2009@yendor.com>\n> ---\n"}]}