{"thread":{"id":"39552","subject":"PATCH [git/contrib] Avoid failing to create ${__git_tcsh_completion_script} when 'set noclobber' is in effect (af7333c)","startedAt":"2015-06-07T19:54:51Z","lastAt":"2015-06-08T19:31:23Z","messageCount":2,"participants":["Ariel Faigon","Christian Couder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"263159","messageId":"20150607195451.GA23551@yendor.com","threadId":"39552","inReplyTo":"arielf/git/commit/af7333c176401601d67ea67cb961332ee4ef3574/11557888@github.com","subject":"PATCH [git/contrib] Avoid failing to create ${__git_tcsh_completion_script} when 'set noclobber' is in effect (af7333c)","fromName":"Ariel Faigon","fromEmail":"github.2009@yendor.com","sentAt":"2015-06-07T19:54:51Z","receivedAt":"2015-06-07T19:54:51Z","isPatch":false,"sender":{"key":"github.2009@yendor.com","avatar":null},"body":"\nJunio,\n\nThis is my 1st time doing this, sorry.\nI hope this satisfies the git Sign Off procedure.\n\nProblem Description:\n\ntcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.  Adding a `!` in the redirect works correctly for both clobber and noclobber users.\n\nDeveloper's Certificate of Origin 1.1\n\n        By making a contribution to this project, I certify that:\n\n        (a) The contribution was created in whole or in part by me and I\n            have the right to submit it under the open source license\n            indicated in the file; or\n\n        (b) The contribution is based upon previous work that, to the best\n            of my knowledge, is covered under an appropriate open source\n            license and I have the right under that license to submit that\n            work with modifications, whether created in whole or in part\n            by me, under the same open source license (unless I am\n            permitted to submit under a different license), as indicated\n            in the file; or\n\n        (c) The contribution was provided directly to me by some other\n            person who certified (a), (b) or (c) and I have not modified\n            it.\n\n        (d) I understand and agree that this project and the contribution\n            are public and that a record of the contribution (including all\n            personal information I submit with it, including my sign-off) is\n            maintained indefinitely and may be redistributed consistent with\n            this project or the open source license(s) involved.\n\n Signed-off-by: Ariel Faigon <github.2009@yendor.com>\n\n git patch follows.\n\n---\n contrib/completion/git-completion.tcsh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh\nindex 6104a42..4a790d8 100644\n--- a/contrib/completion/git-completion.tcsh\n+++ b/contrib/completion/git-completion.tcsh\n@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then\n \texit\n endif\n \n-cat << EOF > ${__git_tcsh_completion_script}\n+cat << EOF >! ${__git_tcsh_completion_script}\n #!bash\n #\n # This script is GENERATED and will be overwritten automatically.\n"},{"id":"263292","messageId":"CAP8UFD0mmHAbXtcJZNhnhGtTv82zQV3j+OcSSa_xeLrEJzCqyA@mail.gmail.com","threadId":"39552","inReplyTo":"20150607195451.GA23551@yendor.com","subject":"Re: PATCH [git/contrib] Avoid failing to create ${__git_tcsh_completion_script} when 'set noclobber' is in effect (af7333c)","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2015-06-08T19:31:23Z","receivedAt":"2015-06-08T19:31:23Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Please use a subject that is shorter and looks more like others on this list.\n\nOn Sun, Jun 7, 2015 at 9:54 PM, Ariel Faigon <github.2009@yendor.com> wrote:\n>\n> Junio,\n>\n> This is my 1st time doing this, sorry.\n> I hope this satisfies the git Sign Off procedure.\n\nThe above lines should not be there, otherwise they will be in the\ncommit message and will not be useful there.\n\n> Problem Description:\n\nPlease loose the above header.\n\n> tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error,\n\nWhen do they get that error?\n\n> and the tcsh completion file doesn't get generated/updated.  Adding a `!` in the redirect works correctly for both clobber and noclobber users.\n>\n> Developer's Certificate of Origin 1.1\n>\n>         By making a contribution to this project, I certify that:\n>\n>         (a) The contribution was created in whole or in part by me and I\n>             have the right to submit it under the open source license\n>             indicated in the file; or\n>\n>         (b) The contribution is based upon previous work that, to the best\n>             of my knowledge, is covered under an appropriate open source\n>             license and I have the right under that license to submit that\n>             work with modifications, whether created in whole or in part\n>             by me, under the same open source license (unless I am\n>             permitted to submit under a different license), as indicated\n>             in the file; or\n>\n>         (c) The contribution was provided directly to me by some other\n>             person who certified (a), (b) or (c) and I have not modified\n>             it.\n>\n>         (d) I understand and agree that this project and the contribution\n>             are public and that a record of the contribution (including all\n>             personal information I submit with it, including my sign-off) is\n>             maintained indefinitely and may be redistributed consistent with\n>             this project or the open source license(s) involved.\n\nYou don't need to copy the Developer's Certificate of Origin in your\npatch even if it's the first time. Your signed-off-by below is enough.\n\n>  Signed-off-by: Ariel Faigon <github.2009@yendor.com>\n>\n>  git patch follows.\n\nPlease put nothing after your signed-off-by and before the three dashes below.\n\n> ---\n\nHere, just after the three dashes, is the right place to put personnal\ncomments and stuff that should not go into the commit message.\n\n>  contrib/completion/git-completion.tcsh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh\n> index 6104a42..4a790d8 100644\n> --- a/contrib/completion/git-completion.tcsh\n> +++ b/contrib/completion/git-completion.tcsh\n> @@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then\n>         exit\n>  endif\n>\n> -cat << EOF > ${__git_tcsh_completion_script}\n> +cat << EOF >! ${__git_tcsh_completion_script}\n>  #!bash\n>  #\n>  # This script is GENERATED and will be overwritten automatically.\n\nThanks,\nChristian.\n"}]}