{"thread":{"id":"39417","subject":"[PATCH] completion: suggest sequencer commands for revert","startedAt":"2015-05-25T09:59:35Z","lastAt":"2015-06-01T15:06:03Z","messageCount":10,"participants":["Thomas Braun","Junio C Hamano","Ramkumar Ramachandra","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"262021","messageId":"1432547975.4644.5.camel@virtuell-zuhause.de","threadId":"39417","inReplyTo":null,"subject":"[PATCH] completion: suggest sequencer commands for revert","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2015-05-25T09:59:35Z","receivedAt":"2015-05-25T09:59:35Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n---\n\nHi,\n\nI added the sequencer commands for git revert. These are handy in case a git\nrevert needs manual intervention.\n\nThanks,\nThomas\n\n contrib/completion/git-completion.bash | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex bfc74e9..3c00acd 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2282,6 +2282,11 @@ _git_reset ()\n \n _git_revert ()\n {\n+\tlocal dir=\"$(__gitdir)\"\n+\tif [ -f \"$dir\"/REVERT_HEAD ]; then\n+\t\t__gitcomp \"--continue --quit --abort\"\n+\t\treturn\n+\tfi\n \tcase \"$cur\" in\n \t--*)\n \t\t__gitcomp \"--edit --mainline --no-edit --no-commit --signoff\"\n"},{"id":"262450","messageId":"xmqq1thzcgde.fsf@gitster.dls.corp.google.com","threadId":"39417","inReplyTo":"1432547975.4644.5.camel@virtuell-zuhause.de","subject":"Re: [PATCH] completion: suggest sequencer commands for revert","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-05-29T19:50:53Z","receivedAt":"2015-05-29T19:50:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Braun <thomas.braun@virtuell-zuhause.de> writes:\n\n> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n> ---\n>\n> Hi,\n>\n> I added the sequencer commands for git revert. These are handy in case a git\n> revert needs manual intervention.\n\nThis looks OK from a cursory read to me; asking opinions from those\nwho have touched the file in the recent past (Ram also happens to be\none of the people who were heavily involved in sequencer work).\n\nThanks.\n\n>\n> Thanks,\n> Thomas\n>\n>  contrib/completion/git-completion.bash | 5 +++++\n>  1 file changed, 5 insertions(+)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index bfc74e9..3c00acd 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2282,6 +2282,11 @@ _git_reset ()\n>  \n>  _git_revert ()\n>  {\n> +\tlocal dir=\"$(__gitdir)\"\n> +\tif [ -f \"$dir\"/REVERT_HEAD ]; then\n> +\t\t__gitcomp \"--continue --quit --abort\"\n> +\t\treturn\n> +\tfi\n>  \tcase \"$cur\" in\n>  \t--*)\n>  \t\t__gitcomp \"--edit --mainline --no-edit --no-commit --signoff\"\n"},{"id":"262459","messageId":"CALkWK0m9Fj_3AnJcENL-kAFSbYjW4fKpN76Tftrt672hQj4qww@mail.gmail.com","threadId":"39417","inReplyTo":"xmqq1thzcgde.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] completion: suggest sequencer commands for revert","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2015-05-29T23:13:39Z","receivedAt":"2015-05-29T23:13:39Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Junio C Hamano wrote:\n>\n> >  contrib/completion/git-completion.bash | 5 +++++\n> >  1 file changed, 5 insertions(+)\n> >\n> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> > index bfc74e9..3c00acd 100644\n> > --- a/contrib/completion/git-completion.bash\n> > +++ b/contrib/completion/git-completion.bash\n> > @@ -2282,6 +2282,11 @@ _git_reset ()\n> >\n> >  _git_revert ()\n> >  {\n> > +     local dir=\"$(__gitdir)\"\n> > +     if [ -f \"$dir\"/REVERT_HEAD ]; then\n> > +             __gitcomp \"--continue --quit --abort\"\n> > +             return\n> > +     fi\n> >       case \"$cur\" in\n> >       --*)\n> >               __gitcomp \"--edit --mainline --no-edit --no-commit --signoff\"\n\nThis corresponds exactly to what we do for git-cherry-pick:\n\nlocal dir=\"$(__gitdir)\"\nif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n__gitcomp \"--continue --quit --abort\"\nreturn\nfi\n\nPerhaps _git_revert() and _git_cherry_pick() should call into the same\nfunction with different arguments.\n\nThis looks fine though.\n"},{"id":"262467","messageId":"1433001452.5113.4.camel@virtuell-zuhause.de","threadId":"39417","inReplyTo":"CALkWK0m9Fj_3AnJcENL-kAFSbYjW4fKpN76Tftrt672hQj4qww@mail.gmail.com","subject":"[PATCH v2 0/2] completion: sequencer commands","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2015-05-30T15:57:32Z","receivedAt":"2015-05-30T15:57:32Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Ramkumar Ramachandra wrote:\n> Junio C Hamano wrote:\n> >\n> > >  contrib/completion/git-completion.bash | 5 +++++\n> > >  1 file changed, 5 insertions(+)\n> > >\n> > > diff --git a/contrib/completion/git-completion.bash\n> b/contrib/completion/git-completion.bash\n> > > index bfc74e9..3c00acd 100644\n> > > --- a/contrib/completion/git-completion.bash\n> > > +++ b/contrib/completion/git-completion.bash\n> > > @@ -2282,6 +2282,11 @@ _git_reset ()\n> > >\n> > >  _git_revert ()\n> > >  {\n> > > +     local dir=\"$(__gitdir)\"\n> > > +     if [ -f \"$dir\"/REVERT_HEAD ]; then\n> > > +             __gitcomp \"--continue --quit --abort\"\n> > > +             return\n> > > +     fi\n> > >       case \"$cur\" in\n> > >       --*)\n> > >               __gitcomp \"--edit --mainline --no-edit --no-commit\n> --signoff\"\n>\n> This corresponds exactly to what we do for git-cherry-pick:\n>\n> local dir=\"$(__gitdir)\"\n> if [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n> __gitcomp \"--continue --quit --abort\"\n> return\n> fi\n>\n> Perhaps _git_revert() and _git_cherry_pick() should call into the same\n> function with different arguments.\n\nGood idea.\nI created a new function __git_complete_sequencer which is now used to complete\nall commands with active sequencer.\n"},{"id":"262468","messageId":"1433001691.5113.7.camel@virtuell-zuhause.de","threadId":"39417","inReplyTo":"CALkWK0m9Fj_3AnJcENL-kAFSbYjW4fKpN76Tftrt672hQj4qww@mail.gmail.com","subject":"[PATCH v2 2/2] completion: suggest sequencer commands for revert","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2015-05-30T16:01:31Z","receivedAt":"2015-05-30T16:01:31Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n---\n contrib/completion/git-completion.bash | 8 ++++++++\n 1 file changed, 8 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex f6e5bf6..486c61b 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -868,6 +868,12 @@ __git_complete_sequencer ()\n \t\t\treturn 0\n \t\tfi\n \t\t;;\n+\trevert)\n+\t\tif [ -f \"$dir\"/REVERT_HEAD ]; then\n+\t\t\t__gitcomp \"--continue --quit --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n \trebase)\n \t\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n \t\t\t__gitcomp \"--continue --skip --abort\"\n@@ -2300,6 +2306,8 @@ _git_reset ()\n \n _git_revert ()\n {\n+\t__git_complete_sequencer \"revert\" && return\n+\n \tcase \"$cur\" in\n \t--*)\n \t\t__gitcomp \"--edit --mainline --no-edit --no-commit --signoff\"\n"},{"id":"262469","messageId":"1433001710.5113.8.camel@virtuell-zuhause.de","threadId":"39417","inReplyTo":"CALkWK0m9Fj_3AnJcENL-kAFSbYjW4fKpN76Tftrt672hQj4qww@mail.gmail.com","subject":"[PATCH v2 1/2] completion: Add sequencer function","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2015-05-30T16:01:50Z","receivedAt":"2015-05-30T16:01:50Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n---\n contrib/completion/git-completion.bash | 48 +++++++++++++++++++++++-----------\n 1 file changed, 33 insertions(+), 15 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex bfc74e9..f6e5bf6 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -851,15 +851,40 @@ __git_count_arguments ()\n \tprintf \"%d\" $c\n }\n \n+__git_complete_sequencer ()\n+{\n+\tlocal dir=\"$(__gitdir)\"\n+\n+\tcase \"$1\" in\n+\tam)\n+\t\tif [ -d \"$dir\"/rebase-apply ]; then\n+\t\t\t__gitcomp \"--skip --continue --resolved --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n+\tcherry-pick)\n+\t\tif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n+\t\t\t__gitcomp \"--continue --quit --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n+\trebase)\n+\t\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n+\t\t\t__gitcomp \"--continue --skip --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n+\tesac\n+\n+\treturn 1\n+}\n+\n __git_whitespacelist=\"nowarn warn error error-all fix\"\n \n _git_am ()\n {\n-\tlocal dir=\"$(__gitdir)\"\n-\tif [ -d \"$dir\"/rebase-apply ]; then\n-\t\t__gitcomp \"--skip --continue --resolved --abort\"\n-\t\treturn\n-\tfi\n+\t__git_complete_sequencer \"am\" && return\n+\n \tcase \"$cur\" in\n \t--whitespace=*)\n \t\t__gitcomp \"$__git_whitespacelist\" \"\" \"${cur##--whitespace=}\"\n@@ -1044,11 +1069,8 @@ _git_cherry ()\n \n _git_cherry_pick ()\n {\n-\tlocal dir=\"$(__gitdir)\"\n-\tif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n-\t\t__gitcomp \"--continue --quit --abort\"\n-\t\treturn\n-\tfi\n+\t__git_complete_sequencer \"cherry-pick\" && return\n+\n \tcase \"$cur\" in\n \t--*)\n \t\t__gitcomp \"--edit --no-commit --signoff --strategy= --mainline\"\n@@ -1666,11 +1688,7 @@ _git_push ()\n \n _git_rebase ()\n {\n-\tlocal dir=\"$(__gitdir)\"\n-\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n-\t\t__gitcomp \"--continue --skip --abort\"\n-\t\treturn\n-\tfi\n+\t__git_complete_sequencer \"rebase\" && return\n \t__git_complete_strategy && return\n \tcase \"$cur\" in\n \t--whitespace=*)\n"},{"id":"262470","messageId":"1433001725.5113.9.camel@virtuell-zuhause.de","threadId":"39417","inReplyTo":"CALkWK0m9Fj_3AnJcENL-kAFSbYjW4fKpN76Tftrt672hQj4qww@mail.gmail.com","subject":"[PATCH v2 1/2] completion: Add sequencer function","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2015-05-30T16:02:05Z","receivedAt":"2015-05-30T16:02:05Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n---\n contrib/completion/git-completion.bash | 48 +++++++++++++++++++++++-----------\n 1 file changed, 33 insertions(+), 15 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex bfc74e9..f6e5bf6 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -851,15 +851,40 @@ __git_count_arguments ()\n \tprintf \"%d\" $c\n }\n \n+__git_complete_sequencer ()\n+{\n+\tlocal dir=\"$(__gitdir)\"\n+\n+\tcase \"$1\" in\n+\tam)\n+\t\tif [ -d \"$dir\"/rebase-apply ]; then\n+\t\t\t__gitcomp \"--skip --continue --resolved --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n+\tcherry-pick)\n+\t\tif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n+\t\t\t__gitcomp \"--continue --quit --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n+\trebase)\n+\t\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n+\t\t\t__gitcomp \"--continue --skip --abort\"\n+\t\t\treturn 0\n+\t\tfi\n+\t\t;;\n+\tesac\n+\n+\treturn 1\n+}\n+\n __git_whitespacelist=\"nowarn warn error error-all fix\"\n \n _git_am ()\n {\n-\tlocal dir=\"$(__gitdir)\"\n-\tif [ -d \"$dir\"/rebase-apply ]; then\n-\t\t__gitcomp \"--skip --continue --resolved --abort\"\n-\t\treturn\n-\tfi\n+\t__git_complete_sequencer \"am\" && return\n+\n \tcase \"$cur\" in\n \t--whitespace=*)\n \t\t__gitcomp \"$__git_whitespacelist\" \"\" \"${cur##--whitespace=}\"\n@@ -1044,11 +1069,8 @@ _git_cherry ()\n \n _git_cherry_pick ()\n {\n-\tlocal dir=\"$(__gitdir)\"\n-\tif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n-\t\t__gitcomp \"--continue --quit --abort\"\n-\t\treturn\n-\tfi\n+\t__git_complete_sequencer \"cherry-pick\" && return\n+\n \tcase \"$cur\" in\n \t--*)\n \t\t__gitcomp \"--edit --no-commit --signoff --strategy= --mainline\"\n@@ -1666,11 +1688,7 @@ _git_push ()\n \n _git_rebase ()\n {\n-\tlocal dir=\"$(__gitdir)\"\n-\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n-\t\t__gitcomp \"--continue --skip --abort\"\n-\t\treturn\n-\tfi\n+\t__git_complete_sequencer \"rebase\" && return\n \t__git_complete_strategy && return\n \tcase \"$cur\" in\n \t--whitespace=*)\n"},{"id":"262483","messageId":"20150530210103.Horde.YoJthfdQJy5oq9wT_oOl3Q1@webmail.informatik.kit.edu","threadId":"39417","inReplyTo":"1433001710.5113.8.camel@virtuell-zuhause.de","subject":"Re: [PATCH v2 1/2] completion: Add sequencer function","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2015-05-30T19:01:03Z","receivedAt":"2015-05-30T19:01:03Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"\nQuoting Thomas Braun <thomas.braun@virtuell-zuhause.de>:\n\n> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>\n> ---\n>  contrib/completion/git-completion.bash | 48  \n> +++++++++++++++++++++++-----------\n>  1 file changed, 33 insertions(+), 15 deletions(-)\n\nI don't see the benefits of this change.  This patch adds more than  \ntwice as many lines as it removes, and patch 2/2 adds 8 new lines  \nalthough it could get away with only 5 without this function.  To  \noffer sequencer options we currently go through a single if statement,  \nwith this patch we'd go through a case statement, an if statement and  \nfinally an &&.\n\nGábor\n\n\n> diff --git a/contrib/completion/git-completion.bash  \n> b/contrib/completion/git-completion.bash\n> index bfc74e9..f6e5bf6 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -851,15 +851,40 @@ __git_count_arguments ()\n>  \tprintf \"%d\" $c\n>  }\n>\n> +__git_complete_sequencer ()\n> +{\n> +\tlocal dir=\"$(__gitdir)\"\n> +\n> +\tcase \"$1\" in\n> +\tam)\n> +\t\tif [ -d \"$dir\"/rebase-apply ]; then\n> +\t\t\t__gitcomp \"--skip --continue --resolved --abort\"\n> +\t\t\treturn 0\n> +\t\tfi\n> +\t\t;;\n> +\tcherry-pick)\n> +\t\tif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n> +\t\t\t__gitcomp \"--continue --quit --abort\"\n> +\t\t\treturn 0\n> +\t\tfi\n> +\t\t;;\n> +\trebase)\n> +\t\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n> +\t\t\t__gitcomp \"--continue --skip --abort\"\n> +\t\t\treturn 0\n> +\t\tfi\n> +\t\t;;\n> +\tesac\n> +\n> +\treturn 1\n> +}\n> +\n>  __git_whitespacelist=\"nowarn warn error error-all fix\"\n>\n>  _git_am ()\n>  {\n> -\tlocal dir=\"$(__gitdir)\"\n> -\tif [ -d \"$dir\"/rebase-apply ]; then\n> -\t\t__gitcomp \"--skip --continue --resolved --abort\"\n> -\t\treturn\n> -\tfi\n> +\t__git_complete_sequencer \"am\" && return\n> +\n>  \tcase \"$cur\" in\n>  \t--whitespace=*)\n>  \t\t__gitcomp \"$__git_whitespacelist\" \"\" \"${cur##--whitespace=}\"\n> @@ -1044,11 +1069,8 @@ _git_cherry ()\n>\n>  _git_cherry_pick ()\n>  {\n> -\tlocal dir=\"$(__gitdir)\"\n> -\tif [ -f \"$dir\"/CHERRY_PICK_HEAD ]; then\n> -\t\t__gitcomp \"--continue --quit --abort\"\n> -\t\treturn\n> -\tfi\n> +\t__git_complete_sequencer \"cherry-pick\" && return\n> +\n>  \tcase \"$cur\" in\n>  \t--*)\n>  \t\t__gitcomp \"--edit --no-commit --signoff --strategy= --mainline\"\n> @@ -1666,11 +1688,7 @@ _git_push ()\n>\n>  _git_rebase ()\n>  {\n> -\tlocal dir=\"$(__gitdir)\"\n> -\tif [ -d \"$dir\"/rebase-apply ] || [ -d \"$dir\"/rebase-merge ]; then\n> -\t\t__gitcomp \"--continue --skip --abort\"\n> -\t\treturn\n> -\tfi\n> +\t__git_complete_sequencer \"rebase\" && return\n>  \t__git_complete_strategy && return\n>  \tcase \"$cur\" in\n>  \t--whitespace=*)\n"},{"id":"262597","messageId":"xmqq6177a3zk.fsf@gitster.dls.corp.google.com","threadId":"39417","inReplyTo":"20150530210103.Horde.YoJthfdQJy5oq9wT_oOl3Q1@webmail.informatik.kit.edu","subject":"Re: [PATCH v2 1/2] completion: Add sequencer function","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-06-01T14:38:07Z","receivedAt":"2015-06-01T14:38:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"SZEDER Gábor <szeder@ira.uka.de> writes:\n\n> I don't see the benefits of this change.  This patch adds more than  \n> twice as many lines as it removes, and patch 2/2 adds 8 new lines  \n> although it could get away with only 5 without this function.  To  \n> offer sequencer options we currently go through a single if statement,  \n> with this patch we'd go through a case statement, an if statement and  \n> finally an &&.\n>\n> Gábor\n\nPerhaps, especially given that I'd imagine we won't be adding 47 new\ncommands that drive the sequencer in the near future ;-)\n\nI presume that you are OK with Thomas's original version, then?\n"},{"id":"262603","messageId":"20150601170603.Horde.iiRpDlRNsOoCFFaHVSBOwg1@webmail.informatik.kit.edu","threadId":"39417","inReplyTo":"xmqq6177a3zk.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2 1/2] completion: Add sequencer function","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2015-06-01T15:06:03Z","receivedAt":"2015-06-01T15:06:03Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"\nQuoting Junio C Hamano <gitster@pobox.com>:\n\n> SZEDER Gábor <szeder@ira.uka.de> writes:\n>\n>> I don't see the benefits of this change.  This patch adds more than\n>> twice as many lines as it removes, and patch 2/2 adds 8 new lines\n>> although it could get away with only 5 without this function.  To\n>> offer sequencer options we currently go through a single if statement,\n>> with this patch we'd go through a case statement, an if statement and\n>> finally an &&.\n>>\n>> Gábor\n>\n> Perhaps, especially given that I'd imagine we won't be adding 47 new\n> commands that drive the sequencer in the near future ;-)\n>\n> I presume that you are OK with Thomas's original version, then?\n\nYes, definitely.\n\nIt's a shame all these sequencing commands have different sets of  \nsequencer options.  Perhaps something to clean up for, say, v3.0 :)\n\n\nGábor\n"}]}