{"thread":{"id":"39370","subject":"test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","startedAt":"2015-05-19T17:20:04Z","lastAt":"2015-05-20T03:01:18Z","messageCount":9,"participants":["Stefan Beller","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"261568","messageId":"CAGZ79kY61ZJHHG4jj2hZSzXZ58fh9R9b8hOijaCTGxTu8dtN=w@mail.gmail.com","threadId":"39370","inReplyTo":null,"subject":"test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T17:20:04Z","receivedAt":"2015-05-19T17:20:04Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Hi,\n\nso today I am running make test (no special flags I am aware of) on my\nubuntu machine using\ngit v2.4.1-168-g1ea28e1 and t5570-git-daemon.sh (not ok 8 - fetch\nnotices corrupt idx) fails.\n\nAny hints?\n\nThanks,\nStefan\n"},{"id":"261569","messageId":"CAGZ79kaaES_k2PUtsDMBjHzjeg=1BPD0UQr3T18yb1n9qmYYLg@mail.gmail.com","threadId":"39370","inReplyTo":"CAGZ79kY61ZJHHG4jj2hZSzXZ58fh9R9b8hOijaCTGxTu8dtN=w@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T17:22:26Z","receivedAt":"2015-05-19T17:22:26Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, May 19, 2015 at 10:20 AM, Stefan Beller <sbeller@google.com> wrote:\n> Hi,\n>\n> so today I am running make test (no special flags I am aware of) on my\n> ubuntu machine using\n> git v2.4.1-168-g1ea28e1 and t5570-git-daemon.sh (not ok 8 - fetch\n> notices corrupt idx) fails.\n>\n> Any hints?\n\nIt seems to be a flaky test. When I try the test with -d or -i it passes.\nUsing -v it still fails,\n\ntest_must_fail: command succeeded: git --bare fetch\ngit://127.0.0.1:5570/repo_bad2.git\n\n>\n> Thanks,\n> Stefan\n"},{"id":"261570","messageId":"20150519172254.GA27174@peff.net","threadId":"39370","inReplyTo":"CAGZ79kY61ZJHHG4jj2hZSzXZ58fh9R9b8hOijaCTGxTu8dtN=w@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-05-19T17:22:54Z","receivedAt":"2015-05-19T17:22:54Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, May 19, 2015 at 10:20:04AM -0700, Stefan Beller wrote:\n\n> so today I am running make test (no special flags I am aware of) on my\n> ubuntu machine using\n> git v2.4.1-168-g1ea28e1 and t5570-git-daemon.sh (not ok 8 - fetch\n> notices corrupt idx) fails.\n> \n> Any hints?\n\nIt works for me. :)\n\nIs the problem reproducible, or intermittent? The daemon-oriented tests\nsometimes can suffer from weird races. \n\nIf it is reproducible, what does running it with \"-v -i\" (and maybe\n\"-x\") say?\n\n-Peff\n"},{"id":"261571","messageId":"CAGZ79kbV8noD6v8mdc7vM4cONV_cvuLLt_ay14YSoFjQ3v4N0w@mail.gmail.com","threadId":"39370","inReplyTo":"20150519172254.GA27174@peff.net","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T17:24:21Z","receivedAt":"2015-05-19T17:24:21Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, May 19, 2015 at 10:22 AM, Jeff King <peff@peff.net> wrote:\n> On Tue, May 19, 2015 at 10:20:04AM -0700, Stefan Beller wrote:\n>\n>> so today I am running make test (no special flags I am aware of) on my\n>> ubuntu machine using\n>> git v2.4.1-168-g1ea28e1 and t5570-git-daemon.sh (not ok 8 - fetch\n>> notices corrupt idx) fails.\n>>\n>> Any hints?\n>\n> It works for me. :)\n>\n> Is the problem reproducible, or intermittent? The daemon-oriented tests\n> sometimes can suffer from weird races.\n>\n> If it is reproducible, what does running it with \"-v -i\" (and maybe\n> \"-x\") say?\n\n-x also keeps it failing\n\nexpecting success:\ncp -R \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_pack.git\n\"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n(cd \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\np=`ls objects/pack/pack-*.idx` &&\nchmod u+w $p &&\nprintf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n) &&\nmkdir repo_bad2.git &&\n(cd repo_bad2.git &&\ngit --bare init &&\ntest_must_fail git --bare fetch \"$GIT_DAEMON_URL/repo_bad2.git\" &&\ntest 0 = `ls objects/pack | wc -l`\n)\n\n++ cp -R '/usr/local/google/home/sbeller/OSS/git/t/trash\ndirectory.t5570-git-daemon/repo/repo_pack.git'\n'/usr/local/google/home/sbeller/OSS/git/t/trash\ndirectory.t5570-git-daemon/repo/repo_bad2.git'\n++ cd '/usr/local/google/home/sbeller/OSS/git/t/trash\ndirectory.t5570-git-daemon/repo/repo_bad2.git'\n+++ ls objects/pack/pack-0de42e9908e5d304b40de56c4ce788ce0ff4eff0.idx\n++ p=objects/pack/pack-0de42e9908e5d304b40de56c4ce788ce0ff4eff0.idx\n++ chmod u+w objects/pack/pack-0de42e9908e5d304b40de56c4ce788ce0ff4eff0.idx\n++ printf %0256d 0\n++ dd of=objects/pack/pack-0de42e9908e5d304b40de56c4ce788ce0ff4eff0.idx\nbs=256 count=1 seek=1 conv=notrunc\n1+0 records in\n1+0 records out\n256 bytes (256 B) copied, 0.000129681 s, 2.0 MB/s\n++ mkdir repo_bad2.git\n++ cd repo_bad2.git\n++ git --bare init\nInitialized empty Git repository in\n/usr/local/google/home/sbeller/OSS/git/t/trash\ndirectory.t5570-git-daemon/repo_bad2.git/\n++ test_must_fail git --bare fetch git://127.0.0.1:5570/repo_bad2.git\n++ git --bare fetch git://127.0.0.1:5570/repo_bad2.git\n[18703] Connection from 127.0.0.1:39945\n[18703] Extended attributes (21 bytes) exist <host=127.0.0.1:5570>\n[18703] Request upload-pack for '/repo_bad2.git'\nremote: Counting objects: 6, done.\nremote: Compressing objects: 100% (2/2), done.\nremote: Total 6 (delta 0), reused 6 (delta 0)\n[18534] [18703] Disconnected\nUnpacking objects: 100% (6/6), done.\nFrom git://127.0.0.1:5570/repo_bad2\n * branch            HEAD       -> FETCH_HEAD\n++ exit_code=0\n++ test 0 = 0\n++ echo 'test_must_fail: command succeeded: git --bare fetch\ngit://127.0.0.1:5570/repo_bad2.git'\ntest_must_fail: command succeeded: git --bare fetch\ngit://127.0.0.1:5570/repo_bad2.git\n++ return 1\nerror: last command exited with $?=1\nnot ok 8 - fetch notices corrupt idx\n#\n# cp -R \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_pack.git\n\"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n# (cd \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n# p=`ls objects/pack/pack-*.idx` &&\n# chmod u+w $p &&\n# printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n# ) &&\n# mkdir repo_bad2.git &&\n# (cd repo_bad2.git &&\n# git --bare init &&\n# test_must_fail git --bare fetch \"$GIT_DAEMON_URL/repo_bad2.git\" &&\n# test 0 = `ls objects/pack | wc -l`\n# )\n#\n"},{"id":"261572","messageId":"CAGZ79kaNWDB2qg2-x-+2ccV1hC7Y0K8TQVPQNkjMotggwsRRzw@mail.gmail.com","threadId":"39370","inReplyTo":"CAGZ79kbV8noD6v8mdc7vM4cONV_cvuLLt_ay14YSoFjQ3v4N0w@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T17:31:01Z","receivedAt":"2015-05-19T17:31:01Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"$ git bisect bad\n383c3427afa3201eb05e931825c5c2f20616b58b is the first bad commit\ncommit 383c3427afa3201eb05e931825c5c2f20616b58b\nAuthor: Eric Sunshine <sunshine@sunshineco.com>\nDate:   Mon May 4 03:25:14 2015 -0400\n\n    t1007: add hash-object --literally tests\n\n    git-hash-object learned a --literally option in 5ba9a93\n    (hash-object: add --literally option, 2014-09-11). Check that\n    --literally allows object creation with a bogus type, with two\n    type strings whose length is reasonably short and very long.\n\n    Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>\n    Signed-off-by: Junio C Hamano <gitster@pobox.com>\n"},{"id":"261573","messageId":"CAGZ79kbYUNjD79T+1LqgLNf=_ym-keq57FoQhby_aqn_sPFYSg@mail.gmail.com","threadId":"39370","inReplyTo":"CAGZ79kaNWDB2qg2-x-+2ccV1hC7Y0K8TQVPQNkjMotggwsRRzw@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T17:34:09Z","receivedAt":"2015-05-19T17:34:09Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, May 19, 2015 at 10:31 AM, Stefan Beller <sbeller@google.com> wrote:\n> $ git bisect bad\n> 383c3427afa3201eb05e931825c5c2f20616b58b is the first bad commit\n> commit 383c3427afa3201eb05e931825c5c2f20616b58b\n> Author: Eric Sunshine <sunshine@sunshineco.com>\n> Date:   Mon May 4 03:25:14 2015 -0400\n>\n>     t1007: add hash-object --literally tests\n>\n>     git-hash-object learned a --literally option in 5ba9a93\n>     (hash-object: add --literally option, 2014-09-11). Check that\n>     --literally allows object creation with a bogus type, with two\n>     type strings whose length is reasonably short and very long.\n>\n>     Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>\n>     Signed-off-by: Junio C Hamano <gitster@pobox.com>\n\nWhen looking at the commit I don't think I found the right one.\nSo I went back to HEAD^ (being v2.1.0-243-g0c3db67), which\nalso tests bad now. Is there a way to force git bisect to change\ngood to bad?\n"},{"id":"261574","messageId":"CAGZ79ka7iNP0VJbLmzpUmFkkdtBhgHrbseKtfOq-PX4FCiBuaA@mail.gmail.com","threadId":"39370","inReplyTo":"CAGZ79kbYUNjD79T+1LqgLNf=_ym-keq57FoQhby_aqn_sPFYSg@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T17:53:07Z","receivedAt":"2015-05-19T17:53:07Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Sorry for the noise, it must be a machine specific\nthing at my end, because v2.3 and even v2.0.0\nfail the test now.\n\nTo observe the failing test I run\n\n    $ make && (cd t; ./t5570-git-daemon.sh)\n\nwhich should be sufficient to not have stale data?\n\nI'll try to follow the test script and look into the test\ndetails to actually understand what the problem is here.\n"},{"id":"261582","messageId":"CAGZ79kbHVeNPQr_A3izp41WLRcaroHfN6NJObWcURQk4B=NYWA@mail.gmail.com","threadId":"39370","inReplyTo":"CAGZ79ka7iNP0VJbLmzpUmFkkdtBhgHrbseKtfOq-PX4FCiBuaA@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-05-19T19:16:57Z","receivedAt":"2015-05-19T19:16:57Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"And here comes the resolution of the puzzle.\nRemember when I claimed there are no special flags set in the first mail?\nExcept one flag that is actually true. ;)\n\nI did have a special flag set, which is\nCC = /usr/lib/gcc-snapshot/bin/gcc\nwhich is using the latest snapshot of the gcc compiler\ngcc (Ubuntu 20140405-0ubuntu1) 4.9.0 20140405\n(experimental) [trunk revision 209146]\ninstead of the standard install\ngcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2 on my machine\n\nUsing the standard compiler git build ands tests t5570,8 just\nfine in various versions.\n\nIf I take the latest snapshot of gcc, I have a flakey behavior\nin Git versions ranging from current origin/master back to v2.0.0\n(did not test further)\n\nCould somebody try to reproduce the failing test using the latest gcc\nsnapshot compiler?\n"},{"id":"261629","messageId":"20150520030118.GA7223@peff.net","threadId":"39370","inReplyTo":"CAGZ79kbHVeNPQr_A3izp41WLRcaroHfN6NJObWcURQk4B=NYWA@mail.gmail.com","subject":"Re: test suite failure t5570, 8 with v2.4.1-168-g1ea28e1","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-05-20T03:01:18Z","receivedAt":"2015-05-20T03:01:18Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, May 19, 2015 at 12:16:57PM -0700, Stefan Beller wrote:\n\n> I did have a special flag set, which is\n> CC = /usr/lib/gcc-snapshot/bin/gcc\n> which is using the latest snapshot of the gcc compiler\n> gcc (Ubuntu 20140405-0ubuntu1) 4.9.0 20140405\n> (experimental) [trunk revision 209146]\n\nI'm not sure 2014 counts as the \"latest\". :) My stock compiler is 4.9.2,\nand gcc-snapshot on Debian unstable is:\n\n  gcc (Debian 20150516-1) 6.0.0 20150516 (experimental)\n  [trunk revision 223239]\n\n> Could somebody try to reproduce the failing test using the latest gcc\n> snapshot compiler?\n\nBoth versions I listed above seem to work fine for me. Of course we\ncan't definitively rule out git provoking undefined behavior in certain\ncompiler versions, but short of more data, I'd say it's probably a gcc\nbug in 4.9.0 which has since been fixed.\n\n-Peff\n"}]}