{"thread":{"id":"39241","subject":"[PATCH] Fixed translation error (say(_())) functions","startedAt":"2015-05-03T22:05:53Z","lastAt":"2015-05-04T15:19:45Z","messageCount":2,"participants":["Alangi Derick","Matthieu Moy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"260520","messageId":"554769df.43c8c20a.4b7f.ffffc3cb@mx.google.com","threadId":"39241","inReplyTo":null,"subject":"[PATCH] Fixed translation error (say(_())) functions","fromName":"Alangi Derick","fromEmail":"alangiderick@gmail.com","sentAt":"2015-05-03T22:05:53Z","receivedAt":"2015-05-03T22:05:53Z","isPatch":true,"sender":{"key":"alangiderick@gmail.com","avatar":"https://gravatar.com/avatar/f5878e69e83b4cf7ed499336c4a114dc2cb253253bc57c9b8ffcf0e129320795?d=mp&s=160"},"body":"Signed-off-by: Alangi Derick <alangiderick@gmail.com>\n---\n base85.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/base85.c b/base85.c\nindex 5ca601e..4160f44 100644\n--- a/base85.c\n+++ b/base85.c\n@@ -78,7 +78,7 @@ int decode_85(char *dst, const char *buffer, int len)\n \n void encode_85(char *buf, const unsigned char *data, int bytes)\n {\n-\tsay(\"encode 85\");\n+\tsay(_(\"encode 85\"));\n \twhile (bytes) {\n \t\tunsigned acc = 0;\n \t\tint cnt;\n@@ -96,7 +96,7 @@ void encode_85(char *buf, const unsigned char *data, int bytes)\n \t\t}\n \t\tbuf += 5;\n \t}\n-\tsay(\"\\n\");\n+\tsay(_(\"\\n\"));\n \n \t*buf = 0;\n }\n-- \n2.4.0.1.gd092831.dirty\n"},{"id":"260528","messageId":"vpqpp6ggyjy.fsf@anie.imag.fr","threadId":"39241","inReplyTo":"554769df.43c8c20a.4b7f.ffffc3cb@mx.google.com","subject":"Re: [PATCH] Fixed translation error (say(_())) functions","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-05-04T15:19:45Z","receivedAt":"2015-05-04T15:19:45Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"It seems you are posting putting the list in Bcc. Don't do that: it\nmakes it painful to reply to your message (I had to re-add git@vger\nmanually).\n\nAlangi Derick <alangiderick@gmail.com> writes:\n\n> Subject: [PATCH] Fixed translation error (say(_())) functions\n\nPlease, read the \"(2) Describe your changes well.\" section of\nSubmittingPatches (actually, read the whole document if not done\nalready, but particularly this section). Your subject does not adhere\nthe usual format.\n\n> Signed-off-by: Alangi Derick <alangiderick@gmail.com>\n> ---\n>  base85.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/base85.c b/base85.c\n> index 5ca601e..4160f44 100644\n> --- a/base85.c\n> +++ b/base85.c\n> @@ -78,7 +78,7 @@ int decode_85(char *dst, const char *buffer, int len)\n>  \n>  void encode_85(char *buf, const unsigned char *data, int bytes)\n>  {\n> -\tsay(\"encode 85\");\n> +\tsay(_(\"encode 85\"));\n\nThese are debug statements (see the top of base85.c). I don't think you\nwant to translate them.\n\n> @@ -96,7 +96,7 @@ void encode_85(char *buf, const unsigned char *data, int bytes)\n>  \t\t}\n>  \t\tbuf += 5;\n>  \t}\n> -\tsay(\"\\n\");\n> +\tsay(_(\"\\n\"));\n\nSame, plus the fact that a \\n would not need to be translated anyway I\nguess.\n\nRegards,\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}