{"thread":{"id":"3922","subject":"[PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do.","startedAt":"2006-04-19T20:01:20Z","lastAt":"2006-04-19T20:50:48Z","messageCount":2,"participants":["Junio C Hamano","Linus Torvalds"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"18885","messageId":"7v1wvt8hdb.fsf@assigned-by-dhcp.cox.net","threadId":"3922","inReplyTo":null,"subject":"[PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-04-19T20:01:20Z","receivedAt":"2006-04-19T20:01:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n * Just a clean-up, comes on top of the one that returns mode\n   from get_tree_entry().\n\n sha1_name.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/sha1_name.c b/sha1_name.c\nindex 35e8dfb..7ad20b5 100644\n--- a/sha1_name.c\n+++ b/sha1_name.c\n@@ -3,7 +3,7 @@ #include \"tag.h\"\n #include \"commit.h\"\n #include \"tree.h\"\n #include \"blob.h\"\n-#include \"diff.h\"\n+#include \"tree-walk.h\"\n \n static int find_short_object_filename(int len, const char *name, unsigned char *sha1)\n {\n-- \n1.3.0.g2c4a\n"},{"id":"18888","messageId":"Pine.LNX.4.64.0604191348230.3701@g5.osdl.org","threadId":"3922","inReplyTo":"7v1wvt8hdb.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do.","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-04-19T20:50:48Z","receivedAt":"2006-04-19T20:50:48Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Wed, 19 Apr 2006, Junio C Hamano wrote:\n>\n>  * Just a clean-up, comes on top of the one that returns mode\n>    from get_tree_entry().\n\nAck (along with the mode addition).\n\nHowever, since the function is now no longer private to the SHA1 name \nlookup, I wonder if it might not be more logically put into \"tree-walk.c\" \ninstead of \"sha1_name.c\".\n\nJust a thought.\n\n\t\tLinus\n"}]}