{"thread":{"id":"39213","subject":"[Patch] Nice help Output - SmallProjectIdea[1]","startedAt":"2015-05-01T18:33:51Z","lastAt":"2015-05-02T09:51:58Z","messageCount":4,"participants":["Alangi Derick","Thomas Gummerer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"260369","messageId":"CAKB+oNvZxueR9PqysPn3khQZL+8tt3NNrgFzNjHnVuBVtyeZ4w@mail.gmail.com","threadId":"39213","inReplyTo":null,"subject":"[Patch] Nice help Output - SmallProjectIdea[1]","fromName":"Alangi Derick","fromEmail":"alangiderick@gmail.com","sentAt":"2015-05-01T18:33:51Z","receivedAt":"2015-05-01T18:33:51Z","isPatch":true,"sender":{"key":"alangiderick@gmail.com","avatar":"https://gravatar.com/avatar/f5878e69e83b4cf7ed499336c4a114dc2cb253253bc57c9b8ffcf0e129320795?d=mp&s=160"},"body":"This is a patch to fix the problem as given in the site:\nhttps://git.wiki.kernel.org/index.php/SmallProjectsIdeas\n\ndiff --git a/help.c b/help.c\nindex 2072a87..e347bbc 100644\n--- a/help.c\n+++ b/help.c\n@@ -229,9 +229,18 @@ void list_common_cmds_help(void)\n\n  puts(_(\"The most commonly used git commands are:\"));\n  for (i = 0; i < ARRAY_SIZE(common_cmds); i++) {\n- printf(\"   %s   \", common_cmds[i].name);\n- mput_char(' ', longest - strlen(common_cmds[i].name));\n- puts(_(common_cmds[i].help));\n+ if(i%3 == 1){\n+ printf(\"   %s   \", common_cmds[i].name);\n+ mput_char(' ', longest - strlen(common_cmds[i].name));\n+ puts(_(common_cmds[i].help));\n+ printf(\"\\n\");\n+ }\n+ else {\n+ printf(\"   %s   \", common_cmds[i].name);\n+ mput_char(' ', longest - strlen(common_cmds[i].name));\n+ puts(_(common_cmds[i].help));\n+ }\n+\n  }\n }\n\n\nRegards\nAlangi Derick Ndimnain\n"},{"id":"260372","messageId":"87wq0sw1tb.fsf@hank.tgummerer.com","threadId":"39213","inReplyTo":"CAKB+oNvZxueR9PqysPn3khQZL+8tt3NNrgFzNjHnVuBVtyeZ4w@mail.gmail.com","subject":"Re: [Patch] Nice help Output - SmallProjectIdea[1]","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2015-05-01T19:11:12Z","receivedAt":"2015-05-01T19:11:12Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"Hi,\n\nAlangi Derick <alangiderick@gmail.com> writes:\n\n> This is a patch to fix the problem as given in the site:\n> https://git.wiki.kernel.org/index.php/SmallProjectsIdeas\n\nPlease have a look at Documentation/SubmittingPatches, on how to submit\nwell formed patches.  In particular, the following things should be\nimproved:\n\n- The commit should have a meaningful commit message (See section 2 in\n  SubmittingPatches)\n- The patch should be created with git format-patch, so it can be\n  applied using git am. (See section 3 and 4)\n- Your work should be signed off, otherwise it can not be applied to the\n  project. (See section 5)\n\n> diff --git a/help.c b/help.c\n> index 2072a87..e347bbc 100644\n> --- a/help.c\n> +++ b/help.c\n> @@ -229,9 +229,18 @@ void list_common_cmds_help(void)\n>\n>   puts(_(\"The most commonly used git commands are:\"));\n>   for (i = 0; i < ARRAY_SIZE(common_cmds); i++) {\n> - printf(\"   %s   \", common_cmds[i].name);\n> - mput_char(' ', longest - strlen(common_cmds[i].name));\n> - puts(_(common_cmds[i].help));\n> + if(i%3 == 1){\n> + printf(\"   %s   \", common_cmds[i].name);\n> + mput_char(' ', longest - strlen(common_cmds[i].name));\n> + puts(_(common_cmds[i].help));\n> + printf(\"\\n\");\n> + }\n> + else {\n> + printf(\"   %s   \", common_cmds[i].name);\n> + mput_char(' ', longest - strlen(common_cmds[i].name));\n> + puts(_(common_cmds[i].help));\n> + }\n> +\n\nPatch formatting issues aside, I don't think this does what is suggested\nin the project.  You are just adding a blank line after three lines in\nthe help output, which I don't think improves the current state by much.\n\nThe bzr help output on the other hand groups similar commands together,\nand shows them to the user in groups.  So the first step would be to\nfind out which commands should be grouped together and then to output\nthe groups here.\n\n>   }\n>  }\n>\n>\n> Regards\n> Alangi Derick Ndimnain\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"},{"id":"260419","messageId":"CAKB+oNtwJtW3h22W_8hEhhYnxAiynM1B839_WO7Yp=eJF_7PpQ@mail.gmail.com","threadId":"39213","inReplyTo":"87wq0sw1tb.fsf@hank.tgummerer.com","subject":"Re: [Patch] Nice help Output - SmallProjectIdea[1]","fromName":"Alangi Derick","fromEmail":"alangiderick@gmail.com","sentAt":"2015-05-02T07:04:02Z","receivedAt":"2015-05-02T07:04:02Z","isPatch":true,"sender":{"key":"alangiderick@gmail.com","avatar":"https://gravatar.com/avatar/f5878e69e83b4cf7ed499336c4a114dc2cb253253bc57c9b8ffcf0e129320795?d=mp&s=160"},"body":"Thanks for the correction. I will work on that and see if i can solve\nthe problem. With respect to my git send-email, it is not working so i\ndon't know whether i have a problem with my smtp. I don't know how to\nconfigure it.\n"},{"id":"260422","messageId":"87twvvwblt.fsf@hank.tgummerer.com","threadId":"39213","inReplyTo":"CAKB+oNtwJtW3h22W_8hEhhYnxAiynM1B839_WO7Yp=eJF_7PpQ@mail.gmail.com","subject":"Re: [Patch] Nice help Output - SmallProjectIdea[1]","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2015-05-02T09:51:58Z","receivedAt":"2015-05-02T09:51:58Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"Hi,\n\nOn 05/02, Alangi Derick wrote:\n> Thanks for the correction. I will work on that and see if i can solve\n> the problem.\n\nI've noticed there was another patch series, which attempts at solving\nthe same problem at\nhttp://thread.gmane.org/gmane.comp.version-control.git/268198.  So\nmaybe you could coordinate with Sébastien, or work on another project,\nto avoid duplicating the work.\n\n> With respect to my git send-email, it is not working so i\n> don't know whether i have a problem with my smtp. I don't know how to\n> configure it.\n\nMaybe you can send us the configuration here, so someone might be able\nto help.  Though it might be faster to get help on IRC, on the #git\nchannel on freenode.\n"}]}