{"thread":{"id":"39189","subject":"CURLOPT_NOBODY","startedAt":"2015-04-30T02:20:55Z","lastAt":"2015-04-30T20:13:21Z","messageCount":4,"participants":["Thiago Farina","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"260252","messageId":"CACnwZYdCitEJ=pr=1+C_Wz5pKTbSYj4hD7mQHLC3gaDO8CqnrA@mail.gmail.com","threadId":"39189","inReplyTo":null,"subject":"CURLOPT_NOBODY","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2015-04-30T02:20:55Z","receivedAt":"2015-04-30T02:20:55Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"Hey there,\n\nDo we need to set CURLOPT_NOBODY to 0 in\nhttps://code.googlesource.com/git/+/master/http.c#1138? Do we do this\nfor the sake of doing, because it doesn't hurt?\n\nAccording to the documentation in\nhttp://curl.haxx.se/libcurl/c/CURLOPT_HTTPGET.html, if we set HTTPGET\nto 1 it will automatically set NOBODY to 0, so the answer for the\nabove question would be no.\n\nAlso, according to http://curl.haxx.se/libcurl/c/CURLOPT_NOBODY.html,\nit is 0 by default.\n\nBye,\n\n-- \nThiago Farina\n"},{"id":"260255","messageId":"20150430035512.GC12361@peff.net","threadId":"39189","inReplyTo":"CACnwZYdCitEJ=pr=1+C_Wz5pKTbSYj4hD7mQHLC3gaDO8CqnrA@mail.gmail.com","subject":"Re: CURLOPT_NOBODY","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-04-30T03:55:12Z","receivedAt":"2015-04-30T03:55:12Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Apr 29, 2015 at 11:20:55PM -0300, Thiago Farina wrote:\n\n> Do we need to set CURLOPT_NOBODY to 0 in\n> https://code.googlesource.com/git/+/master/http.c#1138? Do we do this\n> for the sake of doing, because it doesn't hurt?\n> \n> According to the documentation in\n> http://curl.haxx.se/libcurl/c/CURLOPT_HTTPGET.html, if we set HTTPGET\n> to 1 it will automatically set NOBODY to 0, so the answer for the\n> above question would be no.\n\nIt may have been necessary at one time...\n\nRunning \"git blame\" on the curl repository's lib/url.c shows that the\nbehavior started in 726b9e2, which is in curl 7.14.1, released in 2005.\n\nGrepping for LIBCURL_VERSION_NUM in git, we definitely support versions\nolder than that.  Most of those version checks are quite old, too, and\nwe could probably stop supporting antique versions of curl. But unless\nthere is a compelling benefit (e.g., we get to clean up some old cruft),\nI'd rather leave things as-is.\n\nDropping this one line does not seem like a compelling cleanup to me,\nthough it's possible if we said \"you must have curl from the last 5\nyears\" we could do other cleanups, and this would come along for the\nride.\n\n> Also, according to http://curl.haxx.se/libcurl/c/CURLOPT_NOBODY.html,\n> it is 0 by default.\n\nWe reuse curl handles, so we reinitialize the request-specific options\nfor each request.\n\n-Peff\n"},{"id":"260300","messageId":"CACnwZYeVVKrTDM5rTaZz9sTjQ9tjWsk52D8WMu8kDM3vxEiVLg@mail.gmail.com","threadId":"39189","inReplyTo":"20150430035512.GC12361@peff.net","subject":"Re: CURLOPT_NOBODY","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2015-04-30T19:57:28Z","receivedAt":"2015-04-30T19:57:28Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"The same logic you apply to CURLOPT_FILE -> CURLOPT_WRITEDATA?\n\nBye!\n\n-- \nThiago Farina\n"},{"id":"260302","messageId":"20150430201321.GA7067@peff.net","threadId":"39189","inReplyTo":"CACnwZYeVVKrTDM5rTaZz9sTjQ9tjWsk52D8WMu8kDM3vxEiVLg@mail.gmail.com","subject":"Re: CURLOPT_NOBODY","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-04-30T20:13:21Z","receivedAt":"2015-04-30T20:13:21Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Apr 30, 2015 at 04:57:28PM -0300, Thiago Farina wrote:\n\n> The same logic you apply to CURLOPT_FILE -> CURLOPT_WRITEDATA?\n\nMaybe. I had to track down the appropriate curl versions for the NOBODY\ncase manually. If you'd like to do the same for CURLOPT_FILE, be my\nguest (and if it has always been that way, I do not mind a cleanup\npatch).\n\n-Peff\n"}]}