{"thread":{"id":"39175","subject":"[PATCHv2] git-p4: t9814: prevent --chain-lint failure","startedAt":"2015-04-28T06:30:08Z","lastAt":"2015-04-28T07:21:22Z","messageCount":4,"participants":["Luke Diamand"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"260106","messageId":"1430202609-31841-1-git-send-email-luke@diamand.org","threadId":"39175","inReplyTo":"20150427230223.GA22403@peff.net","subject":"[PATCHv2] Fixup test-lint error in git-p4 t9814 test","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-04-28T06:30:08Z","receivedAt":"2015-04-28T06:30:08Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"Using Jeff's suggestion of converting the t9814 test to use\ntest_lazy_prereq makes the test a lot clearer, and as a bonus,\nalso fixes the --chain-lint error.\n\nThanks,\nLuke\n\nLuke Diamand (1):\n  git-p4: t9814: prevent --chain-lint failure\n\n t/t9814-git-p4-rename.sh | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)\n\n-- \n2.3.4.48.g223ab37\n"},{"id":"260105","messageId":"1430202609-31841-2-git-send-email-luke@diamand.org","threadId":"39175","inReplyTo":"1430202609-31841-1-git-send-email-luke@diamand.org","subject":"[PATCHv2] git-p4: t9814: prevent --chain-lint failure","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-04-28T06:30:09Z","receivedAt":"2015-04-28T06:30:09Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"Use test_lazy_prereq to setup prerequisites for the p4 move\ntest. This both makes the test simpler and clearer, and also\nmeans they no longer fail the new --chain-lint tests.\n\nSuggested-by: Jeff King <peff@peff.net>\nSigned-off-by: Luke Diamand <luke@diamand.org>\n---\n t/t9814-git-p4-rename.sh | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t9814-git-p4-rename.sh b/t/t9814-git-p4-rename.sh\nindex 99bb71b..c89992c 100755\n--- a/t/t9814-git-p4-rename.sh\n+++ b/t/t9814-git-p4-rename.sh\n@@ -226,14 +226,9 @@ test_expect_success 'detect copies' '\n \n # See if configurables can be set, and in particular if the run.move.allow\n # variable exists, which allows admins to disable the \"p4 move\" command.\n-test_expect_success 'p4 configure command and run.move.allow are available' '\n-\tp4 configure show run.move.allow >out ; retval=$? &&\n-\ttest $retval = 0 &&\n-\t{\n-\t\tegrep ^run.move.allow: out &&\n-\t\ttest_set_prereq P4D_HAVE_CONFIGURABLE_RUN_MOVE_ALLOW ||\n-\t\ttrue\n-\t} || true\n+test_lazy_prereq P4D_HAVE_CONFIGURABLE_RUN_MOVE_ALLOW '\n+\tp4 configure show run.move.allow >out &&\n+\tegrep ^run.move.allow: out\n '\n \n # If move can be disabled, turn it off and test p4 move handling\n-- \n2.3.4.48.g223ab37\n"},{"id":"260111","messageId":"1430205682-4309-1-git-send-email-luke@diamand.org","threadId":"39175","inReplyTo":"1430202609-31841-1-git-send-email-luke@diamand.org","subject":"[PATCHv3] Fixup test-lint error in git-p4 t9814 test","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-04-28T07:21:21Z","receivedAt":"2015-04-28T07:21:21Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"Using Jeff's suggestion of converting the t9814 test to use\ntest_lazy_prereq makes the test a lot clearer, and as a bonus,\nalso fixes the --chain-lint error.\n\nVersion 3 of the patch corrects a small typo in the commit message\nof version 2.\n\nLuke Diamand (1):\n  git-p4: t9814: prevent --chain-lint failure\n\n t/t9814-git-p4-rename.sh | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)\n\n-- \n2.3.4.48.g223ab37\n"},{"id":"260112","messageId":"1430205682-4309-2-git-send-email-luke@diamand.org","threadId":"39175","inReplyTo":"1430205682-4309-1-git-send-email-luke@diamand.org","subject":"[PATCHv3] git-p4: t9814: prevent --chain-lint failure","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-04-28T07:21:22Z","receivedAt":"2015-04-28T07:21:22Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"Use test_lazy_prereq to setup prerequisites for the p4 move\ntest. This both makes the test simpler and clearer, and also\nmeans it no longer fails the new --chain-lint tests.\n\nSuggested-by: Jeff King <peff@peff.net>\nSigned-off-by: Luke Diamand <luke@diamand.org>\n---\n t/t9814-git-p4-rename.sh | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t9814-git-p4-rename.sh b/t/t9814-git-p4-rename.sh\nindex 99bb71b..c89992c 100755\n--- a/t/t9814-git-p4-rename.sh\n+++ b/t/t9814-git-p4-rename.sh\n@@ -226,14 +226,9 @@ test_expect_success 'detect copies' '\n \n # See if configurables can be set, and in particular if the run.move.allow\n # variable exists, which allows admins to disable the \"p4 move\" command.\n-test_expect_success 'p4 configure command and run.move.allow are available' '\n-\tp4 configure show run.move.allow >out ; retval=$? &&\n-\ttest $retval = 0 &&\n-\t{\n-\t\tegrep ^run.move.allow: out &&\n-\t\ttest_set_prereq P4D_HAVE_CONFIGURABLE_RUN_MOVE_ALLOW ||\n-\t\ttrue\n-\t} || true\n+test_lazy_prereq P4D_HAVE_CONFIGURABLE_RUN_MOVE_ALLOW '\n+\tp4 configure show run.move.allow >out &&\n+\tegrep ^run.move.allow: out\n '\n \n # If move can be disabled, turn it off and test p4 move handling\n-- \n2.3.4.48.g223ab37\n"}]}