{"thread":{"id":"39154","subject":"Verbose as default for commit (optional)","startedAt":"2015-04-24T19:18:09Z","lastAt":"2015-04-25T04:33:10Z","messageCount":5,"participants":["Eloy Espinaco","Matthieu Moy","Eric Sunshine","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"259957","messageId":"20150424191809.GA18897@alvaca.santafe.altoros.com.ar","threadId":"39154","inReplyTo":null,"subject":"Verbose as default for commit (optional)","fromName":"Eloy Espinaco","fromEmail":"eloyesp@gmail.com","sentAt":"2015-04-24T19:18:09Z","receivedAt":"2015-04-24T19:18:09Z","isPatch":false,"sender":{"key":"eloyesp@gmail.com","avatar":"https://gravatar.com/avatar/d925a85ccf59e6edcfc943f7fdbefcb75dcaac0b5b7b00642a79d9c6e8f24036?d=mp&s=160"},"body":"Hi,\n\nIt is my first mail to the list, so \"hello world\".\n\nI wanted to make a feature-request about a config setting to make the\ncommit always verbose. I'm not the only one asking for that, there is an\nold question in [Stack Overflow][1].\n\nSo I was thinking if it was possible to make a pull request for that, so\nI attach the patch. (I'm proud of it :) ).\n\nI wasn't able to make the test for it, but I wanted to ask (before I\ntry) if it makes sense to add this feature (or if it is considered\nfeature bloat).\n\nThanks.\n\n--- Eloy Espinaco\n\n [1]: http://stackoverflow.com/questions/5875275/git-commit-v-by-default\n\n\n"},{"id":"259959","messageId":"vpqbnidmgzh.fsf@anie.imag.fr","threadId":"39154","inReplyTo":"20150424191809.GA18897@alvaca.santafe.altoros.com.ar","subject":"Re: Verbose as default for commit (optional)","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-04-24T20:03:14Z","receivedAt":"2015-04-24T20:03:14Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Eloy Espinaco writes:\n\n> Hi,\n>\n> It is my first mail to the list, so \"hello world\".\n\nHi, and welcome to the list.\n\n> I wanted to make a feature-request about a config setting to make the\n> commit always verbose. I'm not the only one asking for that, there is an\n> old question in [Stack Overflow][1].\n\nThis seems a reasonable addition. In general, we commonly have config\noptions for commonly used CLI options.\n\n> So I was thinking if it was possible to make a pull request for that, so\n> I attach the patch. (I'm proud of it :) ).\n\nNice try, but the attached file is empty ;-). Actually, as much as\npossible, avoid sending attachments but prefer inline patches.\n\nYou'll need a bit of reading to send a proper patch:\n\nhttps://github.com/git/git/blob/master/Documentation/SubmittingPatches\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"259973","messageId":"20150424235103.GA1798@localhost","threadId":"39154","inReplyTo":"vpqbnidmgzh.fsf@anie.imag.fr","subject":"Re: Verbose as default for commit (optional)","fromName":"Eloy Espinaco","fromEmail":"eloyesp@gmail.com","sentAt":"2015-04-24T23:51:03Z","receivedAt":"2015-04-24T23:51:03Z","isPatch":false,"sender":{"key":"eloyesp@gmail.com","avatar":"https://gravatar.com/avatar/d925a85ccf59e6edcfc943f7fdbefcb75dcaac0b5b7b00642a79d9c6e8f24036?d=mp&s=160"},"body":"Ok, now I found [this\nthread](http://thread.gmane.org/gmane.comp.version-control.git/251376)\nthat seems abandoned, but implements this config, a --no-verbose that\ndisable it for one-time and the tests, but was not merged (don't know\nwhy)\n\nThis was the patch I've intended to attach:\n----------------->8--------------------\n\nSubject: [PATCH] Add commit.verbose config to set default.\n\n---\n builtin/commit.c | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex da79ac4..ad588ff 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -1506,6 +1506,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)\n \t\tsign_commit = git_config_bool(k, v) ? \"\" : NULL;\n \t\treturn 0;\n \t}\n+\tif (!strcmp(k, \"commit.verbose\")) {\n+\t\tverbose = git_config_bool(k, v);\n+\t\treturn 0;\n+\t}\n \n \tstatus = git_gpg_config(k, v, NULL);\n \tif (status)\n-- \n2.1.4\n\nEn Fri, Apr 24, 2015 at 10:03:14PM +0200, Matthieu Moy escribió:\n> Eloy Espinaco writes:\n> \n> > Hi,\n> >\n> > It is my first mail to the list, so \"hello world\".\n> \n> Hi, and welcome to the list.\n> \n> > I wanted to make a feature-request about a config setting to make the\n> > commit always verbose. I'm not the only one asking for that, there is an\n> > old question in [Stack Overflow][1].\n> \n> This seems a reasonable addition. In general, we commonly have config\n> options for commonly used CLI options.\n> \n> > So I was thinking if it was possible to make a pull request for that, so\n> > I attach the patch. (I'm proud of it :) ).\n> \n> Nice try, but the attached file is empty ;-). Actually, as much as\n> possible, avoid sending attachments but prefer inline patches.\n> \n> You'll need a bit of reading to send a proper patch:\n> \n> https://github.com/git/git/blob/master/Documentation/SubmittingPatches\n> \n> -- \n> Matthieu Moy\n> http://www-verimag.imag.fr/~moy/\n--- Eloy Espinaco\n"},{"id":"259974","messageId":"CAPig+cRegJ9b0NyvkrZvJMw3CAU0TdgyzH1DMDjB_hV2X4ysHg@mail.gmail.com","threadId":"39154","inReplyTo":"20150424235103.GA1798@localhost","subject":"Re: Verbose as default for commit (optional)","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2015-04-25T01:08:56Z","receivedAt":"2015-04-25T01:08:56Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Apr 24, 2015 at 7:51 PM, Eloy Espinaco wrote:\n> Ok, now I found [this\n> thread](http://thread.gmane.org/gmane.comp.version-control.git/251376)\n> that seems abandoned, but implements this config, a --no-verbose that\n> disable it for one-time and the tests, but was not merged (don't know\n> why)\n\nI recall reviewing Caleb's patch series and making a number of\nsuggestions for improvement. v6 was the last version he posted[1], and\nit seems that he intended to post v7 but never got around to it.\nApparently, Torstein Hegge asked in February 2015 about picking up\nwhere Caleb left off, but nothing has materialized.\n\nYou are welcome to revive the series by taking reviewer comments into\naccount and submitting v7 (and beyond if necessary). Be sure to keep\nCaleb's authorship and sign-off intact, and add your own sign-off\nfollowing his. If you make changes to his patches, briefly describe\nyour changes in a bracketed comment in the commit message, starting\nwith your initials, like this: [ee: changed blah to bleh].\n\n[1]: http://thread.gmane.org/gmane.comp.version-control.git/251943/focus=264608\n"},{"id":"259977","messageId":"xmqqr3r825fd.fsf@gitster.dls.corp.google.com","threadId":"39154","inReplyTo":"CAPig+cRegJ9b0NyvkrZvJMw3CAU0TdgyzH1DMDjB_hV2X4ysHg@mail.gmail.com","subject":"Re: Verbose as default for commit (optional)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-04-25T04:33:10Z","receivedAt":"2015-04-25T04:33:10Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine writes:\n\n> On Fri, Apr 24, 2015 at 7:51 PM, Eloy Espinaco wrote:\n>> Ok, now I found [this\n>> thread](http://thread.gmane.org/gmane.comp.version-control.git/251376)\n>> that seems abandoned, but implements this config, a --no-verbose that\n>> disable it for one-time and the tests, but was not merged (don't know\n>> why)\n>\n> I recall reviewing Caleb's patch series and making a number of\n> suggestions for improvement. v6 was the last version he posted[1], and\n> it seems that he intended to post v7 but never got around to it.\n> Apparently, Torstein Hegge asked in February 2015 about picking up\n> where Caleb left off, but nothing has materialized.\n>\n> You are welcome to revive the series by taking reviewer comments into\n> account and submitting v7 (and beyond if necessary). Be sure to keep\n> Caleb's authorship and sign-off intact, and add your own sign-off\n> following his. If you make changes to his patches, briefly describe\n> your changes in a bracketed comment in the commit message, starting\n> with your initials, like this: [ee: changed blah to bleh].\n>\n> [1]: http://thread.gmane.org/gmane.comp.version-control.git/251943/focus=264608\n\nAlso, the world order has changed recently, if I am not mistaken.\nBack when Caleb's series was done, there were only two choices\n(i.e. are we verbose, or not verbose?) Now \"commit\" and \"status\"\ncan take three choices, so commit.verbose boolean would not cut it.\n\nShould the configuration variable be commit.verbose and only affect\n\"commit\" and not \"status\", or should both of these commands pay\nattention to the single variable and behave the same way?\n\nI offhand do not have a strong opinion on these questions, but\nwhoever is doing a proposal must think about it and justify the\ndecision.\n\nThanks.\n"}]}