{"thread":{"id":"3915","subject":"Fix uninteresting tags in new revision parsing","startedAt":"2006-04-19T03:31:41Z","lastAt":"2006-04-19T04:36:47Z","messageCount":2,"participants":["Linus Torvalds","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"18851","messageId":"Pine.LNX.4.64.0604182027460.3701@g5.osdl.org","threadId":"3915","inReplyTo":null,"subject":"Fix uninteresting tags in new revision parsing","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-04-19T03:31:41Z","receivedAt":"2006-04-19T03:31:41Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\nWhen I unified the revision argument parsing, I introduced a simple bug \nwrt tags that had been marked uninteresting. When it was preparing for the \nrevision walk, it would mark all the parent commits of an uninteresting \ntag correctly uninteresting, but it would forget about the commit itself.\n\nThis means that when I just did my 2.6.17-rc2 release, and my scripts \ngenerated the log for \"v2.6.17-rc1..v2.6.17-rc2\", everything was fine, \nexcept the commit pointed to by 2.6.17-rc1 (which shouldn't have been \nthere) was included. Even though it should obviously have been marked as \nbeing uninteresting.\n\nNot a huge deal, and the fix is trivial.\n\nSigned-off-by: Linus Torvalds <torvalds@osdl.org>\n---\ndiff --git a/revision.c b/revision.c\nindex dbd54da..113dd5a 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -152,6 +152,7 @@ static struct commit *handle_commit(stru\n \t\tif (parse_commit(commit) < 0)\n \t\t\tdie(\"unable to parse commit %s\", name);\n \t\tif (flags & UNINTERESTING) {\n+\t\t\tcommit->object.flags |= UNINTERESTING;\n \t\t\tmark_parents_uninteresting(commit);\n \t\t\trevs->limited = 1;\n \t\t}\n"},{"id":"18857","messageId":"7vu08qb2qo.fsf@assigned-by-dhcp.cox.net","threadId":"3915","inReplyTo":"Pine.LNX.4.64.0604182027460.3701@g5.osdl.org","subject":"Re: Fix uninteresting tags in new revision parsing","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-04-19T04:36:47Z","receivedAt":"2006-04-19T04:36:47Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Torvalds <torvalds@osdl.org> writes:\n\n> When I unified the revision argument parsing, I introduced a simple bug \n> wrt tags that had been marked uninteresting. When it was preparing for the \n> revision walk, it would mark all the parent commits of an uninteresting \n> tag correctly uninteresting, but it would forget about the commit itself.\n\nThanks.  Can't believe I missed it...\n"}]}