{"thread":{"id":"39103","subject":"[PATCH v2 1/2] t0027: Cleanup: rename functions; avoid non-leading TABs","startedAt":"2015-04-17T15:43:43Z","lastAt":"2015-04-17T15:43:43Z","messageCount":1,"participants":["Torsten Bögershausen"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"259569","messageId":"55312A2F.4000804@web.de","threadId":"39103","inReplyTo":null,"subject":"[PATCH v2 1/2] t0027: Cleanup: rename functions; avoid non-leading TABs","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2015-04-17T15:43:43Z","receivedAt":"2015-04-17T15:43:43Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Make more clear what the tests are doing:\n commit_check_warn():\n Commit files and checks for conversion warnings.\n Old name: create_file_in_repo()\n\n checkout_files():\n Checkout files from the repo and check if they have\n the appropriate line endings in the work space.\n Old name: check_files_in_ws()\n\nReplace non-leading TABS with spaces\n\nSigned-off-by: Torsten Bögershausen \n---\nChanges since v1:\n- patch 1 is the same\n- patch 2 is taken from Dscho (but slightly modified)\n Dscho, please tell if this is not OK with you \n- patch 3 temporally removed to simplify life, it will be send later\n\n\n t/t0027-auto-crlf.sh | 184 +++++++++++++++++++++++++--------------------------\n 1 file changed, 92 insertions(+), 92 deletions(-)\n\ndiff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh\nindex 452320d..5858397 100755\n--- a/t/t0027-auto-crlf.sh\n+++ b/t/t0027-auto-crlf.sh\n@@ -68,7 +68,7 @@ check_warning () {\n \tesac\n }\n \n-create_file_in_repo () {\n+commit_check_warn () {\n \tcrlf=$1\n \tattr=$2\n \tlfname=$3\n@@ -109,7 +109,7 @@ check_files_in_repo () {\n }\n \n \n-check_files_in_ws () {\n+checkout_files () {\n \teol=$1\n \tcrlf=$2\n \tattr=$3\n@@ -169,40 +169,40 @@ test_expect_success 'setup master' '\n warn_LF_CRLF=\"LF will be replaced by CRLF\"\n warn_CRLF_LF=\"CRLF will be replaced by LF\"\n \n-test_expect_success 'add files empty attr' '\n-\tcreate_file_in_repo false \"\" \"\" \"\" \"\" \"\" \"\" &&\n-\tcreate_file_in_repo true \"\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"\" \"\" &&\n-\tcreate_file_in_repo input \"\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"\"\n+test_expect_success 'commit files empty attr' '\n+\tcommit_check_warn false \"\" \"\" \"\" \"\" \"\" \"\" &&\n+\tcommit_check_warn true \"\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"\" \"\" &&\n+\tcommit_check_warn input \"\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"\"\n '\n \n-test_expect_success 'add files attr=auto' '\n-\tcreate_file_in_repo false \"auto\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"\" &&\n-\tcreate_file_in_repo true \"auto\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"\" \"\" &&\n-\tcreate_file_in_repo input \"auto\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"\"\n+test_expect_success 'commit files attr=auto' '\n+\tcommit_check_warn false \"auto\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"\" &&\n+\tcommit_check_warn true \"auto\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"\" \"\" &&\n+\tcommit_check_warn input \"auto\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"\"\n '\n \n-test_expect_success 'add files attr=text' '\n-\tcreate_file_in_repo false \"text\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\" &&\n-\tcreate_file_in_repo true \"text\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\" &&\n-\tcreate_file_in_repo input \"text\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\"\n+test_expect_success 'commit files attr=text' '\n+\tcommit_check_warn false \"text\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\" &&\n+\tcommit_check_warn true \"text\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\" &&\n+\tcommit_check_warn input \"text\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\"\n '\n \n-test_expect_success 'add files attr=-text' '\n-\tcreate_file_in_repo false \"-text\" \"\" \"\" \"\" \"\" \"\" &&\n-\tcreate_file_in_repo true \"-text\" \"\" \"\" \"\" \"\" \"\" &&\n-\tcreate_file_in_repo input \"-text\" \"\" \"\" \"\" \"\" \"\"\n+test_expect_success 'commit files attr=-text' '\n+\tcommit_check_warn false \"-text\" \"\" \"\" \"\" \"\" \"\" &&\n+\tcommit_check_warn true \"-text\" \"\" \"\" \"\" \"\" \"\" &&\n+\tcommit_check_warn input \"-text\" \"\" \"\" \"\" \"\" \"\"\n '\n \n-test_expect_success 'add files attr=lf' '\n-\tcreate_file_in_repo false \"lf\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\" &&\n-\tcreate_file_in_repo true \"lf\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\" &&\n-\tcreate_file_in_repo input \"lf\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\"\n+test_expect_success 'commit files attr=lf' '\n+\tcommit_check_warn false \"lf\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\" &&\n+\tcommit_check_warn true \"lf\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\" &&\n+\tcommit_check_warn input \"lf\" \"\" \"CRLF_LF\" \"CRLF_LF\" \"\" \"CRLF_LF\"\n '\n \n-test_expect_success 'add files attr=crlf' '\n-\tcreate_file_in_repo false \"crlf\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\" &&\n-\tcreate_file_in_repo true \"crlf\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\" &&\n-\tcreate_file_in_repo input \"crlf\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\"\n+test_expect_success 'commit files attr=crlf' '\n+\tcommit_check_warn false \"crlf\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\" &&\n+\tcommit_check_warn true \"crlf\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\" &&\n+\tcommit_check_warn input \"crlf\" \"LF_CRLF\" \"\" \"LF_CRLF\" \"LF_CRLF\" \"\"\n '\n \n test_expect_success 'create files cleanup' '\n@@ -237,7 +237,7 @@ test_expect_success 'commit -text' '\n ################################################################################\n # Check how files in the repo are changed when they are checked out\n # How to read the table below:\n-# - check_files_in_ws will check multiple files with a combination of settings\n+# - checkout_files will check multiple files with a combination of settings\n # and attributes (core.autocrlf=input is forbidden with core.eol=crlf)\n # - parameter $1 : core.eol lf | crlf\n # - parameter $2 : core.autocrlf false | true | input\n@@ -249,8 +249,8 @@ test_expect_success 'commit -text' '\n # - parameter $8 : reference for a file with CRLF and a NUL (should be handled as binary when auto)\n \n # What we have in the repo:\n-# \t\t\t\t\t\t\t\t\t\t\t\t\t\t ----------------- EOL in repo ----------------\n-# \t\t\t\t\t\t\t\t\t\t\t\t\t\t LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+# ----------------- EOL in repo ----------------\n+# LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n # settings with checkout:\n # core. core. .gitattr\n # eol acrlf\n@@ -268,68 +268,68 @@ NL=LF\n fi\n export CRLF_MIX_LF_CR MIX NL\n \n-check_files_in_ws lf false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf input \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf false \"auto\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n-check_files_in_ws lf input \"auto\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf false \"text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws lf input \"text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf input \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf input \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws lf false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws lf true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws lf input \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-\n-check_files_in_ws crlf false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf false \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf false \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws crlf true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws crlf false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws crlf false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws crlf true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-\n-check_files_in_ws \"\" false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" input \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" false \"auto\" $NL CRLF $MIX_CRLF_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" input \"auto\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" false \"text\" $NL CRLF $MIX_CRLF_LF $MIX_LF_CR CRLF_nul\n-check_files_in_ws \"\" true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws \"\" input \"text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" input \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" input \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws \"\" false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws \"\" true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws \"\" input \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-\n-check_files_in_ws native false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native false \"auto\" $NL CRLF $MIX_CRLF_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n-check_files_in_ws native false \"text\" $NL CRLF $MIX_CRLF_LF $MIX_LF_CR CRLF_nul\n-check_files_in_ws native true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws native false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n-check_files_in_ws native false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n-check_files_in_ws native true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files lf false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf input \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf false \"auto\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n+checkout_files lf input \"auto\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf false \"text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files lf input \"text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf input \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf input \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files lf false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files lf true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files lf input \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+\n+checkout_files crlf false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files crlf true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files crlf false \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n+checkout_files crlf true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n+checkout_files crlf false \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files crlf true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files crlf false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files crlf true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files crlf false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files crlf true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files crlf false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files crlf true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+\n+checkout_files \"\" false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" input \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" false \"auto\" $NL CRLF $MIX_CRLF_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n+checkout_files \"\" input \"auto\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" false \"text\" $NL CRLF $MIX_CRLF_LF $MIX_LF_CR CRLF_nul\n+checkout_files \"\" true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files \"\" input \"text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" input \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" input \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files \"\" false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files \"\" true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files \"\" input \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+\n+checkout_files native false \"\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files native true \"\" CRLF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files native false \"auto\" $NL CRLF $MIX_CRLF_LF LF_mix_CR CRLF_nul\n+checkout_files native true \"auto\" CRLF CRLF CRLF LF_mix_CR CRLF_nul\n+checkout_files native false \"text\" $NL CRLF $MIX_CRLF_LF $MIX_LF_CR CRLF_nul\n+checkout_files native true \"text\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files native false \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files native true \"-text\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files native false \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files native true \"lf\" LF CRLF CRLF_mix_LF LF_mix_CR CRLF_nul\n+checkout_files native false \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n+checkout_files native true \"crlf\" CRLF CRLF CRLF CRLF_mix_CR CRLF_nul\n \n test_done\n-- \n2.2.0.rc1.790.ge19fcd2\n"}]}