{"thread":{"id":"39101","subject":"[PATCH] Fix settings in default_user_config template","startedAt":"2015-04-17T14:50:10Z","lastAt":"2015-04-17T17:33:32Z","messageCount":5,"participants":["Ossi Herrala","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"259566","messageId":"1429282210-38538-1-git-send-email-oherrala@gmail.com","threadId":"39101","inReplyTo":null,"subject":"[PATCH] Fix settings in default_user_config template","fromName":"Ossi Herrala","fromEmail":"oherrala@gmail.com","sentAt":"2015-04-17T14:50:10Z","receivedAt":"2015-04-17T14:50:10Z","isPatch":true,"sender":{"key":"oherrala@gmail.com","avatar":"https://avatars.githubusercontent.com/u/89251?v=4"},"body":"The name (not user) and email setting should be in config section\n\"user\" and not in \"core\" as documented in Documentation/config.txt.\n---\n builtin/config.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/config.c b/builtin/config.c\nindex d32c532..bfd3016 100644\n--- a/builtin/config.c\n+++ b/builtin/config.c\n@@ -455,9 +455,9 @@ static char *default_user_config(void)\n \tstruct strbuf buf = STRBUF_INIT;\n \tstrbuf_addf(&buf,\n \t\t    _(\"# This is Git's per-user configuration file.\\n\"\n-\t\t      \"[core]\\n\"\n+\t\t      \"[user]\\n\"\n \t\t      \"# Please adapt and uncomment the following lines:\\n\"\n-\t\t      \"#\tuser = %s\\n\"\n+\t\t      \"#\tname = %s\\n\"\n \t\t      \"#\temail = %s\\n\"),\n \t\t    ident_default_name(),\n \t\t    ident_default_email());\n-- \n2.3.5\n"},{"id":"259568","messageId":"20150417145516.GB2421@peff.net","threadId":"39101","inReplyTo":"1429282210-38538-1-git-send-email-oherrala@gmail.com","subject":"Re: [PATCH] Fix settings in default_user_config template","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-04-17T14:55:16Z","receivedAt":"2015-04-17T14:55:16Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Apr 17, 2015 at 05:50:10PM +0300, Ossi Herrala wrote:\n\n> The name (not user) and email setting should be in config section\n> \"user\" and not in \"core\" as documented in Documentation/config.txt.\n\n<facepalm> Well, those probably weren't helping any new users, then,\nwere they? :)\n\n> diff --git a/builtin/config.c b/builtin/config.c\n> index d32c532..bfd3016 100644\n> --- a/builtin/config.c\n> +++ b/builtin/config.c\n> @@ -455,9 +455,9 @@ static char *default_user_config(void)\n>  \tstruct strbuf buf = STRBUF_INIT;\n>  \tstrbuf_addf(&buf,\n>  \t\t    _(\"# This is Git's per-user configuration file.\\n\"\n> -\t\t      \"[core]\\n\"\n> +\t\t      \"[user]\\n\"\n>  \t\t      \"# Please adapt and uncomment the following lines:\\n\"\n> -\t\t      \"#\tuser = %s\\n\"\n> +\t\t      \"#\tname = %s\\n\"\n>  \t\t      \"#\temail = %s\\n\"),\n\nLooks obviously correct. Thanks for noticing.\n\n-Peff\n"},{"id":"259574","messageId":"1429290535-38647-1-git-send-email-oherrala@gmail.com","threadId":"39101","inReplyTo":"20150417145516.GB2421@peff.net","subject":"[PATCH] Fix settings in default_user_config template","fromName":"Ossi Herrala","fromEmail":"oherrala@gmail.com","sentAt":"2015-04-17T17:08:54Z","receivedAt":"2015-04-17T17:08:54Z","isPatch":true,"sender":{"key":"oherrala@gmail.com","avatar":"https://avatars.githubusercontent.com/u/89251?v=4"},"body":"The name (not user) and email setting should be in config section\n\"user\" and not in \"core\" as documented in Documentation/config.txt.\n\nSigned-Off-By: Ossi Herrala <oherrala@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\n"},{"id":"259575","messageId":"1429290535-38647-2-git-send-email-oherrala@gmail.com","threadId":"39101","inReplyTo":"1429290535-38647-1-git-send-email-oherrala@gmail.com","subject":"[PATCH] Fix settings in default_user_config template","fromName":"Ossi Herrala","fromEmail":"oherrala@gmail.com","sentAt":"2015-04-17T17:08:55Z","receivedAt":"2015-04-17T17:08:55Z","isPatch":true,"sender":{"key":"oherrala@gmail.com","avatar":"https://avatars.githubusercontent.com/u/89251?v=4"},"body":"The name (not user) and email setting should be in config section\n\"user\" and not in \"core\" as documented in Documentation/config.txt.\n---\n builtin/config.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/config.c b/builtin/config.c\nindex d32c532..bfd3016 100644\n--- a/builtin/config.c\n+++ b/builtin/config.c\n@@ -455,9 +455,9 @@ static char *default_user_config(void)\n \tstruct strbuf buf = STRBUF_INIT;\n \tstrbuf_addf(&buf,\n \t\t    _(\"# This is Git's per-user configuration file.\\n\"\n-\t\t      \"[core]\\n\"\n+\t\t      \"[user]\\n\"\n \t\t      \"# Please adapt and uncomment the following lines:\\n\"\n-\t\t      \"#\tuser = %s\\n\"\n+\t\t      \"#\tname = %s\\n\"\n \t\t      \"#\temail = %s\\n\"),\n \t\t    ident_default_name(),\n \t\t    ident_default_email());\n-- \n2.3.5\n"},{"id":"259585","messageId":"xmqq1tjir76b.fsf@gitster.dls.corp.google.com","threadId":"39101","inReplyTo":"1429290535-38647-1-git-send-email-oherrala@gmail.com","subject":"Re: [PATCH] Fix settings in default_user_config template","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-04-17T17:33:32Z","receivedAt":"2015-04-17T17:33:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ossi Herrala <oherrala@gmail.com> writes:\n\n> The name (not user) and email setting should be in config section\n> \"user\" and not in \"core\" as documented in Documentation/config.txt.\n>\n> Signed-Off-By: Ossi Herrala <oherrala@gmail.com>\n> Reviewed-by: Jeff King <peff@peff.net>\n\nThanks ;-)\n"}]}