{"thread":{"id":"3910","subject":"[PATCH] Fix filename scaling for binary files","startedAt":"2006-04-18T21:26:43Z","lastAt":"2006-04-18T21:26:43Z","messageCount":1,"participants":["Jonas Fonseca"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"18831","messageId":"20060418212643.GA30478@diku.dk","threadId":"3910","inReplyTo":null,"subject":"[PATCH] Fix filename scaling for binary files","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2006-04-18T21:26:43Z","receivedAt":"2006-04-18T21:26:43Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Set maximum filename length for binary files so that scaling won't be\ntriggered and result in invalid string access.\n\nSigned-off-by: Jonas Fonseca <fonseca@diku.dk>\n\n---\n\n diff.c |    7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex b54bbfa..ddcfb84 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -250,13 +250,14 @@ static void show_stats(struct diffstat_t\n \tfor (i = 0; i < data->nr; i++) {\n \t\tstruct diffstat_file *file = data->files[i];\n \n+\t\tlen = strlen(file->name);\n+\t\tif (max_len < len)\n+\t\t\tmax_len = len;\n+\n \t\tif (file->is_binary || file->is_unmerged)\n \t\t\tcontinue;\n \t\tif (max_change < file->added + file->deleted)\n \t\t\tmax_change = file->added + file->deleted;\n-\t\tlen = strlen(file->name);\n-\t\tif (max_len < len)\n-\t\t\tmax_len = len;\n \t}\n \n \tfor (i = 0; i < data->nr; i++) {\n\n-- \nJonas Fonseca\n"}]}