{"thread":{"id":"39094","subject":"[PATCH] test-lib-functions.sh: fix the second argument to some helper functions","startedAt":"2015-04-16T14:12:07Z","lastAt":"2015-04-20T11:03:30Z","messageCount":4,"participants":["Elia Pinto","Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"259496","messageId":"1429193527-1528-1-git-send-email-gitter.spiros@gmail.com","threadId":"39094","inReplyTo":null,"subject":"[PATCH] test-lib-functions.sh: fix the second argument to some helper functions","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2015-04-16T14:12:07Z","receivedAt":"2015-04-16T14:12:07Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The second argument to test_path_is_file and test_path_is_dir\nmust be $2 and not $*, which instead would repeat the file\nname in the error message.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/test-lib-functions.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh\nindex 0698ce7..8f8858a 100644\n--- a/t/test-lib-functions.sh\n+++ b/t/test-lib-functions.sh\n@@ -478,7 +478,7 @@ test_external_without_stderr () {\n test_path_is_file () {\n \tif ! test -f \"$1\"\n \tthen\n-\t\techo \"File $1 doesn't exist. $*\"\n+\t\techo \"File $1 doesn't exist. $2\"\n \t\tfalse\n \tfi\n }\n@@ -486,7 +486,7 @@ test_path_is_file () {\n test_path_is_dir () {\n \tif ! test -d \"$1\"\n \tthen\n-\t\techo \"Directory $1 doesn't exist. $*\"\n+\t\techo \"Directory $1 doesn't exist. $2\"\n \t\tfalse\n \tfi\n }\n-- \n2.1.0\n"},{"id":"259497","messageId":"vpqoamop28y.fsf@anie.imag.fr","threadId":"39094","inReplyTo":"1429193527-1528-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-04-16T14:38:21Z","receivedAt":"2015-04-16T14:38:21Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Elia Pinto <gitter.spiros@gmail.com> writes:\n\n> --- a/t/test-lib-functions.sh\n> +++ b/t/test-lib-functions.sh\n> @@ -478,7 +478,7 @@ test_external_without_stderr () {\n>  test_path_is_file () {\n>  \tif ! test -f \"$1\"\n>  \tthen\n> -\t\techo \"File $1 doesn't exist. $*\"\n> +\t\techo \"File $1 doesn't exist. $2\"\n>  \t\tfalse\n>  \tfi\n>  }\n> @@ -486,7 +486,7 @@ test_path_is_file () {\n>  test_path_is_dir () {\n>  \tif ! test -d \"$1\"\n>  \tthen\n> -\t\techo \"Directory $1 doesn't exist. $*\"\n> +\t\techo \"Directory $1 doesn't exist. $2\"\n>  \t\tfalse\n>  \tfi\n>  }\n\nSounds straightforwardly correct to me.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"259539","messageId":"xmqq8udrizmk.fsf@gitster.dls.corp.google.com","threadId":"39094","inReplyTo":"vpqoamop28y.fsf@anie.imag.fr","subject":"Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-04-16T20:31:31Z","receivedAt":"2015-04-16T20:31:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:\n\n> Elia Pinto <gitter.spiros@gmail.com> writes:\n>\n>> --- a/t/test-lib-functions.sh\n>> +++ b/t/test-lib-functions.sh\n>> @@ -478,7 +478,7 @@ test_external_without_stderr () {\n>>  test_path_is_file () {\n>>  \tif ! test -f \"$1\"\n>>  \tthen\n>> -\t\techo \"File $1 doesn't exist. $*\"\n>> +\t\techo \"File $1 doesn't exist. $2\"\n>>  \t\tfalse\n>>  \tfi\n>>  }\n>> @@ -486,7 +486,7 @@ test_path_is_file () {\n>>  test_path_is_dir () {\n>>  \tif ! test -d \"$1\"\n>>  \tthen\n>> -\t\techo \"Directory $1 doesn't exist. $*\"\n>> +\t\techo \"Directory $1 doesn't exist. $2\"\n>>  \t\tfalse\n>>  \tfi\n>>  }\n>\n> Sounds straightforwardly correct to me.\n\nThanks.  This however makes me wonder why you were nominated for\nreviewing this patch, though...\n"},{"id":"259670","messageId":"vpqa8y3giyl.fsf@anie.imag.fr","threadId":"39094","inReplyTo":"xmqq8udrizmk.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-04-20T11:03:30Z","receivedAt":"2015-04-20T11:03:30Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:\n>\n>> Elia Pinto <gitter.spiros@gmail.com> writes:\n>>\n>>> --- a/t/test-lib-functions.sh\n>>> +++ b/t/test-lib-functions.sh\n>>> @@ -478,7 +478,7 @@ test_external_without_stderr () {\n>>>  test_path_is_file () {\n>>>  \tif ! test -f \"$1\"\n>>>  \tthen\n>>> -\t\techo \"File $1 doesn't exist. $*\"\n>>> +\t\techo \"File $1 doesn't exist. $2\"\n>>>  \t\tfalse\n>>>  \tfi\n>>>  }\n>>> @@ -486,7 +486,7 @@ test_path_is_file () {\n>>>  test_path_is_dir () {\n>>>  \tif ! test -d \"$1\"\n>>>  \tthen\n>>> -\t\techo \"Directory $1 doesn't exist. $*\"\n>>> +\t\techo \"Directory $1 doesn't exist. $2\"\n>>>  \t\tfalse\n>>>  \tfi\n>>>  }\n>>\n>> Sounds straightforwardly correct to me.\n>\n> Thanks.  This however makes me wonder why you were nominated for\n> reviewing this patch, though...\n\nIt seems I'm the one who introduced the bug indeed, in 2caf20c52b7f6.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}