{"thread":{"id":"39091","subject":"[bug] first line truncated with `git log --oneline --decorate --graph`","startedAt":"2015-04-16T10:14:29Z","lastAt":"2015-04-17T07:14:37Z","messageCount":10,"participants":["Robin Moussu","Junio C Hamano","Johannes Schindelin","David Miller","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"259482","messageId":"552F8B85.2000908@gmail.com","threadId":"39091","inReplyTo":null,"subject":"[bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Robin Moussu","fromEmail":"robin.moussu@gmail.com","sentAt":"2015-04-16T10:14:29Z","receivedAt":"2015-04-16T10:14:29Z","isPatch":false,"sender":{"key":"robin.moussu@gmail.com","avatar":null},"body":"I have a bug using the following command:\n\n    git log --oneline --decorate --graph\n\nIn short, the first line of the log is often truncated.\n\n\nIf the terminal is too small to display all the text (~100 columns, and too\nmuch text to fit on the high of screen, in this example less than 4\nlines), I\nactually see:\n\nIf my history is:\n\n*   4656b73 (HEAD, long_branch_name_and_long_commit_name) Merge commit\n'f7f6e4736ad040a1238644a33b681a66c79fac0e' into HEAD\n|\\\n| * f7f6e47 (master) Praesent et diam eget libero egestas mattis sit\namet vitae augue.\n| * 8dccb9d Maecenas congue ligula ac quam viverra nec consectetur ante\nhendrerit.\n|/\n* f7724a2 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec\na diam lectus.\n\nIf my screen is not high enough, I see:\n\n1238644a33b681a66c79fac0e' into HEAD\n|\\ \n| * f7f6e47 (master) Praesent et diam eget libero egestas mattis sit\namet vitae augue.\n| * 8dccb9d Maecenas congue ligula ac quam viverra nec consectetur ante\nhendrerit.\n# next message truncated, because the screen is too small\n\ninstead of:\n*   4656b73 (HEAD, long_branch_name_and_long_commit_name) Merge commit\n'f7f6e4736ad040a1238644a33b681a66c79fac0e' into HEAD\n|\\\n| * f7f6e47 (master) Praesent et diam eget libero egestas mattis sit\namet vitae augue.\n| * 8dccb9d Maecenas congue ligula ac quam viverra nec consectetur ante\nhendrerit.\n# next message truncated, because the screen is too small\n\nAs you can see, the first line is truncated.\n\nIf I use:\n    git log --pretty=oneline --all --decorate --graph\ninstead of:\n    git log --oneline --all --decorate --graph\nthe problem is the same (first line truncated).\n\nI have see that bug using terminology or xterm, with bash (without\n.bashrc) or zsh\n(lots of things in my .zshrc), and my desktop environment is\ni3/archlinux/git\nversion 2.3.5 It is not a recent regression (if it is, I've learn git\none year\nago).\n\n# How to reproduce\n\nOpen a small terminal windows (4*100)\n\n    mkdir tmp\n    cd tmp\n    git init\n    git commit --allow-empty -m 'Lorem ipsum dolor sit amet, consectetur\nadipiscing elit. Donec a diam lectus.'\n    git checkout -b long_branch_name_and_long_commit_name\n    git commit --allow-empty -m 'Maecenas congue ligula ac quam viverra\nnec consectetur ante hendrerit.'\n    git commit --allow-empty -m 'Praesent et diam eget libero egestas\nmattis sit amet vitae augue.'\n    git checkout master\n    git merge --no-ff long_branch_name_and_long_commit_name -m 'merge\nwith a long commit message'\n    git checkout long_branch_name_and_long_commit_name\n    git merge master\n    git log --oneline  --decorate --graph\n\nI hope it is clear. The English is not my mother tongue.\n--\nRobin Moussu\n//\n\n"},{"id":"259504","messageId":"xmqqwq1chz2s.fsf@gitster.dls.corp.google.com","threadId":"39091","inReplyTo":"552F8B85.2000908@gmail.com","subject":"Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-04-16T15:28:43Z","receivedAt":"2015-04-16T15:28:43Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robin Moussu <robin.moussu@gmail.com> writes:\n\n> I have a bug using the following command:\n>\n>     git log --oneline --decorate --graph\n>\n> In short, the first line of the log is often truncated.\n> ...\n> # How to reproduce\n>\n> Open a small terminal windows (4*100)\n>\n>     mkdir tmp\n>     cd tmp\n>     git init\n>     git commit --allow-empty -m 'Lorem ipsum dolor sit amet, consectetur\n> adipiscing elit. Donec a diam lectus.'\n>     git checkout -b long_branch_name_and_long_commit_name\n>     git commit --allow-empty -m 'Maecenas congue ligula ac quam viverra\n> nec consectetur ante hendrerit.'\n>     git commit --allow-empty -m 'Praesent et diam eget libero egestas\n> mattis sit amet vitae augue.'\n>     git checkout master\n>     git merge --no-ff long_branch_name_and_long_commit_name -m 'merge\n> with a long commit message'\n>     git checkout long_branch_name_and_long_commit_name\n>     git merge master\n>     git log --oneline  --decorate --graph\n>\n> I hope it is clear. The English is not my mother tongue.\n\nIt is clear and it does not reproduce for me.  I see\n\n--------\n*   5eff3a3 (HEAD -> long_branch_name_and_long_commit_name, master) merge with a long commit message\n|\\  \n| * 61e21f3 Praesent et diam eget libero egestas mattis sit amet vitae augue.\n:\n--------\n\nwhich looks perfectly sensible (my terminal is a \"screen\" running\non a Ubuntu machine, displaying to a SecureShell terminal on a\nChromebook).\n\nCan you try running that problematic \"git log\" with its standard\noutput redirected to a file (i.e. \"git log ... >output\") and then\nrun your pager in that wide-but-short terminal (i.e. \"less output\"),\nto see if the same problem is observed?  And then run \"cat output\"\nin a taller terminal with the same width to see if it is the output\nfrom \"git log\" that is causing you the problem?\n"},{"id":"259506","messageId":"7139e45030c23bb642c5fe35e4074c6a@www.dscho.org","threadId":"39091","inReplyTo":"xmqqwq1chz2s.fsf@gitster.dls.corp.google.com","subject":"Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-04-16T15:42:34Z","receivedAt":"2015-04-16T15:42:34Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn 2015-04-16 17:28, Junio C Hamano wrote:\n> Robin Moussu <robin.moussu@gmail.com> writes:\n> \n>> I have a bug using the following command:\n>>\n>>     git log --oneline --decorate --graph\n>>\n>> In short, the first line of the log is often truncated.\n\nI imagine that the pager (`less`) cuts off the lines because we start it with the `-S` option.\n\nRobin, if the pager does not quit right away and you see a truncated line, could you try to press the keys `-`, `Shift+S`, `<Enter>` and see whether they are \"untruncated\"?\n\nCiao,\nJohannes\n"},{"id":"259509","messageId":"20150416.115628.1228076242478955092.davem@davemloft.net","threadId":"39091","inReplyTo":"7139e45030c23bb642c5fe35e4074c6a@www.dscho.org","subject":"Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"David Miller","fromEmail":"davem@davemloft.net","sentAt":"2015-04-16T15:56:28Z","receivedAt":"2015-04-16T15:56:28Z","isPatch":false,"sender":{"key":"davem@davemloft.net","avatar":null},"body":"\nHey folks, please remove git-owner from the CC: list, that goes\nto me and not the list :-)\n"},{"id":"259513","messageId":"6ebf8090f8246f9880f2bd94d494c872@www.dscho.org","threadId":"39091","inReplyTo":"20150416.115628.1228076242478955092.davem@davemloft.net","subject":"git-owner, was Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-04-16T16:11:47Z","receivedAt":"2015-04-16T16:11:47Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi David,\n\nOn 2015-04-16 17:56, David Miller wrote:\n> Hey folks, please remove git-owner from the CC: list, that goes\n> to me and not the list :-)\n\nI feared as much, but I cannot recall putting you on any Cc: myself. It appeared to me as if the list added git-owner@vger as sender, at least under *some* circumstances...\n\nCiao,\nDscho\n"},{"id":"259514","messageId":"20150416162620.GA10573@peff.net","threadId":"39091","inReplyTo":"6ebf8090f8246f9880f2bd94d494c872@www.dscho.org","subject":"Re: git-owner, was Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-04-16T16:26:21Z","receivedAt":"2015-04-16T16:26:21Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"[retaining davem in cc in case he is curious, and hopefully does not\n see this as more spam :) ]\n\nOn Thu, Apr 16, 2015 at 06:11:47PM +0200, Johannes Schindelin wrote:\n\n> On 2015-04-16 17:56, David Miller wrote:\n> > Hey folks, please remove git-owner from the CC: list, that goes\n> > to me and not the list :-)\n> \n> I feared as much, but I cannot recall putting you on any Cc: myself.\n> It appeared to me as if the list added git-owner@vger as sender, at\n> least under *some* circumstances...\n\nWeird. In a nearby thread with the same problem, the first email that\nmentions git-owner in a cc header is yours[1]. It's in reply to a\nmessage that does not mention git-owner at all[2], except in the\n\"Sender\" field. Your agent header looks like:\n\n  User-Agent: Roundcube Webmail/1.1.0\n\nMaybe their \"reply to all\" function is a little over-zealous?\n\nMessages from you from a few days ago do not show this problem, but\nseveral starting on the 15th do. I don't see anything changing in the\nmessages from the list. Maybe your webmail provider changed something?\nOr maybe it is a difference between replying to the version that came\nthrough the list rather than one that came straight to you.\n\n-Peff\n\n[1,2] Rather than link to an archive, I'll attach full messages as I\n      received them to make sure the headers are intact.\n"},{"id":"259515","messageId":"20150416.123109.141223786207291496.davem@davemloft.net","threadId":"39091","inReplyTo":"20150416162620.GA10573@peff.net","subject":"Re: git-owner, was Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"David Miller","fromEmail":"davem@davemloft.net","sentAt":"2015-04-16T16:31:09Z","receivedAt":"2015-04-16T16:31:09Z","isPatch":false,"sender":{"key":"davem@davemloft.net","avatar":null},"body":"From: Jeff King <peff@peff.net>\nDate: Thu, 16 Apr 2015 12:26:21 -0400\n\n> Weird. In a nearby thread with the same problem, the first email that\n> mentions git-owner in a cc header is yours[1]. It's in reply to a\n> message that does not mention git-owner at all[2], except in the\n> \"Sender\" field. Your agent header looks like:\n> \n>   User-Agent: Roundcube Webmail/1.1.0\n> \n> Maybe their \"reply to all\" function is a little over-zealous?\n\nThis is always caused by broken reply list handling in email clients.\n"},{"id":"259516","messageId":"552FE94C.5070302@gmail.com","threadId":"39091","inReplyTo":"6ebf8090f8246f9880f2bd94d494c872@www.dscho.org","subject":"Re: git-owner, was Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Robin Moussu","fromEmail":"robin.moussu@gmail.com","sentAt":"2015-04-16T16:54:36Z","receivedAt":"2015-04-16T16:54:36Z","isPatch":false,"sender":{"key":"robin.moussu@gmail.com","avatar":null},"body":"Hi Junio and Johanes,\nIt was effectively a less problem, and not a git problem.\nMy $LESS is '-r'. If I make \"export LESS='-R' \", it is fixed.\n\nThanks a lot.\nCheers.\nRobin.\n\n"},{"id":"259517","messageId":"ef9e69f60275dc7edb2dff8e65952630@www.dscho.org","threadId":"39091","inReplyTo":"20150416.123109.141223786207291496.davem@davemloft.net","subject":"Re: git-owner, was Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-04-16T17:06:25Z","receivedAt":"2015-04-16T17:06:25Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"On 2015-04-16 18:31, David Miller wrote:\n> From: Jeff King <peff@peff.net>\n> Date: Thu, 16 Apr 2015 12:26:21 -0400\n> \n>> Weird. In a nearby thread with the same problem, the first email that\n>> mentions git-owner in a cc header is yours[1]. It's in reply to a\n>> message that does not mention git-owner at all[2], except in the\n>> \"Sender\" field. Your agent header looks like:\n>>\n>>   User-Agent: Roundcube Webmail/1.1.0\n>>\n>> Maybe their \"reply to all\" function is a little over-zealous?\n> \n> This is always caused by broken reply list handling in email clients.\n\nThat must be it. Dave, my apologies! Will investigate *right now*.\n"},{"id":"259555","messageId":"e50ad4a89b2a62ccc448e19321f97879@www.dscho.org","threadId":"39091","inReplyTo":"ef9e69f60275dc7edb2dff8e65952630@www.dscho.org","subject":"Re: git-owner, was Re: [bug] first line truncated with `git log --oneline --decorate --graph`","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-04-17T07:14:37Z","receivedAt":"2015-04-17T07:14:37Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Dave,\n\nOn 2015-04-16 19:06, Johannes Schindelin wrote:\n> On 2015-04-16 18:31, David Miller wrote:\n>> From: Jeff King <peff@peff.net>\n>> Date: Thu, 16 Apr 2015 12:26:21 -0400\n>>\n>>> Weird. In a nearby thread with the same problem, the first email that\n>>> mentions git-owner in a cc header is yours[1]. It's in reply to a\n>>> message that does not mention git-owner at all[2], except in the\n>>> \"Sender\" field. Your agent header looks like:\n>>>\n>>>   User-Agent: Roundcube Webmail/1.1.0\n>>>\n>>> Maybe their \"reply to all\" function is a little over-zealous?\n>>\n>> This is always caused by broken reply list handling in email clients.\n> \n> That must be it. Dave, my apologies! Will investigate *right now*.\n\nWith the help of Peff, who identified the culprit (http://trac.roundcube.net/ticket/1489011 introduces this bug, but maintains to fix one), I was able to fix this on my side: https://github.com/dscho/roundcubemail/commit/baec39d\n\nPlease accept my sincerest apologies,\nJohannes\n"}]}