{"thread":{"id":"39057","subject":"[PATCH] CodingGuidelines: updating 'rough' rule count","startedAt":"2015-04-12T23:47:20Z","lastAt":"2015-04-13T17:30:02Z","messageCount":7,"participants":["Julian Gindi","Eric Sunshine","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"259269","messageId":"20150412234720.GA37658@Serenity.local","threadId":"39057","inReplyTo":null,"subject":"[PATCH] CodingGuidelines: updating 'rough' rule count","fromName":"Julian Gindi","fromEmail":"juliangindi@gmail.com","sentAt":"2015-04-12T23:47:20Z","receivedAt":"2015-04-12T23:47:20Z","isPatch":true,"sender":{"key":"juliangindi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/776248?v=4"},"body":"Changed inaccurate count of \"rough rules\" from three to four.\n\nSigned-off-by: Julian Gindi \n---\n Documentation/CodingGuidelines | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\nindex 0f8cccf..c422ecd 100644\n--- a/Documentation/CodingGuidelines\n+++ b/Documentation/CodingGuidelines\n@@ -1,5 +1,5 @@\n Like other projects, we also have some guidelines to keep to the\n-code. For Git in general, three rough rules are:\n+code. For Git in general, four rough rules are:\n \n - Most importantly, we never say \"It's in POSIX; we'll happily\n ignore your needs should your system not conform to it.\"\n-- \n2.3.5\n"},{"id":"259270","messageId":"CAPig+cS=xBoe-hr5Kwm0N9hBUy4bzN1NoXTcDEwz_4ZwrrXPXA@mail.gmail.com","threadId":"39057","inReplyTo":"20150412234720.GA37658@Serenity.local","subject":"Re: [PATCH] CodingGuidelines: updating 'rough' rule count","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2015-04-13T00:04:04Z","receivedAt":"2015-04-13T00:04:04Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Apr 12, 2015 at 7:47 PM, Julian Gindi wrote:\n> Changed inaccurate count of \"rough rules\" from three to four.\n>\n> Signed-off-by: Julian Gindi \n> ---\n> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n> index 0f8cccf..c422ecd 100644\n> --- a/Documentation/CodingGuidelines\n> +++ b/Documentation/CodingGuidelines\n> @@ -1,5 +1,5 @@\n> Like other projects, we also have some guidelines to keep to the\n> -code. For Git in general, three rough rules are:\n> +code. For Git in general, four rough rules are:\n\nAlthough this change is technically accurate, this sentence is still a\npotential maintenance burden. How about taking a more generic\napproach, and saying something like:\n\n For Git, in general, the rough rules are:\n\n?\n\n> - Most importantly, we never say \"It's in POSIX; we'll happily\n> ignore your needs should your system not conform to it.\"\n> --\n> 2.3.5\n"},{"id":"259272","messageId":"20150413042644.GA39596@Serenity.local","threadId":"39057","inReplyTo":"CAPig+cS=xBoe-hr5Kwm0N9hBUy4bzN1NoXTcDEwz_4ZwrrXPXA@mail.gmail.com","subject":"Re: [PATCH v2] CodingGuidelines: updating 'rough' rule count","fromName":"Julian Gindi","fromEmail":"juliangindi@gmail.com","sentAt":"2015-04-13T04:26:44Z","receivedAt":"2015-04-13T04:26:44Z","isPatch":true,"sender":{"key":"juliangindi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/776248?v=4"},"body":" Changed inaccurate count of \"rough rules\" from three to the more\n generic 'a few'.\n---\n Documentation/CodingGuidelines | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\nindex 0f8cccf..2dd35bd 100644\n--- a/Documentation/CodingGuidelines\n+++ b/Documentation/CodingGuidelines\n@@ -1,5 +1,5 @@\n Like other projects, we also have some guidelines to keep to the\n-code. For Git in general, three rough rules are:\n+code. For Git in general, a few rough rules are:\n \n - Most importantly, we never say \"It's in POSIX; we'll happily\n ignore your needs should your system not conform to it.\"\n-- \n2.3.5\n"},{"id":"259274","messageId":"CAPig+cTgNzO5NGabOsaSZOq7Y47OBXJz9mnS-MfpoQ2MANzrng@mail.gmail.com","threadId":"39057","inReplyTo":"20150413042644.GA39596@Serenity.local","subject":"Re: [PATCH v2] CodingGuidelines: updating 'rough' rule count","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2015-04-13T05:00:11Z","receivedAt":"2015-04-13T05:00:11Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Apr 13, 2015 at 12:26 AM, Julian Gindi wrote:\n> CodingGuidelines: updating 'rough' rule count\n\nImperative mood is preferred, so \"update\" rather than \"updating\":\n\n CodingGuidelines: update 'rough' rule count\n\n> Changed inaccurate count of \"rough rules\" from three to the more\n> generic 'a few'.\n\nImperative: s/Changed/Change/\n\n> ---\n\nMissing sign-off.\n\n> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\n> index 0f8cccf..2dd35bd 100644\n> --- a/Documentation/CodingGuidelines\n> +++ b/Documentation/CodingGuidelines\n> @@ -1,5 +1,5 @@\n> Like other projects, we also have some guidelines to keep to the\n> -code. For Git in general, three rough rules are:\n> +code. For Git in general, a few rough rules are:\n\nLooks better, thanks.\n\n> - Most importantly, we never say \"It's in POSIX; we'll happily\n> ignore your needs should your system not conform to it.\"\n> --\n> 2.3.5\n"},{"id":"259275","messageId":"CAPig+cQ3z_UuUMZE_jUGbv1_3Fu_32GSw2ysSixw4VE0opz27w@mail.gmail.com","threadId":"39057","inReplyTo":"CAPig+cTgNzO5NGabOsaSZOq7Y47OBXJz9mnS-MfpoQ2MANzrng@mail.gmail.com","subject":"Re: [PATCH v2] CodingGuidelines: updating 'rough' rule count","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2015-04-13T05:04:36Z","receivedAt":"2015-04-13T05:04:36Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Apr 13, 2015 at 1:00 AM, Eric Sunshine wrote:\n> On Mon, Apr 13, 2015 at 12:26 AM, Julian Gindi wrote:\n>> Changed inaccurate count of \"rough rules\" from three to the more\n>> generic 'a few'.\n>\n> Imperative: s/Changed/Change/\n\nI forgot to mention the unusual 2-space indentation of the log\nmessage. It should be left-justified.\n"},{"id":"259288","messageId":"20150413125414.GA1038@Serenity.local","threadId":"39057","inReplyTo":"CAPig+cQ3z_UuUMZE_jUGbv1_3Fu_32GSw2ysSixw4VE0opz27w@mail.gmail.com","subject":"Re: [PATCH v3] CodingGuidelines: update 'rough' rule count","fromName":"Julian Gindi","fromEmail":"juliangindi@gmail.com","sentAt":"2015-04-13T12:54:14Z","receivedAt":"2015-04-13T12:54:14Z","isPatch":true,"sender":{"key":"juliangindi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/776248?v=4"},"body":"Changed inaccurate count of \"rough rules\" from three to the more\ngeneric 'a few'.\n\nSigned-off-by: Julian Gindi \n---\n Documentation/CodingGuidelines | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines\nindex 0f8cccf..2dd35bd 100644\n--- a/Documentation/CodingGuidelines\n+++ b/Documentation/CodingGuidelines\n@@ -1,5 +1,5 @@\n Like other projects, we also have some guidelines to keep to the\n-code. For Git in general, three rough rules are:\n+code. For Git in general, a few rough rules are:\n \n - Most importantly, we never say \"It's in POSIX; we'll happily\n ignore your needs should your system not conform to it.\"\n-- \n2.3.5\n"},{"id":"259307","messageId":"20150413173002.GC5467@google.com","threadId":"39057","inReplyTo":"20150413125414.GA1038@Serenity.local","subject":"Re: [PATCH v3] CodingGuidelines: update 'rough' rule count","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2015-04-13T17:30:02Z","receivedAt":"2015-04-13T17:30:02Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Julian Gindi wrote:\n\n> Changed inaccurate count of \"rough rules\" from three to the more\n> generic 'a few'.\n>\n> Signed-off-by: Julian Gindi \n\nReviewed-by: Jonathan Nieder \n\nThanks.\n"}]}