{"thread":{"id":"39030","subject":"[PATCH] gitk: Use translated version of \"Command line\" in getcommitlines.","startedAt":"2015-04-07T15:53:37Z","lastAt":"2015-05-17T04:29:35Z","messageCount":2,"participants":["Marc Branchaud","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"259138","messageId":"1428422017-20645-1-git-send-email-marcnarc@xiplink.com","threadId":"39030","inReplyTo":null,"subject":"[PATCH] gitk: Use translated version of \"Command line\" in getcommitlines.","fromName":"Marc Branchaud","fromEmail":"marcnarc@xiplink.com","sentAt":"2015-04-07T15:53:37Z","receivedAt":"2015-04-07T15:53:37Z","isPatch":true,"sender":{"key":"marcnarc@xiplink.com","avatar":"https://avatars.githubusercontent.com/u/14980203?v=4"},"body":"Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>\n---\n\nI noticed this today.  I think this change is needed for getcommitlines to\nwork properly with translated gitk's.\n\n\t\tM.\n\n gitk | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitk b/gitk\nindex 90419e3..fd5b50a 100755\n--- a/gitk\n+++ b/gitk\n@@ -1442,7 +1442,7 @@ proc getcommitlines {fd inst view updating}  {\n \t    if {[string range $err 0 4] == \"usage\"} {\n \t\tset err \"Gitk: error reading commits$fv:\\\n \t\t\tbad arguments to git log.\"\n-\t\tif {$viewname($view) eq \"Command line\"} {\n+\t\tif {$viewname($view) eq [mc \"Command line\"]} {\n \t\t    append err \\\n \t\t\t\"  (Note: arguments to gitk are passed to git log\\\n \t\t\t to allow selection of commits to be displayed.)\"\n-- \n2.3.5\n"},{"id":"261405","messageId":"20150517042935.GF21039@iris.ozlabs.ibm.com","threadId":"39030","inReplyTo":"1428422017-20645-1-git-send-email-marcnarc@xiplink.com","subject":"Re: [PATCH] gitk: Use translated version of \"Command line\" in getcommitlines.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2015-05-17T04:29:35Z","receivedAt":"2015-05-17T04:29:35Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Tue, Apr 07, 2015 at 11:53:37AM -0400, Marc Branchaud wrote:\n> Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>\n> ---\n> \n> I noticed this today.  I think this change is needed for getcommitlines to\n> work properly with translated gitk's.\n\nThanks, applied.\n\nPaul.\n"}]}