{"thread":{"id":"39024","subject":"Bug: global bash variable leak on __gitcompappend","startedAt":"2015-04-07T08:42:23Z","lastAt":"2015-04-07T08:42:23Z","messageCount":1,"participants":["Marcio Almada"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"259119","messageId":"CAOsHV+vG9CfPTTj1AmvSU_fziFtmLCJ67QGAnV11p3y+FDCBnQ@mail.gmail.com","threadId":"39024","inReplyTo":null,"subject":"Bug: global bash variable leak on __gitcompappend","fromName":"Marcio Almada","fromEmail":"marcio.web2@gmail.com","sentAt":"2015-04-07T08:42:23Z","receivedAt":"2015-04-07T08:42:23Z","isPatch":false,"sender":{"key":"marcio.web2@gmail.com","avatar":"https://avatars.githubusercontent.com/u/227395?v=4"},"body":"Hi,\n\nThis is how to reproduce the bug:\n\n```\ngit checkout [tab-tab]\necho $x # outputs the name of the last branch on completion list\n```\n\nOr more directly:\n\n```\n__gitcompappend \"something\"\necho $x # outputs 'something'\n```\n\nNo big deal, but it's annoying to know that `$x` is lurking.\n\nCheers,\nMárcio Almada.\n\n\nFrom 9ff849272f80f5e21a681995ed9aecfffcaf2a87 Mon Sep 17 00:00:00 2001\nFrom: =?UTF-8?q?M=C3=A1rcio=20Almada?= <marcio3w@gmail.com>\nDate: Tue, 7 Apr 2015 05:11:35 -0300\nSubject: [PATCH] fix global bash variable leak on __gitcompappend\n\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex fbe5972..5944c82 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -186,7 +186,7 @@ fi\n \n __gitcompappend ()\n {\n-\tlocal i=${#COMPREPLY[@]}\n+\tlocal x i=${#COMPREPLY[@]}\n \tfor x in $1; do\n \t\tif [[ \"$x\" == \"$3\"* ]]; then\n \t\t\tCOMPREPLY[i++]=\"$2$x$4\"\n-- \n1.9.3\n\n"}]}