{"thread":{"id":"38986","subject":"[PATCH] gitk: Remove mc parameter from proc show_error","startedAt":"2015-04-02T21:05:35Z","lastAt":"2015-04-06T03:33:52Z","messageCount":2,"participants":["Alex Henrie","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"258894","messageId":"1428008735-10943-1-git-send-email-alexhenrie24@gmail.com","threadId":"38986","inReplyTo":null,"subject":"[PATCH] gitk: Remove mc parameter from proc show_error","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-04-02T21:05:35Z","receivedAt":"2015-04-02T21:05:35Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"This partially reverts commit 8d849957d81fc0480a52570d66cc3c2a688ecb1b.\n\nThis change makes the string \"OK\" translatable and the string \"mc\" not\ntranslatable. It will take effect the next time `make update-po` is run.\n\nSigned-off-by: Alex Henrie <alexhenrie24@gmail.com>\n---\n gitk | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 30fcd30..7193f6f 100755\n--- a/gitk\n+++ b/gitk\n@@ -1894,13 +1894,13 @@ proc make_transient {window origin} {\n     }\n }\n \n-proc show_error {w top msg {mc mc}} {\n+proc show_error {w top msg} {\n     global NS\n     if {![info exists NS]} {set NS \"\"}\n     if {[wm state $top] eq \"withdrawn\"} { wm deiconify $top }\n     message $w.m -text $msg -justify center -aspect 400\n     pack $w.m -side top -fill x -padx 20 -pady 20\n-    ${NS}::button $w.ok -default active -text [$mc OK] -command \"destroy $top\"\n+    ${NS}::button $w.ok -default active -text [mc OK] -command \"destroy $top\"\n     pack $w.ok -side bottom -fill x\n     bind $top <Visibility> \"grab $top; focus $top\"\n     bind $top <Key-Return> \"destroy $top\"\n-- \n2.3.5\n"},{"id":"259046","messageId":"20150406033352.GB26765@iris.ozlabs.ibm.com","threadId":"38986","inReplyTo":"1428008735-10943-1-git-send-email-alexhenrie24@gmail.com","subject":"Re: [PATCH] gitk: Remove mc parameter from proc show_error","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2015-04-06T03:33:52Z","receivedAt":"2015-04-06T03:33:52Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Thu, Apr 02, 2015 at 03:05:35PM -0600, Alex Henrie wrote:\n> This partially reverts commit 8d849957d81fc0480a52570d66cc3c2a688ecb1b.\n\n... and brings back the bug that 8d849957d81f solves, as far as I can\nsee.  If that's not the case then you need to explain that in the\npatch description.\n\nPaul.\n"}]}