{"thread":{"id":"38982","subject":"gitk won't show notes?","startedAt":"2015-04-02T19:34:17Z","lastAt":"2015-04-14T20:53:21Z","messageCount":9,"participants":["Phillip Susi","Michael J Gruber","Paul Mackerras","Christian Couder","Johan Herland"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"258879","messageId":"551D99B9.7040200@ubuntu.com","threadId":"38982","inReplyTo":null,"subject":"gitk won't show notes?","fromName":"Phillip Susi","fromEmail":"psusi@ubuntu.com","sentAt":"2015-04-02T19:34:17Z","receivedAt":"2015-04-02T19:34:17Z","isPatch":false,"sender":{"key":"psusi@ubuntu.com","avatar":null},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nI can't seem to get gitk to show notes, even when I give it --notes.\nDoes it just not handle notes?\n\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v2.0.17 (MingW32)\n\niQEcBAEBAgAGBQJVHZm5AAoJENRVrw2cjl5RT0wIAJVfE2cDQODUCoOsIwhVDiMf\nCNeTKy1VxCgwVy8KDoYxY2hBlDIRELkcVIkN5ueNVu57LZ+1z/iBUhgr3mmzH9br\nz2viRjkKRlNSqP/b+HwK0+GxBIbN/FpIEyKTPe558SMcUjCkeINfxfcgYYbmY4Rv\naY60j4LMQCEgltkmyDJ/kRX1I7Pr4YCfwNfoIQj3LxvCY5WL7VGn7QmM56Qh9m8P\nDVvTdMHBnhLOTCSa79/uAAZKJxVNE7z8YnHw1aimNXs/uwm7DYl4coxXVGDxyUfm\nDnEDcqtLfFst58UtLDRn7f3YawT7heeeXJ7tKUAizX3YQuTTRp9WrN12yE7Crxo=\n=Z23X\n-----END PGP SIGNATURE-----\n"},{"id":"259127","messageId":"5523DE66.8060904@drmicha.warpmail.net","threadId":"38982","inReplyTo":"551D99B9.7040200@ubuntu.com","subject":"Re: gitk won't show notes?","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2015-04-07T13:40:54Z","receivedAt":"2015-04-07T13:40:54Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Phillip Susi venit, vidit, dixit 02.04.2015 21:34:\n> I can't seem to get gitk to show notes, even when I give it --notes.\n> Does it just not handle notes?\n> \n> \n\nHave you tried with \"--show-notes\"?\n\nIt works over here even without --show-notes, by the way, but I'm not on\nWindows. Are you?\n\nMichael\n"},{"id":"259131","messageId":"5523E479.2010701@ubuntu.com","threadId":"38982","inReplyTo":"5523DE66.8060904@drmicha.warpmail.net","subject":"Re: gitk won't show notes?","fromName":"Phillip Susi","fromEmail":"psusi@ubuntu.com","sentAt":"2015-04-07T14:06:49Z","receivedAt":"2015-04-07T14:06:49Z","isPatch":false,"sender":{"key":"psusi@ubuntu.com","avatar":null},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nOn 4/7/2015 9:40 AM, Michael J Gruber wrote:\n> Phillip Susi venit, vidit, dixit 02.04.2015 21:34:\n>> I can't seem to get gitk to show notes, even when I give it\n>> --notes. Does it just not handle notes?\n>> \n>> \n> \n> Have you tried with \"--show-notes\"?\n> \n> It works over here even without --show-notes, by the way, but I'm\n> not on Windows. Are you?\n\nYes... and this just got weird... I shutdown and restarted gitk and\nnow they show up just fine. It seems that adding the note while gitk\nis already open, and hitting refresh fails to detect the note.\n\n\n\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v2.0.17 (MingW32)\n\niQEcBAEBAgAGBQJVI+R5AAoJENRVrw2cjl5RtnoH/RzJRU/FWrRKc+9P2V5OmR2p\nbAto0W92AwQVj4jDL3ndmkgm/RivYwNGYXuRVpLXPjKc0bgKNx8a/w4slnoPiWfv\nHFdIRXGWiJmTLhkzTYHlFLx6uZiDcsz5MV0IW1FhVvqa+QcViTS95yZXtzMj9aj5\ng6w1h8C3NU+XBQNf9mDS7a6Xwd3+TZfXQJT1CQasTlgvHefzCk0aLU8K0G09N1ld\n3XRGY6cCKplEn5CUDuiMLRAiq7XVWpufV0zmT9ZV7h2ZCcY8b9yav/rQPVd5L1cF\nPIagJwyZ6YTR/EAGiVU6w0HZemiXHeXTMNMfv4GCRxGwINtfVzmxhnuD5IvKVZk=\n=b8Ql\n-----END PGP SIGNATURE-----\n"},{"id":"259132","messageId":"5523E5FF.8060101@drmicha.warpmail.net","threadId":"38982","inReplyTo":"5523E479.2010701@ubuntu.com","subject":"Re: gitk won't show notes?","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2015-04-07T14:13:19Z","receivedAt":"2015-04-07T14:13:19Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Phillip Susi venit, vidit, dixit 07.04.2015 16:06:\n> On 4/7/2015 9:40 AM, Michael J Gruber wrote:\n>> Phillip Susi venit, vidit, dixit 02.04.2015 21:34:\n>>> I can't seem to get gitk to show notes, even when I give it\n>>> --notes. Does it just not handle notes?\n>>>\n>>>\n> \n>> Have you tried with \"--show-notes\"?\n> \n>> It works over here even without --show-notes, by the way, but I'm\n>> not on Windows. Are you?\n> \n> Yes... and this just got weird... I shutdown and restarted gitk and\n> now they show up just fine. It seems that adding the note while gitk\n> is already open, and hitting refresh fails to detect the note.\n\nRebooting is the Windows version of refresh ;)\n\nSeriously: gitk knows F5 and Shift-F5 for refresh, and I think the\nlatter is the thorougher refreshment.\n\nMichael\n"},{"id":"259141","messageId":"55240F0A.80902@ubuntu.com","threadId":"38982","inReplyTo":"5523E5FF.8060101@drmicha.warpmail.net","subject":"Re: gitk won't show notes?","fromName":"Phillip Susi","fromEmail":"psusi@ubuntu.com","sentAt":"2015-04-07T17:08:26Z","receivedAt":"2015-04-07T17:08:26Z","isPatch":false,"sender":{"key":"psusi@ubuntu.com","avatar":null},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nOn 4/7/2015 10:13 AM, Michael J Gruber wrote:\n> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the \n> latter is the thorougher refreshment.\n\nNeither one makes newly added notes show up. The only way seems to be\nto close and restart gitk. Looks like a bug.\n\n\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v2.0.17 (MingW32)\n\niQEcBAEBAgAGBQJVJA8KAAoJENRVrw2cjl5RrIgH/2FTWanl7IUyusBMmwR5buLP\nR0yVGf0xF6xzG3SmayDh9EzmhoSJDBFjbqlb8mG1pbgMQfRNKaCjnlk97WRQ5qDr\nX9CHImC4HODZVT/jAgCX5HsCEN62nIZBUfliQOH3PFbbAp6LG/Y/milZk3Ek+srL\nguFFzFsCyv88uAjDJMMM4Ub9Sg3rtKckZ2JeprNv8VDFuqvZWxRPA3G+7TYSTBdE\nwj73xIjyg0KVP1yAR/833TF7srDaRUnB3Z/AfDXAhekYum5TZnEZNQUh1DpiAnus\ndC6T8LWu14PebzmiZy+7QV3cakhlt9ZjrHW9eRBVzY7RAm8JRY1GSgbCQJ0pIQo=\n=EWg/\n-----END PGP SIGNATURE-----\n"},{"id":"259172","messageId":"5525164C.6000309@drmicha.warpmail.net","threadId":"38982","inReplyTo":"55240F0A.80902@ubuntu.com","subject":"Re: gitk won't show notes?","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2015-04-08T11:51:40Z","receivedAt":"2015-04-08T11:51:40Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Phillip Susi venit, vidit, dixit 07.04.2015 19:08:\n> On 4/7/2015 10:13 AM, Michael J Gruber wrote:\n>> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the \n>> latter is the thorougher refreshment.\n> \n> Neither one makes newly added notes show up. The only way seems to be\n> to close and restart gitk. Looks like a bug.\n> \n> \n\nApparently, gitk rereads the refs but not commits it has read already -\nand the commit reading includes the notes lookup.\n\nUnfortunately, my wish-fu is lacking. But I'll cc the master.\n\nPaulus: None of updatecommits, reloadcommits and rereadrefs seem to\nreread the notes of a commit that has been displayed already if the\nnotes have changed (but the other refs have not).\n\nMichael\n"},{"id":"259234","messageId":"20150411103156.GA5781@iris.ozlabs.ibm.com","threadId":"38982","inReplyTo":"5525164C.6000309@drmicha.warpmail.net","subject":"Re: gitk won't show notes?","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2015-04-11T10:31:56Z","receivedAt":"2015-04-11T10:31:56Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Wed, Apr 08, 2015 at 01:51:40PM +0200, Michael J Gruber wrote:\n> Phillip Susi venit, vidit, dixit 07.04.2015 19:08:\n> > On 4/7/2015 10:13 AM, Michael J Gruber wrote:\n> >> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the \n> >> latter is the thorougher refreshment.\n> > \n> > Neither one makes newly added notes show up. The only way seems to be\n> > to close and restart gitk. Looks like a bug.\n> > \n> > \n> \n> Apparently, gitk rereads the refs but not commits it has read already -\n> and the commit reading includes the notes lookup.\n> \n> Unfortunately, my wish-fu is lacking. But I'll cc the master.\n> \n> Paulus: None of updatecommits, reloadcommits and rereadrefs seem to\n> reread the notes of a commit that has been displayed already if the\n> notes have changed (but the other refs have not).\n\nAs far as shift-F5/reloadcommits is concerned, it looks like I should\nbe unsetting commitinfo in reloadcommits.\n\nHowever, I agree gitk should refresh the notes in updatecommits as\nwell, but that will take more work. Is git notes list the best way to\nfind out all the current notes?\n\nPaul.\n"},{"id":"259348","messageId":"CAP8UFD1GRhjgcEomKN4mjxd-+wG0RabbTO=RTk1okCkU2u0FVg@mail.gmail.com","threadId":"38982","inReplyTo":"20150411103156.GA5781@iris.ozlabs.ibm.com","subject":"Re: gitk won't show notes?","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2015-04-14T12:17:38Z","receivedAt":"2015-04-14T12:17:38Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Sat, Apr 11, 2015 at 12:31 PM, Paul Mackerras wrote:\n> On Wed, Apr 08, 2015 at 01:51:40PM +0200, Michael J Gruber wrote:\n>> Phillip Susi venit, vidit, dixit 07.04.2015 19:08:\n>> > On 4/7/2015 10:13 AM, Michael J Gruber wrote:\n>> >> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the\n>> >> latter is the thorougher refreshment.\n>> >\n>> > Neither one makes newly added notes show up. The only way seems to be\n>> > to close and restart gitk. Looks like a bug.\n>> >\n>> >\n>>\n>> Apparently, gitk rereads the refs but not commits it has read already -\n>> and the commit reading includes the notes lookup.\n>>\n>> Unfortunately, my wish-fu is lacking. But I'll cc the master.\n>>\n>> Paulus: None of updatecommits, reloadcommits and rereadrefs seem to\n>> reread the notes of a commit that has been displayed already if the\n>> notes have changed (but the other refs have not).\n>\n> As far as shift-F5/reloadcommits is concerned, it looks like I should\n> be unsetting commitinfo in reloadcommits.\n>\n> However, I agree gitk should refresh the notes in updatecommits as\n> well, but that will take more work. Is git notes list the best way to\n> find out all the current notes?\n\nIt looks like it is from the documentation.\nAnyway let's add some people in Cc in case they could help.\n"},{"id":"259373","messageId":"CALKQrgdxoO8eW9h1_+wDOp7Z0fjcqCWeFAyRjmsMUN+f1XUwnw@mail.gmail.com","threadId":"38982","inReplyTo":"CAP8UFD1GRhjgcEomKN4mjxd-+wG0RabbTO=RTk1okCkU2u0FVg@mail.gmail.com","subject":"Re: gitk won't show notes?","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2015-04-14T20:53:21Z","receivedAt":"2015-04-14T20:53:21Z","isPatch":false,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Tue, Apr 14, 2015 at 2:17 PM, Christian Couder\n wrote:\n> On Sat, Apr 11, 2015 at 12:31 PM, Paul Mackerras wrote:\n>> However, I agree gitk should refresh the notes in updatecommits as\n>> well, but that will take more work. Is git notes list the best way to\n>> find out all the current notes?\n\nYes. (if not, that's a bug and should be fixed).\n\n...Johan\n\n>\n> It looks like it is from the documentation.\n> Anyway let's add some people in Cc in case they could help.\n\n\n\n-- \nJohan Herland, \nwww.herland.net\n"}]}