{"thread":{"id":"38850","subject":"Re:","startedAt":"2015-03-18T20:45:21Z","lastAt":"2015-03-18T21:45:11Z","messageCount":6,"participants":["Junio C Hamano","Stefan Beller","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"257978","messageId":"CAPc5daWNTm5qtd1HJdgQ+-yqUpeMaMmK_UuUiyhxCF6gD3K9dQ@mail.gmail.com","threadId":"38850","inReplyTo":"CANSxx61FaNp5SBXJ8Y+pWn0eDcunmibKR5g8rttnWGdGwEMHCA@mail.gmail.com","subject":"Re:","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-03-18T20:45:21Z","receivedAt":"2015-03-18T20:45:21Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"On Wed, Mar 18, 2015 at 1:33 PM, Alessandro Zanardi\n wrote:\n> Here are other sources describing the issue:\n>\n> http://stackoverflow.com/questions/21109672/git-ignoring-icon-files-because-of-icon-rule\n>\n> http://blog.bitfluent.com/post/173740409/ignoring-icon-in-gitignore\n>\n> Sorry to bother the Git development team with such a minor issue, I just\n> wanted to know if it's already been fixed.\n\nI do not ship your ~/.gitignore_global file as part of my software,\nso the problem is not mine to fix in the first place ;-)\n\nWhere did you get that file from? We need to find whoever is\nresponsible and notify them so that these users who are having\nthe issue will be helped.\n\nThanks.\n"},{"id":"257980","messageId":"CAGZ79kZwmvZyye-3pHCbDgXhuQTQ8OsgtomK7BtR86qqU1koxQ@mail.gmail.com","threadId":"38850","inReplyTo":"CAPc5daWNTm5qtd1HJdgQ+-yqUpeMaMmK_UuUiyhxCF6gD3K9dQ@mail.gmail.com","subject":"Re:","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-03-18T21:06:22Z","receivedAt":"2015-03-18T21:06:22Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Wed, Mar 18, 2015 at 1:45 PM, Junio C Hamano wrote:\n> On Wed, Mar 18, 2015 at 1:33 PM, Alessandro Zanardi\n> wrote:\n>> Here are other sources describing the issue:\n>>\n>> http://stackoverflow.com/questions/21109672/git-ignoring-icon-files-because-of-icon-rule\n>>\n>> http://blog.bitfluent.com/post/173740409/ignoring-icon-in-gitignore\n>>\n>> Sorry to bother the Git development team with such a minor issue, I just\n>> wanted to know if it's already been fixed.\n>\n> I do not ship your ~/.gitignore_global file as part of my software,\n> so the problem is not mine to fix in the first place ;-)\n\nMaybe this can be understood as a critique on the .gitignore format specifier\nfor paths. (Maybe not, I dunno)\n\nSo the `gitignore` script/executable which would generate your .gitignore file\nfor you introduced a bug to also ignore files in \"Icons/....\" when all you\nwanted to have is ignoring the file \"Icon\\r\\r\"\n(Mind that \\r is an escape character to explain the meaning,\ngitignore cannot understand it. Sometimes it also shows up as ^M^M\ndepending on operating system/editor used.)\n\nBut as you can see, there have been several attempts at fixing it right and\nhttps://github.com/github/gitignore/pull/334 eventually got the right fix.\n(it was merged 2012, which has been a while now), maybe\nyou'd want to use a new version of this gitignore script to\nregenerate your gitignore?\n\n>\n> Where did you get that file from? We need to find whoever is\n> responsible and notify them so that these users who are having\n> the issue will be helped.\n\nGiven that this is part of https://github.com/github/gitignore\nwhich is the official collection of .gitignore files from Github,\nthe company, we could ask Jeff or Michael if it is urgent.\nThe actual fix being merged 3 years ago makes me belief\nit is not urgent though.\n\nThanks,\nStefan\n"},{"id":"257983","messageId":"20150318211716.GC3376@peff.net","threadId":"38850","inReplyTo":"CAGZ79kZwmvZyye-3pHCbDgXhuQTQ8OsgtomK7BtR86qqU1koxQ@mail.gmail.com","subject":"Re:","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-03-18T21:17:16Z","receivedAt":"2015-03-18T21:17:16Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Mar 18, 2015 at 02:06:22PM -0700, Stefan Beller wrote:\n\n> > Where did you get that file from? We need to find whoever is\n> > responsible and notify them so that these users who are having\n> > the issue will be helped.\n> \n> Given that this is part of https://github.com/github/gitignore\n> which is the official collection of .gitignore files from Github,\n> the company, we could ask Jeff or Michael if it is urgent.\n> The actual fix being merged 3 years ago makes me belief\n> it is not urgent though.\n\nIt looks like the fix they have in that repo does the right thing[1],\nbut for reference, you are much more likely to get results by creating\nan issue or PR on that repository, rather than asking me.\n\n-Peff\n\n[1] The double-CR fix works because we strip a single CR from the end of\n the line (as a convenience for CRLF systems), and then the remaining\n CR is syntactically significant. But I am surprised that quoting\n like:\n\n printf '\"Icon\\r\"' >.gitignore\n\n does not seem to work.\n"},{"id":"257987","messageId":"20150318212852.GA28860@peff.net","threadId":"38850","inReplyTo":"20150318211716.GC3376@peff.net","subject":"Re:","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-03-18T21:28:52Z","receivedAt":"2015-03-18T21:28:52Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Mar 18, 2015 at 05:17:16PM -0400, Jeff King wrote:\n\n> [1] The double-CR fix works because we strip a single CR from the end of\n> the line (as a convenience for CRLF systems), and then the remaining\n> CR is syntactically significant. But I am surprised that quoting\n> like:\n> \n> printf '\"Icon\\r\"' >.gitignore\n> \n> does not seem to work.\n\nAnswering myself: we don't do quoting like this in .gitignore. We allow\nbackslashing to escape particular characters, like trailing whitespace.\nSo in theory:\n\n Icon\\\\r\n\n(where \"\\r\" is a literal CR) would work. But it doesn't, because the\nCRLF chomping happens separately, and CR is therefore a special case. I\nsuspect you could not .gitignore a file with a literal LF in it at all\n(and I equally suspect that nobody cares in practice).\n\n-Peff\n"},{"id":"257989","messageId":"CAPc5daXkiwyAF+rXH6ywN-An5F7rHCa0-QVY72LkeeTpAsRisQ@mail.gmail.com","threadId":"38850","inReplyTo":"20150318212852.GA28860@peff.net","subject":"Re:","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-03-18T21:33:01Z","receivedAt":"2015-03-18T21:33:01Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"On Wed, Mar 18, 2015 at 2:28 PM, Jeff King wrote:\n> On Wed, Mar 18, 2015 at 05:17:16PM -0400, Jeff King wrote:\n>\n>> [1] The double-CR fix works because we strip a single CR from the end of\n>> the line (as a convenience for CRLF systems), and then the remaining\n>> CR is syntactically significant. But I am surprised that quoting\n>> like:\n>>\n>> printf '\"Icon\\r\"' >.gitignore\n>>\n>> does not seem to work.\n>\n> Answering myself: we don't do quoting like this in .gitignore. We allow\n> backslashing to escape particular characters, like trailing whitespace.\n> So in theory:\n>\n> Icon\\\\r\n>\n> (where \"\\r\" is a literal CR) would work. But it doesn't, because the\n> CRLF chomping happens separately, and CR is therefore a special case. I\n> suspect you could not .gitignore a file with a literal LF in it at all\n> (and I equally suspect that nobody cares in practice).\n\nWhat does the Icon^M try to catch, exactly? Is it a file? Is it a directory?\nIs it \"anything that begins with Icon^M\"?\n\nI am wondering if we need an opposite of '/' prefix in the .gitignore file\nto say \"the pattern does not match a directory, only a file\".\n"},{"id":"257990","messageId":"CAGZ79kZwc-==jfoW3zUC94sUfnPUv0sqZwupi3R-UK=pGn-5iA@mail.gmail.com","threadId":"38850","inReplyTo":"CAPc5daXkiwyAF+rXH6ywN-An5F7rHCa0-QVY72LkeeTpAsRisQ@mail.gmail.com","subject":"Re:","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-03-18T21:45:11Z","receivedAt":"2015-03-18T21:45:11Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Wed, Mar 18, 2015 at 2:33 PM, Junio C Hamano wrote:\n> What does the Icon^M try to catch, exactly? Is it a file? Is it a directory?\n> Is it \"anything that begins with Icon^M\"?\n\nIt seems to be a special hidden file on Macs for UI convenience.\n\n> On Apr 25, 2005, at 6:21 AM, Peter N. Lundblad wrote:\n>\n> The Icon^M file in a directory gives that directory a custom icon in\n> the Finder. They are a holdover from MacOS 9 but there are still a lot\n> of them out there. The \"new\" OS X format for icons are .icns files but\n> I'm not sure if you can do custom file directory icons with them (you\n> probably can, I just haven't found the docs yet).\n>\n"}]}