{"thread":{"id":"38818","subject":"Re: [PATCH v2] git prompt: Use toplevel to find untracked files.","startedAt":"2015-03-16T00:54:08Z","lastAt":"2015-03-21T08:46:12Z","messageCount":2,"participants":["Cody Taylor","SZEDER Gábor"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"257764","messageId":"CAHWMk2aq7dW5nBW1f8T4TWfRC70hp-6kR5P79m_E4zccuy53aA@mail.gmail.com","threadId":"38818","inReplyTo":null,"subject":"Re: [PATCH v2] git prompt: Use toplevel to find untracked files.","fromName":"Cody Taylor","fromEmail":"cody.taylor@maternityneighborhood.com","sentAt":"2015-03-16T00:54:08Z","receivedAt":"2015-03-16T00:54:08Z","isPatch":true,"sender":{"key":"cody.taylor@maternityneighborhood.com","avatar":null},"body":"SZEDER Gábor <szeder@ira.uka.de> writes:\n> Somehow I had a hard time making sense out of \"when the current working\n> directory was not a parent of the untracked file\".  Perhaps \"when the\n> untracked files are outside of the current working directory\" would be\n> easier to grok?\n\nThat description doesn't cover all cases.\n\nScenario #1: Let's say there is an untracked file at `$ROOT/file`.\nWhen your CWD is `$ROOT/`, all is well. If you cd to `$ROOT/src/` the\nls-files command failed to find the untracked file.\n\nScenario #2: Let's say there is an untracked file at `$ROOT/src/file`.\nThe ls-files command would find the file if the CWD is `$ROOT/` or\n`$ROOT/src/`, but not if the CWD is `$ROOT/bin/` or\n`$ROOT/src/folder/`.\n\nYour description may be easier to understand, but I don't agree it's accurate.\n"},{"id":"258238","messageId":"20150321094612.Horde.fk34YSFwRX2Ew3gKIdyzPw5@webmail.informatik.kit.edu","threadId":"38818","inReplyTo":"CAHWMk2aq7dW5nBW1f8T4TWfRC70hp-6kR5P79m_E4zccuy53aA@mail.gmail.com","subject":"Re: [PATCH v2] git prompt: Use toplevel to find untracked files.","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2015-03-21T08:46:12Z","receivedAt":"2015-03-21T08:46:12Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"\nQuoting Cody Taylor <cody.taylor@maternityneighborhood.com>:\n\n> SZEDER Gábor <szeder@ira.uka.de> writes:\n>> Somehow I had a hard time making sense out of \"when the current working\n>> directory was not a parent of the untracked file\".  Perhaps \"when the\n>> untracked files are outside of the current working directory\" would be\n>> easier to grok?\n>\n> That description doesn't cover all cases.\n\nI'm not sure I understand.\nI think we both say the same, though from different views: you  \ndescribe what cwd is not relative to the untracked file in the  \nproblematic case, while I describe where the untracked file is  \nrelative to cwd in the same case.\n\n> Scenario #1: Let's say there is an untracked file at `$ROOT/file`.\n> When your CWD is `$ROOT/`, all is well. If you cd to `$ROOT/src/` the\n> ls-files command failed to find the untracked file.\n\nAfter cd to '$ROOT/src' the untracked file '$ROOT/file' is outside  \ncwd, which matches my description and is what your patch covers.\n\n> Scenario #2: Let's say there is an untracked file at `$ROOT/src/file`.\n> The ls-files command would find the file if the CWD is `$ROOT/` or\n> `$ROOT/src/`, but not if the CWD is `$ROOT/bin/` or\n> `$ROOT/src/folder/`.\n\nAgain, after cd to '$ROOT/bin' the untracked file '$ROOT/src/file' is  \noutside cwd, so my description and your patch cover it.\n\n> Your description may be easier to understand, but I don't agree it's  \n> accurate.\n\nWell, I think it's accurate, but now I doubt that it's easier to understand :)\n\n\nGábor\n"}]}